Page MenuHomePhabricator
Create Task
Maniphest T343396

Implementation reordering deletes short descriptions
Closed, ResolvedPublicBUG REPORT
Actions

Description

Steps to replicate the issue (include links if applicable):
The system job that reorders implementations deletes the Z2K5 value when it stores its reordering.

Here are two examples where the system edit has deleted the Z2K5 value:
https://www.wikifunctions.org/wiki/Z10000?uselang=en&diff=prev&oldid=5082
https://www.wikifunctions.org/wiki/Z10000?uselang=en&diff=prev&oldid=4898

What happens?:
It deletes Z2K5

What should have happened instead?:
It shouldn't change Z2K5

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Details

SubjectRepoBranchLines +/-
Check type of Z_PERSISTENTOBJECT_DESCRIPTION in isValid()mediawiki/extensions/WikiLambdamaster+9 -2
WikiLambda: Add PHP code for Z2K5/'short descriptions'mediawiki/extensions/WikiLambdawmf/1.41.0-wmf.20+92 -4
WikiLambda: Add PHP code for Z2K5/'short descriptions'mediawiki/extensions/WikiLambdamaster+92 -4
Customize query in gerrit

Event Timeline

DVrandecic created this task.Aug 3 2023, 12:25 AM
Quiddity triaged this task as High priority.Aug 3 2023, 12:35 AM
Quiddity subscribed.
DMartin-WMF claimed this task.Aug 3 2023, 12:47 AM
DVrandecic moved this task from To triage to Backlog on the Abstract Wikipedia team board.Aug 3 2023, 12:50 AM
DMartin-WMF added a comment.Aug 3 2023, 1:42 AM

Initial observation: In order to update the function in the DB ((after updating the PHP ZPersistentObject), UpdateImplementationJob.php has to retrieve a serialization of the ZPersistentObject. It gets this from ZObject::getSerialized(). That Method iterates over the data of the ZPersistentObject. But ZPersistentObject.php doesn't know about the (relatively new) Z2K5 field, so that field gets omitted from the serialization.

gerritbot added a comment.Aug 3 2023, 3:11 AM

Change 945003 had a related patch set uploaded (by David Martin; author: David Martin):

[mediawiki/extensions/WikiLambda@master] WikiLambda: Add PHP code for Z2K5/'short descriptions'

https://gerrit.wikimedia.org/r/945003

gerritbot added a project: Patch-For-Review.Aug 3 2023, 3:11 AM
DMartin-WMF changed the task status from Open to In Progress.Aug 3 2023, 4:16 AM
DMartin-WMF moved this task from Backlog to In Progress on the Abstract Wikipedia team board.
Jdforrester-WMF added a project: WikiLambda.Aug 3 2023, 10:43 AM
gerritbot added a comment.Aug 3 2023, 10:51 AM

Change 945003 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] WikiLambda: Add PHP code for Z2K5/'short descriptions'

https://gerrit.wikimedia.org/r/945003

gerritbot added a comment.Aug 3 2023, 10:52 AM

Change 944858 had a related patch set uploaded (by Jforrester; author: David Martin):

[mediawiki/extensions/WikiLambda@wmf/1.41.0-wmf.20] WikiLambda: Add PHP code for Z2K5/'short descriptions'

https://gerrit.wikimedia.org/r/944858

Jdforrester-WMF moved this task from In Progress to To deploy on the Abstract Wikipedia team board.Aug 3 2023, 10:54 AM
ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.22; 2023-08-15).Aug 3 2023, 11:00 AM
gerritbot added a comment.Aug 3 2023, 12:23 PM

Change 944858 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@wmf/1.41.0-wmf.20] WikiLambda: Add PHP code for Z2K5/'short descriptions'

https://gerrit.wikimedia.org/r/944858

Maintenance_bot removed a project: Patch-For-Review.Aug 3 2023, 12:30 PM
Stashbot added a comment.Aug 3 2023, 12:31 PM

Mentioned in SAL (#wikimedia-operations) [2023-08-03T12:31:18Z] <jforrester@deploy1002> Started scap: Backport for [[gerrit:944858|WikiLambda: Add PHP code for Z2K5/'short descriptions' (T343396)]]

Stashbot added a comment.Aug 3 2023, 12:33 PM

Mentioned in SAL (#wikimedia-operations) [2023-08-03T12:32:59Z] <jforrester@deploy1002> jforrester: Backport for [[gerrit:944858|WikiLambda: Add PHP code for Z2K5/'short descriptions' (T343396)]] synced to the testservers mwdebug1002.eqiad.wmnet, mwdebug1001.eqiad.wmnet, mwdebug2001.codfw.wmnet, mwdebug2002.codfw.wmnet, and mw-debug kubernetes deployment (accessible via k8s-experimental XWD option)

Jdforrester-WMF moved this task from To deploy to Verify in production on the Abstract Wikipedia team board.Aug 3 2023, 12:40 PM
Jdforrester-WMF subscribed.

Deployed.

Stashbot added a comment.Aug 3 2023, 12:41 PM

Mentioned in SAL (#wikimedia-operations) [2023-08-03T12:40:59Z] <jforrester@deploy1002> Finished scap: Backport for [[gerrit:944858|WikiLambda: Add PHP code for Z2K5/'short descriptions' (T343396)]] (duration: 09m 41s)

ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.20; 2023-08-01); removed MW-1.41-notes (1.41.0-wmf.22; 2023-08-15).Aug 3 2023, 1:00 PM
Jdforrester-WMF added a comment.Aug 3 2023, 1:22 PM

https://www.wikifunctions.org/wiki/Z10018?uselang=en-gb&diff=prev&oldid=8822 shows this now working as expected. Great work, everyone.

gerritbot added a comment.Aug 3 2023, 6:06 PM

Change 945629 had a related patch set uploaded (by David Martin; author: David Martin):

[mediawiki/extensions/WikiLambda@master] Check type of Z_PERSISTENTOBJECT_DESCRIPTION in isValid()

https://gerrit.wikimedia.org/r/945629

gerritbot added a project: Patch-For-Review.Aug 3 2023, 6:06 PM
gerritbot added a comment.Aug 3 2023, 8:17 PM

Change 945629 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Check type of Z_PERSISTENTOBJECT_DESCRIPTION in isValid()

https://gerrit.wikimedia.org/r/945629

Maintenance_bot removed a project: Patch-For-Review.Aug 3 2023, 8:30 PM
ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.22; 2023-08-15); removed MW-1.41-notes (1.41.0-wmf.20; 2023-08-01).Aug 3 2023, 9:00 PM
DVrandecic closed this task as Resolved.Aug 4 2023, 6:35 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL