Ensure temporary accounts cannot be suppressed via "hideuser"
Closed, DeclinedPublic
Actions

Assigned To

Authored By

	Tchanders
	Aug 7 2023, 11:48 AM

Description

From the parent task:

In T338836#9030364, @JJMC89 wrote:

In T338836#9030178, @Niharika wrote:

Should it be possible to suppress a temporary account user? (It's not possible to suppress an IP user.)

We want to keep the temp accounts experience consistent with current experience for unregistered users so we should disallow hideuser for temp accounts if it is disallowed for IPs currently.

Besides consistency, temporary users should never need to be hidden since their username is automatically generated.

Details

	Subject	Repo	Branch	Lines +/-
	Disallow hiding temporary users via blocks	mediawiki/core	master	+57 -2

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
In Progress	Niharika	T324492 Temporary accounts - MVP
Open	None	T326816 Update features for temporary accounts
Open	None	T331637 Update features in MediaWiki core for IP Masking
Open	Tchanders	T338836 How should blocks treat temporary users?
Declined	Tchanders	T343705 Ensure temporary accounts cannot be suppressed via "hideuser"

Event Timeline

Tchanders created this task.Aug 7 2023, 11:48 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 7 2023, 11:48 AM

Tchanders renamed this task from Ensure that temporary accounts cannot be suppressed via "hideuser" to Ensure temporary accounts cannot be suppressed via "hideuser".Aug 7 2023, 11:48 AM

Tchanders moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to In Progress 💪 on the Anti-Harassment (AHaT Sprint 32 - Baseball Cap) board.

Change 946545 had a related patch set uploaded (by Tchanders; author: Tchanders):

[mediawiki/core@master] Disallow hiding temporary users via blocks

https://gerrit.wikimedia.org/r/946545

gerritbot added a project: Patch-For-Review.Aug 7 2023, 1:11 PM

Tchanders moved this task from In Progress 💪 to Code Review 🔍 on the Anti-Harassment (AHaT Sprint 32 - Baseball Cap) board.Aug 7 2023, 1:15 PM

Tchanders mentioned this in T338836: How should blocks treat temporary users?.Aug 7 2023, 1:27 PM

Change 946545 merged by jenkins-bot:

[mediawiki/core@master] Disallow hiding temporary users via blocks

https://gerrit.wikimedia.org/r/946545

Maintenance_bot removed a project: Patch-For-Review.Aug 18 2023, 10:10 PM

• AGueyte moved this task from Code Review 🔍 to QA/Testing 🐞 on the Anti-Harassment (AHaT Sprint 32 - Baseball Cap) board.Aug 21 2023, 5:52 PM

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.25; 2023-09-05).Aug 29 2023, 8:02 PM

@Tchanders Do we want validation in the case a user has disabled JS?

They can submit the form with the hideuser checkbox checked and this is what they see:

temp_user_hide_nojs.png (363×815 px, 51 KB)

Also, if they are changing an existing block on a temp user they can check the hideuser checkbox and submit straight away without being told it won't apply.

Jules78120 subscribed.Sep 3 2023, 11:21 PM

dom_walden moved this task from QA/Testing 🐞 to Blocked/Stalled 🚧 on the Anti-Harassment (AHaT Sprint 32 - Baseball Cap) board.Sep 5 2023, 5:49 AM

In T343705#9133873, @dom_walden wrote:

@Tchanders Do we want validation in the case a user has disabled JS?

They can submit the form with the hideuser checkbox checked and this is what they see:

Also, if they are changing an existing block on a temp user they can check the hideuser checkbox and submit straight away without being told it won't apply.

This is behaving differently from how it behaves when an IP is entered in the form, but I'm not immediately sure why. Will look into this.

Tchanders edited projects, added Trust and Safety Tools Team Backlog (Kanban); removed Anti-Harassment (AHaT Sprint 32 - Baseball Cap).Oct 19 2023, 2:45 PM

Tchanders edited projects, added Anti-Harassment (AHaT Sprint 32 - Baseball Cap); removed Trust and Safety Tools Team Backlog (Kanban).Oct 19 2023, 2:56 PM

Moving to the backlog while we focus on other work

The work in this task will be undone or partially undone in {T355430}.

Per {T355430}.

Ensure temporary accounts cannot be suppressed via "hideuser"Closed, DeclinedPublicActions

Description

Details

Related ObjectsSearch...

Event Timeline

Ensure temporary accounts cannot be suppressed via "hideuser"
Closed, DeclinedPublic
Actions

Related Objects
Search...