Page MenuHomePhabricator
Create Task
Maniphest T343874

Tables utilising the {{album chart}} template render incorrectly
Closed, ResolvedPublicBUG REPORT
Actions

Description

Steps to replicate the issue (include links if applicable):

What happens?:
For rows utilising the template, there is an additional column created, with the leftmost column reading align="left", with a total of 3 columns for those rows

What should have happened instead?:
The align="left" column should not be displayed, and there should only be 2 columns for all rows. This is how the table is displayed on the website version of Wikipedia, both mobile and desktop.

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.): Wikipedia Beta version 2.7.50449-beta-2023-07-31, Android 13

Appearance on the mobile web (Chrome):

Screenshot_2023-08-09-18-30-19-554_com.android.chrome.png (2×1 px, 313 KB)

Appearance on the Android app:

Screenshot_2023-08-09-18-29-58-492_org.wikipedia.beta.png (2×1 px, 223 KB)

Details

SubjectRepoBranchLines +/-
Bump wikimedia/parsoid to 0.18.0-v23mediawiki/vendormaster+917 -574
TableFixups: Generalize how two adjacent cells combinemediawiki/services/parsoidmaster+110 -63
Bump parsoid to 0.18.0-a22mediawiki/vendormaster+134 -67
Deal with unsupported table combining scenariomediawiki/services/parsoidmaster+37 -7
Customize query in gerrit

Event Timeline

VoicefulBread66 created this task.Aug 9 2023, 10:33 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 9 2023, 10:33 AM
Dbrant renamed this task from Tables utilising the {{album chart}} template render incorrectly on the Android app to Tables utilising the {{album chart}} template render incorrectly.Aug 9 2023, 11:59 AM
Dbrant moved this task from Android Release - FY2023-24 to Needs Triage on the Wikipedia-Android-App-Backlog board.
Dbrant edited projects, added Wikipedia-Android-App-Backlog; removed Wikipedia-Android-App-Backlog (Android Release - FY2023-24).
Dbrant moved this task from Needs Triage to Tracking on the Wikipedia-Android-App-Backlog board.
Dbrant added a project: Content-Transform-Team.
Dbrant subscribed.

This looks like a potential Parsoid issue:
https://en.wikipedia.org/api/rest_v1/page/html/Abbey_Road

Vahurzpu added a project: Parsoid.Aug 9 2023, 2:18 PM
ssastry subscribed.Aug 9 2023, 2:48 PM

This reproduces it. It only fails when embedded in another table that comes from a template. If the "{{col-begin}} is replaced with the contents of the template, it works fine. Some edge case in the table fixup code.

{{col-begin}}
|-
|
{|
|align="left" {{album chart|Flanders|1|artist=The Beatles|album=Abbey Road|access-date=4 October 2019}}
|}
|}
gerritbot added a comment.Aug 9 2023, 11:02 PM

Change 947484 had a related patch set uploaded (by Subramanya Sastry; author: Subramanya Sastry):

[mediawiki/services/parsoid@master] WIP: Deal with unsupported table combining scenario

https://gerrit.wikimedia.org/r/947484

gerritbot added a project: Patch-For-Review.Aug 9 2023, 11:02 PM
ssastry claimed this task.Aug 10 2023, 4:45 AM
ssastry triaged this task as Medium priority.
SLopes-WMF edited projects, added Content-Transform-Team-WIP; removed Content-Transform-Team.Aug 10 2023, 2:14 PM
ssastry added a project: Parsoid-Read-Views (Phase 2 - testwiki Main namespace support).Aug 10 2023, 2:25 PM
cscott moved this task from Backlog to In Progress on the Content-Transform-Team-WIP board.Aug 10 2023, 2:27 PM
ssastry moved this task from In Progress to Code Review on the Content-Transform-Team-WIP board.Aug 10 2023, 3:27 PM
ssastry moved this task from Needs Triage to Bugs & Crashers on the Parsoid board.Aug 10 2023, 5:04 PM
gerritbot added a comment.Aug 10 2023, 11:27 PM

Change 947484 merged by jenkins-bot:

[mediawiki/services/parsoid@master] Deal with unsupported table combining scenario

https://gerrit.wikimedia.org/r/947484

Maintenance_bot removed a project: Patch-For-Review.Aug 10 2023, 11:30 PM
VoicefulBread66 updated the task description. (Show Details)Aug 14 2023, 7:30 AM
Arlolra moved this task from Code Review to To Deploy on the Content-Transform-Team-WIP board.Aug 14 2023, 4:50 PM
gerritbot added a comment.Aug 14 2023, 6:39 PM

Change 948642 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/vendor@master] Bump parsoid to 0.18.0-a22

https://gerrit.wikimedia.org/r/948642

gerritbot added a project: Patch-For-Review.Aug 14 2023, 6:39 PM
gerritbot added a comment.Aug 15 2023, 12:08 AM

Change 948642 merged by jenkins-bot:

[mediawiki/vendor@master] Bump parsoid to 0.18.0-a22

https://gerrit.wikimedia.org/r/948642

Maintenance_bot removed a project: Patch-For-Review.Aug 15 2023, 12:10 AM
MSantos moved this task from To Deploy to To Verify on the Content-Transform-Team-WIP board.Aug 21 2023, 3:04 PM
ssastry added a comment.Aug 28 2023, 2:12 AM

Looks like there is more things to fix. The following snippet doesn't render.

{{col-begin}}
|-
|
{|
|align="left" {{album chart|Czech|23|date=201940|rowheader=true|access-date=8 October 2019}}
|}
|}

Must be some broken regex. To be investigated.

ssastry moved this task from To Verify to In Progress on the Content-Transform-Team-WIP board.Aug 28 2023, 2:12 AM
gerritbot added a comment.Aug 28 2023, 9:13 PM

Change 952918 had a related patch set uploaded (by Subramanya Sastry; author: Subramanya Sastry):

[mediawiki/services/parsoid@master] TableFixups: Generalize how two adjacent cells combine

https://gerrit.wikimedia.org/r/952918

gerritbot added a project: Patch-For-Review.Aug 28 2023, 9:13 PM
ssastry moved this task from In Progress to Code Review on the Content-Transform-Team-WIP board.Aug 28 2023, 9:26 PM
gerritbot added a comment.Sep 6 2023, 8:37 PM

Change 952918 merged by jenkins-bot:

[mediawiki/services/parsoid@master] TableFixups: Generalize how two adjacent cells combine

https://gerrit.wikimedia.org/r/952918

Maintenance_bot removed a project: Patch-For-Review.Sep 6 2023, 9:11 PM
MSantos moved this task from Code Review to To Deploy on the Content-Transform-Team-WIP board.Sep 11 2023, 3:04 PM
gerritbot added a comment.Sep 11 2023, 3:22 PM

Change 956459 had a related patch set uploaded (by Subramanya Sastry; author: Subramanya Sastry):

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.18.0-v23

https://gerrit.wikimedia.org/r/956459

gerritbot added a project: Patch-For-Review.Sep 11 2023, 3:22 PM
gerritbot added a comment.Sep 11 2023, 5:21 PM

Change 956459 merged by jenkins-bot:

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.18.0-v23

https://gerrit.wikimedia.org/r/956459

Maintenance_bot removed a project: Patch-For-Review.Sep 11 2023, 5:31 PM
ssastry closed this task as Resolved.Sep 15 2023, 9:11 PM

Deployed and verified fixed.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL