Codex: Clean up Minerva's use of icons
Closed, ResolvedPublic2 Estimated Story PointsBUG REPORT
Actions

Assigned To

Authored By

	Jdlrobson
	Aug 10 2023, 9:16 PM

Description

After switching to Codex, we should clean up how we handle icons.

TODO

Remove all .mw-ui-icon.*before selectors from icon packs that were kept for cached HTML.
Remove minerva- and wikimedia- prefixes from selectors.
CACHED HTML: For classes rendered on server side for anonymous users, make sure to cater for old class and new class.

Descoped

For any icon rendered via JavaScript, use Codex mixins. e.g. skins.minerva.icons.images.scripts.misc and skins.minerva.icons.page.issues.* - Moved to T346162

Details

Subject	Repo	Branch	Lines +/-
Remove or document remaining mw-ui-icon usages	mediawiki/skins/MinervaNeue	master	+10 -8
Clean up icon selectors from cached HTML	mediawiki/skins/MinervaNeue	master	+7 -7
Remove old :before icon selectors and update selectors to not use minerva and wikimedia prefixes	mediawiki/skins/MinervaNeue	master	+38 -53

Customize query in gerrit

Related Objects

Mentioned In: T321406: Minerva page menu's hard to access using iOS VoiceOver
T346851: Verify 1.41.0-wmf.30 deployment
Mentioned Here: T346162: Icons rendered via JavaScript in Minerva should use Codex mixin

Event Timeline

Jdlrobson created this task.Aug 10 2023, 9:16 PM

Restricted Application added subscribers: Masumrezarock100, Aklapper. · View Herald TranscriptAug 10 2023, 9:16 PM

Volker_E subscribed.Aug 10 2023, 9:25 PM

ovasileva triaged this task as Medium priority.Aug 17 2023, 5:21 PM

ovasileva set the point value for this task to 2.Aug 17 2023, 5:24 PM

ovasileva moved this task from Incoming to Ready for Development on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 5) board.Aug 24 2023, 2:37 PM

bwang claimed this task.Sep 1 2023, 7:28 PM

bwang moved this task from Ready for Development to Doing on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 5) board.

Change 954973 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/skins/MinervaNeue@master] Remove old :before icon selectors and update selectors to not use minerva and wikimedia prefixes

https://gerrit.wikimedia.org/r/954973

gerritbot added a project: Patch-For-Review.Sep 5 2023, 5:49 PM

bwang removed bwang as the assignee of this task.Sep 6 2023, 9:40 PM

bwang moved this task from Doing to Code Review on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 5) board.

bwang subscribed.

Jdlrobson claimed this task.Sep 7 2023, 3:04 PM

Change 954973 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Remove old :before icon selectors and update selectors to not use minerva and wikimedia prefixes

https://gerrit.wikimedia.org/r/954973

Jdlrobson reassigned this task from Jdlrobson to Edtadros.Sep 7 2023, 6:52 PM

Jdlrobson moved this task from Code Review to QA on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 5) board.

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.26; 2023-09-12).Sep 7 2023, 7:00 PM

Maintenance_bot removed a project: Patch-For-Review.Sep 7 2023, 7:11 PM

Jdlrobson claimed this task.Sep 11 2023, 5:15 PM

Jdlrobson moved this task from QA to Ready for Signoff on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 5) board.

Jdlrobson added a subscriber: Edtadros.

I'll sign this off tomorrow after the branch cut when I can merge https://gerrit.wikimedia.org/r/c/mediawiki/skins/MinervaNeue/+/955403

For any icon rendered via JavaScript, use Codex mixins. e.g. skins.minerva.icons.images.scripts.misc and skins.minerva.icons.page.issues.*

@bwang should I open a new task for this? It doesn't look like this was done?

Change 955403 had a related patch set uploaded (by Jdlrobson; author: Bernard Wang):

[mediawiki/skins/MinervaNeue@master] Clean up icon selectors from cached HTML

https://gerrit.wikimedia.org/r/955403

gerritbot added a project: Patch-For-Review.Sep 12 2023, 3:45 PM

In T344022#9157882, @Jdlrobson wrote:

I'll sign this off tomorrow after the branch cut when I can merge https://gerrit.wikimedia.org/r/c/mediawiki/skins/MinervaNeue/+/955403

For any icon rendered via JavaScript, use Codex mixins. e.g. skins.minerva.icons.images.scripts.misc and skins.minerva.icons.page.issues.*

@bwang should I open a new task for this? It doesn't look like this was done?

Ah you are right, my bad on missing that. if you could make a new task for that followup that would be great

Jdlrobson updated the task description. (Show Details)Sep 12 2023, 4:00 PM

Change 955403 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Clean up icon selectors from cached HTML

https://gerrit.wikimedia.org/r/955403

Maintenance_bot removed a project: Patch-For-Review.Sep 12 2023, 4:11 PM

ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.27; 2023-09-19); removed MW-1.41-notes (1.41.0-wmf.26; 2023-09-12).Sep 12 2023, 5:00 PM

Change 956961 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/MinervaNeue@master] Remove or document remaining mw-ui-icon usages

https://gerrit.wikimedia.org/r/956961

gerritbot added a project: Patch-For-Review.Sep 12 2023, 9:24 PM

@bwang please can you review https://gerrit.wikimedia.org/r/c/mediawiki/skins/MinervaNeue/+/956961 to document the other remaining usages and resolve this ticket once that's been merged.

bwang closed this task as Resolved.Sep 13 2023, 4:20 PM

Change 956961 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Remove or document remaining mw-ui-icon usages

https://gerrit.wikimedia.org/r/956961

Maintenance_bot removed a project: Patch-For-Review.Sep 13 2023, 5:10 PM

Jdlrobson mentioned this in T346851: Verify 1.41.0-wmf.30 deployment.Sep 19 2023, 11:25 PM

Jdlrobson added a project: Verified.Sep 19 2023, 11:29 PM

Jdrewniak mentioned this in T321406: Minerva page menu's hard to access using iOS VoiceOver.May 21 2024, 2:57 PM

Codex: Clean up Minerva's use of iconsClosed, ResolvedPublic2 Estimated Story PointsBUG REPORTActions