[wmf.22 - mobile] Impact module overlay misses back navigation arrow button
Closed, ResolvedPublic2 Estimated Story PointsBUG REPORT
Actions

Assigned To

Authored By

	Etonkovidova
	Aug 18 2023, 6:49 AM

Description

Steps to replicate the issue:

On mobile, go Special:Homepage and click on the Impact module
The overlay won't display the back navigation arrow

Screen Shot 2023-08-18 at 9.13.58 AM.png (1×872 px, 146 KB)

What should have happened instead?:
The navigation back arrow button should be present (the screenshot below is from https://phabricator.wikimedia.org/T340199#8959486)

Screenshot 2023-06-23 at 18.31.31.png (1×800 px, 156 KB)

Acceptance Criteria:

Fix
Add a test!

Details

	Subject	Repo	Branch	Lines +/-
	icons: Do not use :before for mw-ui-icon	mediawiki/extensions/GrowthExperiments	master	+1 -1

Customize query in gerrit

Related Objects

Mentioned Here: T340199: [Visual design bug] Vue version of tooltip pop-up header icons are misaligned with header text

Event Timeline

Etonkovidova created this task.Aug 18 2023, 6:49 AM

Restricted Application added a project: Growth-Team. · View Herald TranscriptAug 18 2023, 6:49 AM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Etonkovidova renamed this task from [wmf.22 - mobile] Impact module misses a back arrow navigation icon to [wmf.22 - mobile] Impact module overlay misses back navigation arrow button.Aug 18 2023, 6:49 AM

Etonkovidova attached a referenced file: F37114850: Screenshot 2023-06-23 at 18.31.31.png. (Show Details)Aug 28 2023, 4:18 PM

Sgs moved this task from Inbox to Sprint 0 (Growth Team) on the Growth-Team board.Aug 28 2023, 5:05 PM

Sgs edited projects, added Growth-Team (Sprint 0 (Growth Team)); removed Growth-Team.

KStoller-WMF triaged this task as Medium priority.Oct 11 2023, 8:41 PM

KStoller-WMF moved this task from Sprint 0 (Growth Team) to Backlog on the Growth-Team board.

KStoller-WMF edited projects, added Growth-Team; removed Growth-Team (Sprint 0 (Growth Team)).

DMburugu moved this task from Backlog to Sprint 1 (Growth Team) on the Growth-Team board.Oct 17 2023, 4:43 PM

DMburugu edited projects, added Growth-Team (Sprint 1 (Growth Team)); removed Growth-Team.

KStoller-WMF edited projects, added Growth-Team (Sprint 2 (Growth Team)); removed Growth-Team (Sprint 1 (Growth Team)).Oct 30 2023, 6:58 PM

KStoller-WMF updated the task description. (Show Details)Oct 31 2023, 4:35 PM

KStoller-WMF set the point value for this task to 2.

KStoller-WMF updated the task description. (Show Details)

Sgs moved this task from Incoming to Ready on the Growth-Team (Sprint 2 (Growth Team)) board.Oct 31 2023, 5:13 PM

Change 971116 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] icons: Do not use :before for mw-ui-icon

https://gerrit.wikimedia.org/r/971116

gerritbot added a project: Patch-For-Review.Nov 2 2023, 9:52 AM

This doesn't appear to be a Impact module specific task. Uploaded a patch that fixes the issue.

Urbanecm_WMF moved this task from Ready to Code Review on the Growth-Team (Sprint 2 (Growth Team)) board.Nov 2 2023, 10:06 AM

Urbanecm_WMF moved this task from Code Review to QA on the Growth-Team (Sprint 2 (Growth Team)) board.Nov 2 2023, 1:33 PM

Change 971116 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] icons: Do not use :before for mw-ui-icon

https://gerrit.wikimedia.org/r/971116

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.4; 2023-11-07).Nov 2 2023, 2:00 PM

Maintenance_bot removed a project: Patch-For-Review.Nov 2 2023, 2:10 PM

Fixed on beta:

Screen Shot 2023-11-02 at 11.46.50 AM.png (1×800 px, 166 KB)

Also checked in testwiki wmf.4 - the fix is in place.

Etonkovidova closed this task as Resolved.Nov 8 2023, 1:20 AM

Change 979431 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/GrowthExperiments@master] Fixes overlay exit button and deprecation warnings

https://gerrit.wikimedia.org/r/979431

gerritbot added a project: Patch-For-Review.Dec 14 2023, 11:06 PM

Jdlrobson merged a task: T352582: No icon on mobile growth home page overlay.Dec 14 2023, 11:09 PM

Jdlrobson subscribed.

	F41433635: Screen Shot 2023-11-02 at 11.46.50 AM.png
	Nov 2 2023, 6:47 PM

	F37114850: Screenshot 2023-06-23 at 18.31.31.png
	Aug 18 2023, 6:49 AM

	F37563095: Screen Shot 2023-08-18 at 9.13.58 AM.png
	Aug 18 2023, 6:49 AM

[wmf.22 - mobile] Impact module overlay misses back navigation arrow buttonClosed, ResolvedPublic2 Estimated Story PointsBUG REPORTActions