Language selector broken: Uncaught TypeError: mw.uls.isNamed is not a function
Closed, ResolvedPublicBUG REPORT
Actions

Description

Steps to replicate the issue (include links if applicable):

Go to https://en.wikipedia.beta.wmflabs.org/wiki/Main_Page

What happens?:
jQuery.Deferred exception: mw.uls.isNamed is not a function userCanChangeLanguage@https://en.wikipedia.beta.wmflabs.org/w/load.php?lang=en&modules=startup&only=scripts&raw=1&skin=vector-2022 line 10 > Function:8:162

Uncaught TypeError: mw.uls.isNamed is not a function

userCanChangeLanguage https://en.wikipedia.beta.wmflabs.org/w/load.php?lang=en&modules=startup&only=scripts&raw=1&skin=vector-2022 line 10 > Function:8
initLanguageChangeUndoTooltip https://en.wikipedia.beta.wmflabs.org/w/load.php?lang=en&modules=startup&only=scripts&raw=1&skin=vector-2022 line 10 > Function:13
init https://en.wikipedia.beta.wmflabs.org/w/load.php?lang=en&modules=startup&only=scripts&raw=1&skin=vector-2022 line 10 > Function:16
jQuery 12
runScript https://en.wikipedia.beta.wmflabs.org/w/load.php?lang=en&modules=startup&only=scripts&raw=1&skin=vector-2022:11
execute https://en.wikipedia.beta.wmflabs.org/w/load.php?lang=en&modules=startup&only=scripts&raw=1&skin=vector-2022:13
doPropagation https://en.wikipedia.beta.wmflabs.org/w/load.php?lang=en&modules=startup&only=scripts&raw=1&skin=vector-2022:5
setAndPropagate https://en.wikipedia.beta.wmflabs.org/w/load.php?lang=en&modules=startup&only=scripts&raw=1&skin=vector-2022:6
impl https://en.wikipedia.beta.wmflabs.org/w/load.php?lang=en&modules=startup&only=scripts&raw=1&skin=vector-2022:19
<anonymous> jQuery

What should have happened instead?:
Language selector should work and no error should be thrown

Details

	Subject	Repo	Branch	Lines +/-
	ext.uls.interface.js: Inline isNamed() method	mediawiki/extensions/UniversalLanguageSelector	wmf/1.41.0-wmf.23	+3 -1
	ext.uls.interface.js: Inline isNamed() method	mediawiki/extensions/UniversalLanguageSelector	master	+3 -1

Customize query in gerrit

Related Objects

Mentioned In: T344999: Create a beta cluster equivalent for the Wikimedia-production-error tag
T344964: "mw.uls.isNamed is not a function"

Event Timeline

AlexisJazz created this task.Aug 21 2023, 5:35 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 21 2023, 5:35 PM

New code from https://gerrit.wikimedia.org/r/c/mediawiki/extensions/UniversalLanguageSelector/+/947853, but there is compatibility code for when user.isNamed is not defined, but this is about the wrapper function.
There is a dependency on mediawiki.user for all the changed modules.

Nikerabbit added projects: Language-Team (Language-2023-July-September), Unplanned-Sprint-Work.Aug 22 2023, 9:17 AM

Forgot to mention: error happens both when logged in and not logged in.

Change 951507 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/UniversalLanguageSelector@master] ext.uls.interface.js: Inline isNamed() method

https://gerrit.wikimedia.org/r/951507

gerritbot added a project: Patch-For-Review.Aug 22 2023, 2:11 PM

Change 951507 merged by jenkins-bot:

[mediawiki/extensions/UniversalLanguageSelector@master] ext.uls.interface.js: Inline isNamed() method

https://gerrit.wikimedia.org/r/951507

Maintenance_bot removed a project: Patch-For-Review.Aug 22 2023, 3:10 PM

abi_ claimed this task.Aug 22 2023, 5:07 PM

abi_ triaged this task as High priority.

abi_ moved this task from Quarter Backlog to Check after deployment on the Language-Team (Language-2023-July-September) board.

Change 951487 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/UniversalLanguageSelector@wmf/1.41.0-wmf.23] ext.uls.interface.js: Inline isNamed() method

https://gerrit.wikimedia.org/r/951487

gerritbot added a project: Patch-For-Review.Aug 22 2023, 5:09 PM

Wdwd subscribed.Aug 24 2023, 8:14 AM

KartikMistry merged a task: T344964: "mw.uls.isNamed is not a function".Aug 25 2023, 9:50 AM

KartikMistry mentioned this in T344964: "mw.uls.isNamed is not a function".

KartikMistry added subscribers: MrLinkinPark333, Bugreporter.

Change 951487 merged by jenkins-bot:

[mediawiki/extensions/UniversalLanguageSelector@wmf/1.41.0-wmf.23] ext.uls.interface.js: Inline isNamed() method

https://gerrit.wikimedia.org/r/951487

Mentioned in SAL (#wikimedia-operations) [2023-08-25T10:14:22Z] <kartik@deploy1002> Started scap: Backport for [[gerrit:951487|ext.uls.interface.js: Inline isNamed() method (T344635)]]

Mentioned in SAL (#wikimedia-operations) [2023-08-25T10:15:45Z] <kartik@deploy1002> abi and kartik: Backport for [[gerrit:951487|ext.uls.interface.js: Inline isNamed() method (T344635)]] synced to the testservers mwdebug2002.codfw.wmnet, mwdebug2001.codfw.wmnet, mwdebug1002.eqiad.wmnet, mwdebug1001.eqiad.wmnet, and mw-debug kubernetes deployment (accessible via k8s-experimental XWD option)

Mentioned in SAL (#wikimedia-operations) [2023-08-25T10:28:29Z] <kartik@deploy1002> Finished scap: Backport for [[gerrit:951487|ext.uls.interface.js: Inline isNamed() method (T344635)]] (duration: 14m 06s)

Maintenance_bot removed a project: Patch-For-Review.Aug 25 2023, 10:30 AM

AlexisJazz mentioned this in T344999: Create a beta cluster equivalent for the Wikimedia-production-error tag.Aug 25 2023, 4:28 PM

abi_ closed this task as Resolved.Aug 29 2023, 7:51 AM

abi_ moved this task from Check after deployment to Done on the Language-Team (Language-2023-July-September) board.

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.25; 2023-09-05).Aug 30 2023, 12:02 AM

ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.23; 2023-08-22); removed MW-1.41-notes (1.41.0-wmf.25; 2023-09-05).Aug 30 2023, 3:01 AM

Wdwd unsubscribed.Aug 30 2023, 5:20 PM