Update requireLogin() for temp users on ContactPage extension
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• AGueyte
	Aug 22 2023, 3:20 PM

Description

In T344276, we want to make sure the SpecialPage::requireLogin is used in accordance with the introduction of temporary users. As for now, we want to treat temporary users just like anonymous or IP users.

Request:
Does the ::requireLogin call mean that users must be logged into a named account?

If yes, ::requireNamedUser should be used
If not, no change is needed.

Notes:
RequireLogin was found in the following files:
includes/SpecialContact.php
Code Search Link

QA Results - Local

AC	Status	Details
1	✅	https://phabricator.wikimedia.org/T344722

Details

	Subject	Repo	Branch	Lines +/-
	Treat temporary users as logged out for MustBeLoggedIn config	mediawiki/extensions/ContactPage	master	+2 -2

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
In Progress	Niharika	T324492 Temporary accounts - MVP
Open	None	T326816 Update features for IP Masking
Open	None	T326882 Update Product Infrastructure-owned products that may be affected by IP Masking
Open	None	T335962 Update ContactPage for IP masking
In Progress	None	T344276 Should SpecialPages that return true for ::requireLogin allow access to temporary users?
Resolved	Dreamy_Jazz	T344722 Update requireLogin() for temp users on ContactPage extension

Event Timeline

• AGueyte created this task.Aug 22 2023, 3:20 PM

• AGueyte updated the task description. (Show Details)Aug 22 2023, 3:24 PM

@AGueyte I've not been able to find the file includes/Special/SpecialContentTranslation.php in the ContactPage extension. The usage from codesearch seems to be in includes/SpecialContact.php.

Dreamy_Jazz updated the task description. (Show Details)Aug 22 2023, 4:40 PM

Dreamy_Jazz updated the task description. (Show Details)

In T344722#9110722, @Dreamy_Jazz wrote:

@AGueyte I've not been able to find the file includes/Special/SpecialContentTranslation.php in the ContactPage extension. The usage from codesearch seems to be in includes/SpecialContact.php.

Noted, thanks for the update.

The ContactPage extension allows forms to specify if they wish to require the user to be logged in. I believe that the intent of this is to require users to have an account. As such, I think this should be a call to ::requireNamedUser. A separate config to allow temporary accounts and named accounts, but not IPs could be added.

Change 951564 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/ContactPage@master] Treat temporary users as logged out for MustBeLoggedIn config

https://gerrit.wikimedia.org/r/951564

gerritbot added a project: Patch-For-Review.Aug 22 2023, 7:25 PM

Dreamy_Jazz added a parent task: T335962: Update ContactPage for IP masking.Aug 22 2023, 7:36 PM

• AGueyte changed the task status from Open to In Progress.Sep 5 2023, 2:00 PM

• AGueyte added a project: Anti-Harassment (AHaT Sprint 32 - Baseball Cap).Sep 5 2023, 3:40 PM

• AGueyte moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to Code Review 🔍 on the Anti-Harassment (AHaT Sprint 32 - Baseball Cap) board.

• AGueyte moved this task from Code Review 🔍 to QA/Testing 🐞 on the Anti-Harassment (AHaT Sprint 32 - Baseball Cap) board.Sep 5 2023, 4:05 PM

Change 951564 merged by jenkins-bot:

[mediawiki/extensions/ContactPage@master] Treat temporary users as logged out for MustBeLoggedIn config

https://gerrit.wikimedia.org/r/951564

Dreamy_Jazz mentioned this in rECPA068fbc63fc6d: Treat temporary users as logged out for MustBeLoggedIn config.Sep 5 2023, 4:09 PM

Maintenance_bot removed a project: Patch-For-Review.Sep 5 2023, 4:10 PM

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.26; 2023-09-12).Sep 5 2023, 5:00 PM

Dreamy_Jazz claimed this task.Sep 13 2023, 4:08 PM

Assigning this to myself as I created the patch.

@AGueyte Temp accounts are treated as not logged in when trying to access Special:Contact as seen in the gif. I will move this to Done. Thanks for all your work!

Status: ✅ PASS
Environment: Local: 1.41.0-alpha (3c881e4) 18:32, 12 September 2023.
OS: macOS Ventura
Browser: Chrome 116
Device: MBA M2
Emulated Device:: N/A
Test Links:
Special:Contact