Page MenuHomePhabricator

PageMigration maps translation units incorrectly
Closed, ResolvedPublic2 Estimated Story PointsBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

What happens?:

The translation for the title is the first translation unit and all the other units are mapped incorrectly

image.png (875×1 px, 42 KB)

And the import also happens incorrectly. See: https://translatewiki.net/w/i.php?title=Translations%3AUser%3AAbijeet_Patro%2FTranslateHelpMoved-2023-07-05%2FPage_display_title%2Ffr&diff=11842466&oldid=11698216

What should have happened instead?:
The translations should be mapped correctly.

Software version (skip for WMF-hosted wikis like Wikipedia):
MediaWiki: master
Translate: master

Event Timeline

And the import also happens incorrectly. See: https://translatewiki.net/w/i.php?title=Translations%3AUser%3AAbijeet_Patro%2FTranslateHelpMoved-2023-07-05%2FPage_display_title%2Ffr&diff=11842466&oldid=11698216

Do you mean that the import is incorrect in yet another way, or that it does what you see on the special page upon pressing the Save button? If the latter, I think that part is okay – if it shows that it will break things, I’d expect it to really break things. (Of course, it shouldn’t show that it will break things in the first place.)

And the import also happens incorrectly. See: https://translatewiki.net/w/i.php?title=Translations%3AUser%3AAbijeet_Patro%2FTranslateHelpMoved-2023-07-05%2FPage_display_title%2Ffr&diff=11842466&oldid=11698216

Do you mean that the import is incorrect in yet another way, or that it does what you see on the special page upon pressing the Save button? If the latter, I think that part is okay – if it shows that it will break things, I’d expect it to really break things. (Of course, it shouldn’t show that it will break things in the first place.)

This is upon saving the button, so the latter.

Change 1008389 had a related patch set uploaded (by Wangombe; author: Wangombe):

[mediawiki/extensions/Translate@master] Special:PageMigration Align the source and translation headers

https://gerrit.wikimedia.org/r/1008389

abi_ set the point value for this task to 2.

Testing the latest patch, if I fix the return unshift bug, I get this for a page where display title is translatable. It doesn't look correct:

image.png (1×1 px, 58 KB)

Change #1008389 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] Special:PageMigration: Align the source and translation headers

https://gerrit.wikimedia.org/r/1008389

Tested this on translatewiki.net:

image.png (811×1 px, 53 KB)