Incorrect highlights on thumbnails icon
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	eamedina
	Aug 23 2023, 6:12 PM

Description

Sometimes the selected frame border style ( blue border around each frame in the bottom row) is not being placed correctly around the image itself but rather around the icon. We need to investigate how exactly to replicate this behavior

Wrong placement: (iOS safari)

Expected styling:

QA Results - Beta

AC	Status	Details
1	✅	https://phabricator.wikimedia.org/T344847 here

Details

	Subject	Repo	Branch	Lines +/-
	fix thumbnail border style for safari	mediawiki/extensions/Wikistories	master	+10 -4

Customize query in gerrit

Related Objects

Mentioned In: T341620: Update Frames component to use StoryImage
Mentioned Here: rMW7c1c98d35956: Merge "rdbms: Log query runtime in milliseconds with microsecond resolution"

Event Timeline

eamedina created this task.Aug 23 2023, 6:12 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 23 2023, 6:12 PM

eamedina triaged this task as Low priority.Aug 23 2023, 6:12 PM

eamedina mentioned this in T341620: Update Frames component to use StoryImage.Aug 23 2023, 6:14 PM

hueitan updated the task description. (Show Details)Aug 24 2023, 11:56 AM

SBisson renamed this task from Minor incorrect styling placement to Incorrect highlights on thumbnails icon.Oct 19 2023, 1:53 PM

PWaigi-WMF moved this task from Backlog to Ready for Dev on the Inuka-Team (Kanban) board.Oct 19 2023, 2:35 PM

hueitan claimed this task.Nov 8 2023, 8:40 PM

hueitan moved this task from Ready for Dev to Dev on the Inuka-Team (Kanban) board.

Change 972893 had a related patch set uploaded (by Huei Tan; author: Huei Tan):

[mediawiki/extensions/Wikistories@master] fix thumbnail border style for safari

https://gerrit.wikimedia.org/r/972893

gerritbot added a project: Patch-For-Review.Nov 8 2023, 8:56 PM

hueitan moved this task from Dev to Code Review on the Inuka-Team (Kanban) board.Nov 8 2023, 9:07 PM

Change 972893 merged by jenkins-bot:

[mediawiki/extensions/Wikistories@master] fix thumbnail border style for safari

https://gerrit.wikimedia.org/r/972893

Maintenance_bot removed a project: Patch-For-Review.Nov 9 2023, 5:31 PM

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.5; 2023-11-14).Nov 9 2023, 6:00 PM

SBisson moved this task from Code Review to QA on the Inuka-Team (Kanban) board.Nov 10 2023, 12:17 AM

PWaigi-WMF changed the task status from Open to In Progress.Nov 17 2023, 5:44 PM

@hueitan Frame border style is around the image and not the icon as seen in the screenshots below. The task will be moved to Design Sign-off. Thanks for all your work!

Status: ✅PASS
Environment: Beta: 1.42.0-alpha (7c1c98d)
OS: Latest from BrowserStack
Browser: Chrome, Firefox, Safari, Edge
Skins. Mobile Minerva
Device: MBA M2
Emulated Device:: Browerstack- various
Test Links:
https://en.m.wikipedia.beta.wmflabs.org/w/index.php?title=Special:StoryBuilder/Story:Harry_Quotes&frameid=0#story

✅AC1: https://phabricator.wikimedia.org/T344847

iphone 13-Safari	iphone 13-Chrome	iPad 10th- Safari	Galaxy S21- Edge	Pixel 7- Chrome	OnePlus 11R- Firefox	iPhone 8- Safari	ipad 8th- Chrome