Maniphest T345006

Mobile loading toolbar has top margin when switching from visual to source
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Esanders
	Aug 25 2023, 5:39 PM

Tags

Referenced Files

	F37630587: image.png
	Aug 25 2023, 5:39 PM

Subscribers

Description

Spotted by @DLynch

image.png (451×421 px, 60 KB)

Probably caused by https://gerrit.wikimedia.org/r/c/mediawiki/extensions/MobileFrontend/+/913000

Details

	Subject	Repo	Branch	Lines +/-
	Follow-up I359c68832: Fix VE fake toolbar selector	mediawiki/extensions/MobileFrontend	master	+1 -1
	Don't apply top margin to loading toolbar	mediawiki/extensions/MobileFrontend	master	+1 -1

Customize query in gerrit

Event Timeline

Esanders created this task.Aug 25 2023, 5:39 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 25 2023, 5:39 PM

Change 952481 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/MobileFrontend@master] Don't apply top margin to loading toolbar

https://gerrit.wikimedia.org/r/952481

gerritbot added a project: Patch-For-Review.Aug 25 2023, 5:40 PM

Esanders claimed this task.Aug 25 2023, 5:41 PM

Esanders added a project: Editing-team (Kanban Board).

Esanders moved this task from Incoming to Code Review on the Editing-team (Kanban Board) board.

Change 952481 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontend@master] Don't apply top margin to loading toolbar

https://gerrit.wikimedia.org/r/952481

Maintenance_bot removed a project: Patch-For-Review.Aug 25 2023, 8:10 PM

matmarex moved this task from Code Review to QA on the Editing-team (Kanban Board) board.Aug 25 2023, 8:48 PM

matmarex added a project: Editing QA.

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.25; 2023-09-05).Aug 30 2023, 3:02 AM

ppelberg moved this task from QA to Blocked / Needs More Work on the Editing-team (Kanban Board) board.Sep 12 2023, 5:22 PM

Change 956932 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/MobileFrontend@master] Follow-up I359c68832: Fix VE fake toolbar selector

https://gerrit.wikimedia.org/r/956932

gerritbot added a project: Patch-For-Review.Sep 12 2023, 5:35 PM

Change 956932 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontend@master] Follow-up I359c68832: Fix VE fake toolbar selector

https://gerrit.wikimedia.org/r/956932

Maintenance_bot removed a project: Patch-For-Review.Sep 12 2023, 6:29 PM

ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.27; 2023-09-19); removed MW-1.41-notes (1.41.0-wmf.25; 2023-09-05).Sep 12 2023, 7:00 PM

Ryasmeen moved this task from Blocked / Needs More Work to Ready for Sign Off on the Editing-team (Kanban Board) board.Sep 18 2023, 7:13 PM

Ryasmeen edited projects, added Verified; removed Editing QA.

ppelberg closed this task as Resolved.Sep 19 2023, 11:42 PM