Do not limit the new ISA Campaign title length
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	Bennylin
	Aug 29 2023, 10:18 AM

Description

Steps to replicate the issue (include links if applicable):

Create a new ISA campaign: https://isa.toolforge.org/campaigns/create
Title is limited to 20 char
Previously it wasn't limited

What happens?:
In the past I created many campaigns, there were no such restrictions.

Currently the title is limited to 20 chars:

<input class="form-control form-control-sm" id="campaign_name" maxlength="20" minlength="2" name="campaign_name" required="" type="text" value="">

What should have happened instead?:

Don't limit it.

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Details

	Subject	Repo	Branch	Lines +/-
	Increase limit of new ISA Campaign title length	labs/tools/Isa	main	+1 -1

Customize query in gerrit

Related Objects

Mentioned In: rLTISd9000c96cf73: Increase limit of new ISA Campaign title length
T345120: Re-instate the former character length allowed for the name of the campaign
T344107: Campaigns cannot be created

Event Timeline

Bennylin created this task.Aug 29 2023, 10:18 AM

Bennylin mentioned this in T344107: Campaigns cannot be created.Aug 29 2023, 10:55 AM

The max string length in the database is 200 characters (String(200)). Not sure if that's characters or bytes. I don't know a lot about databases, but I think you kinda have to set a limit on string length (which is annoying).

200 is okay, but surely 20 is too short. Who decided to shorten it to 20?

Anyone working on this? I can send a fix quickly, but does anyone know why a limit was set and to 20? Maybe we are missing something?

If no one replies within a week, feel free to fix this annoying bug.

Noted

Mh-3110 claimed this task.Sep 5 2023, 7:12 AM

Change 956462 had a related patch set uploaded (by Mh-3110; author: Mahuton):

[labs/tools/Isa@main] Increase limit of new ISA Campaign title length

https://gerrit.wikimedia.org/r/956462

gerritbot added a project: Patch-For-Review.Sep 11 2023, 3:53 PM

Hi,
Does anyone know when this fix will be in prod? It already passes the review with success: https://gerrit.wikimedia.org/r/c/labs/tools/Isa/+/956462/

Ping: @Eugene233 @Bennylin

Thanks

Mh-3110 added a subscriber: Eugene233.Oct 18 2023, 4:16 PM

Bennylin mentioned this in T345120: Re-instate the former character length allowed for the name of the campaign.Dec 5 2023, 8:24 AM

Anthere added a project: Wiki-Mentor-Africa.Jan 18 2024, 7:03 PM

Anthere triaged this task as High priority.Jan 18 2024, 7:33 PM

Eugene233 moved this task from Backlog to Review on the Wiki-Mentor-Africa board.Jan 19 2024, 10:21 AM

Change 956462 merged by jenkins-bot:

[labs/tools/Isa@main] Increase limit of new ISA Campaign title length

https://gerrit.wikimedia.org/r/956462

• Mah3110 mentioned this in rLTISd9000c96cf73: Increase limit of new ISA Campaign title length.Feb 6 2024, 5:24 AM

Eugene233 moved this task from Backlog to In progress on the ISA board.Feb 12 2024, 8:12 AM