Remove similar-users service from k8s
Open, Needs TriagePublic
Actions

Assigned To

None

Authored By

	hnowlan
	Aug 30 2023, 3:55 PM

Description

The similar-users service is at present unowned and unmaintained. There are some outstanding tasks that currently relate to maintenance work on it that will probably not get done in the short-term. The service should be decommissioned for the time being until its use is clearly planned. The SimilarEditors extension (which uses the service itself) has been undeployed as it requires further effort put into it. I think we have clear justification to for the time being removing the service from k8s.

Related issues:

T344742: Migrate mediawiki/services/similar-users to GitLab
{T338104}

Drop from SRE monitoring, DNS entries/etc.
Drop from MediaWiki config
Run helmfile -e staging -i destroy etc. in production
Delete helm chart (patch)

Details

Subject	Repo	Branch	Lines +/-
wmnet: remove similar-users	operations/dns	master	+0 -6
service: remove similar-users from realserver, set service_setup	operations/puppet	production	+1 -2
service: set similar-users to lvs_setup	operations/puppet	production	+1 -1
Undeploy the 'similar-users' service, unused for now	operations/deployment-charts	master	+0 -1 K

Customize query in gerrit

Related Objects

Mentioned In: T300033: Use cert-manager for service-proxy certificate creation
Mentioned Here: T300033: Use cert-manager for service-proxy certificate creation
T344742: Migrate mediawiki/services/similar-users to GitLab

Event Timeline

hnowlan created this task.Aug 30 2023, 3:55 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 30 2023, 3:55 PM

@Niharika @Tchanders any concerns with this?

hnowlan updated the task description. (Show Details)Aug 31 2023, 11:32 AM

Niharika updated the task description. (Show Details)Sep 7 2023, 6:34 AM

Clement_Goubert moved this task from Incoming 🐫 to 🛎 Services & Oids on the serviceops board.Sep 18 2023, 11:30 AM

JMeybohm mentioned this in T300033: Use cert-manager for service-proxy certificate creation.Sep 20 2023, 9:00 AM

In T345274#9131624, @kostajh wrote:

@Niharika @Tchanders any concerns with this?

Can we please get your feedback on this? It would help to decide whether to put additional work into keeping the similar-users chart up to date.

JMeybohm added a subscriber: Kappakayala.Oct 20 2023, 9:57 AM

In T345274#9267646, @JMeybohm wrote:

In T345274#9131624, @kostajh wrote:

@Niharika @Tchanders any concerns with this?

Can we please get your feedback on this? It would help to decide whether to put additional work into keeping the similar-users chart up to date.

We are interested to use the service but can't commit to a specific timeline for when it would be connected to a MediaWiki extension interface, because we're sorting out the roadmap and timelines for Trust and Safety Product Team, and have a lot of ongoing projects.

Is it a lot of effort to keep the chart up to date?

In T345274#9267674, @kostajh wrote:

In T345274#9267646, @JMeybohm wrote:

In T345274#9131624, @kostajh wrote:

@Niharika @Tchanders any concerns with this?

Can we please get your feedback on this? It would help to decide whether to put additional work into keeping the similar-users chart up to date.

We are interested to use the service but can't commit to a specific timeline for when it would be connected to a MediaWiki extension interface, because we're sorting out the roadmap and timelines for Trust and Safety Product Team, and have a lot of ongoing projects.

Is it a lot of effort to keep the chart up to date?

I did not check before asking, but it does not seem to be a bit effort for now (context is T300033). I'll add a patch for similar-users for not.

It would still be good to get a decision here. Especially if you want to use this service in the future I would strongly advice to find an owner/maintainer first.

Thanks @JMeybohm

We did once talk about owning this service ourselves (as AHT), and the decision was no that time... @Madalina, @kostajh @Niharika, might be something to revisit?

In T345274#9267674, @kostajh wrote:

In T345274#9267646, @JMeybohm wrote:

In T345274#9131624, @kostajh wrote:

@Niharika @Tchanders any concerns with this?

Can we please get your feedback on this? It would help to decide whether to put additional work into keeping the similar-users chart up to date.

We are interested to use the service but can't commit to a specific timeline for when it would be connected to a MediaWiki extension interface, because we're sorting out the roadmap and timelines for Trust and Safety Product Team, and have a lot of ongoing projects.

Is it a lot of effort to keep the chart up to date?

It is non-zero effort, and I don't see the point in doing this if, clearly, there is still no use for this service in production.

The code won't completely disappear, we just don't need to keep maintaining on our side while a decision is made on the service use.

In T345274#9571082, @Joe wrote:

In T345274#9267674, @kostajh wrote:

In T345274#9267646, @JMeybohm wrote:

In T345274#9131624, @kostajh wrote:

@Niharika @Tchanders any concerns with this?

Can we please get your feedback on this? It would help to decide whether to put additional work into keeping the similar-users chart up to date.

We are interested to use the service but can't commit to a specific timeline for when it would be connected to a MediaWiki extension interface, because we're sorting out the roadmap and timelines for Trust and Safety Product Team, and have a lot of ongoing projects.

Is it a lot of effort to keep the chart up to date?

It is non-zero effort, and I don't see the point in doing this if, clearly, there is still no use for this service in production.

The code won't completely disappear, we just don't need to keep maintaining on our side while a decision is made on the service use.

It doesn't seem like there's support for using this in production right now. I'd like for @Tchanders and @JayCano to approve the undeployment. From my point of view, it is fine to undeploy, and we can bring it back if/when we decide we want to use it.

I'm still interested to see how well the SimilarUsers app might work for certain types of abuse of temporary accounts, but we can verify that without a production instance of this tool.

@Joe I can approve an undeployment. I think this will need a fair amount of reworking if and when we pick it back up again, and it doesn't make sense to add to your maintenance burden any more.

akosiaris awarded a token.Feb 26 2024, 12:56 PM

akosiaris subscribed.

Change 1009538 had a related patch set uploaded (by Jforrester; author: Jforrester):

[operations/deployment-charts@master] Undeploy the 'similar-users' service, unused for now

https://gerrit.wikimedia.org/r/1009538

gerritbot added a project: Patch-For-Review.Mar 7 2024, 2:08 PM

Jdforrester-WMF updated the task description. (Show Details)Mar 7 2024, 2:58 PM

Change #1014495 had a related patch set uploaded (by Hnowlan; author: Hnowlan):

[operations/dns@master] wmnet: remove similar-users

https://gerrit.wikimedia.org/r/1014495

Change #1014499 had a related patch set uploaded (by Hnowlan; author: Hnowlan):

[operations/puppet@production] service: set similar-users to lvs_setup