Page MenuHomePhabricator
Create Task
Maniphest T345369

PHP Deprecated: Use of TablePager::getBody Called from SpecialCentralNoticeBanners::showBannerEditor
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error
labels.normalized_message
[{reqId}] {exception_url}   PHP Deprecated: Use of TablePager::getBody was deprecated in MediaWiki 1.24. [Called from SpecialCentralNoticeBanners::showBannerEditor]
error.stack_trace
from /srv/mediawiki/php-1.41.0-wmf.24/extensions/CentralNotice/includes/specials/SpecialCentralNoticeBanners.php(539)
#0 [internal function]: MWExceptionHandler::handleError(integer, string, string, string, array)
#1 /srv/mediawiki/php-1.41.0-wmf.24/includes/debug/MWDebug.php(383): trigger_error(string, integer)
#2 /srv/mediawiki/php-1.41.0-wmf.24/includes/debug/MWDebug.php(354): MWDebug::sendRawDeprecated(string, boolean, string)
#3 /srv/mediawiki/php-1.41.0-wmf.24/includes/debug/MWDebug.php(235): MWDebug::deprecatedMsg(string, string, string, integer)
#4 /srv/mediawiki/php-1.41.0-wmf.24/includes/GlobalFunctions.php(774): MWDebug::deprecated(string, string, string, integer)
#5 /srv/mediawiki/php-1.41.0-wmf.24/includes/pager/TablePager.php(80): wfDeprecated(string, string)
#6 /srv/mediawiki/php-1.41.0-wmf.24/extensions/CentralNotice/includes/specials/SpecialCentralNoticeBanners.php(539): TablePager->getBody()
#7 /srv/mediawiki/php-1.41.0-wmf.24/extensions/CentralNotice/includes/specials/SpecialCentralNoticeBanners.php(95): SpecialCentralNoticeBanners->showBannerEditor()
#8 /srv/mediawiki/php-1.41.0-wmf.24/includes/specialpage/SpecialPage.php(701): SpecialCentralNoticeBanners->execute(string)
#9 /srv/mediawiki/php-1.41.0-wmf.24/includes/specialpage/SpecialPageFactory.php(1566): SpecialPage->run(string)
#10 /srv/mediawiki/php-1.41.0-wmf.24/includes/MediaWiki.php(344): MediaWiki\SpecialPage\SpecialPageFactory->executePath(string, RequestContext)
#11 /srv/mediawiki/php-1.41.0-wmf.24/includes/MediaWiki.php(942): MediaWiki->performRequest()
#12 /srv/mediawiki/php-1.41.0-wmf.24/includes/MediaWiki.php(591): MediaWiki->main()
#13 /srv/mediawiki/php-1.41.0-wmf.24/index.php(50): MediaWiki->run()
#14 /srv/mediawiki/php-1.41.0-wmf.24/index.php(46): wfIndexMain()
#15 /srv/mediawiki/w/index.php(3): require(string)
#16 {main}
Notes
  • Seems to have started when we moved meta to 1.41.0-wmf.24
  • Happens for many different URLs, not limited to any specific banner

Details

Request URL
https://meta.wikimedia.org/wiki/Special:CentralNoticeBanners/Edit/*
SubjectRepoBranchLines +/-
Migrate calls to TablePager::getBody to ::getBodyOutputmediawiki/extensions/CentralNoticemaster+2 -2
Customize query in gerrit

Event Timeline

thcipriani created this task.Aug 31 2023, 3:12 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 31 2023, 3:12 PM
thcipriani moved this task from Untriaged to Aug 2023 on the Wikimedia-production-error board.Aug 31 2023, 3:12 PM
thcipriani added a comment.Aug 31 2023, 3:34 PM

Also called in CentralNotice::outputListOfNotices

Error
labels.normalized_message
[{reqId}] {exception_url}   PHP Deprecated: Use of TablePager::getBody was deprecated in MediaWiki 1.24. [Called from CentralNotice::outputListOfNotices]
error.stack_trace
from /srv/mediawiki/php-1.41.0-wmf.24/extensions/CentralNotice/includes/specials/CentralNotice.php(141)
#0 [internal function]: MWExceptionHandler::handleError(integer, string, string, string, array)
#1 /srv/mediawiki/php-1.41.0-wmf.24/includes/debug/MWDebug.php(383): trigger_error(string, integer)
#2 /srv/mediawiki/php-1.41.0-wmf.24/includes/debug/MWDebug.php(354): MWDebug::sendRawDeprecated(string, boolean, string)
#3 /srv/mediawiki/php-1.41.0-wmf.24/includes/debug/MWDebug.php(235): MWDebug::deprecatedMsg(string, string, string, integer)
#4 /srv/mediawiki/php-1.41.0-wmf.24/includes/GlobalFunctions.php(774): MWDebug::deprecated(string, string, string, integer)
#5 /srv/mediawiki/php-1.41.0-wmf.24/includes/pager/TablePager.php(80): wfDeprecated(string, string)
#6 /srv/mediawiki/php-1.41.0-wmf.24/extensions/CentralNotice/includes/specials/CentralNotice.php(141): TablePager->getBody()
#7 /srv/mediawiki/php-1.41.0-wmf.24/extensions/CentralNotice/includes/specials/CentralNotice.php(107): CentralNotice->outputListOfNotices()
#8 /srv/mediawiki/php-1.41.0-wmf.24/includes/specialpage/SpecialPage.php(701): CentralNotice->execute(NULL)
#9 /srv/mediawiki/php-1.41.0-wmf.24/includes/specialpage/SpecialPageFactory.php(1566): SpecialPage->run(NULL)
#10 /srv/mediawiki/php-1.41.0-wmf.24/includes/MediaWiki.php(344): MediaWiki\SpecialPage\SpecialPageFactory->executePath(string, RequestContext)
#11 /srv/mediawiki/php-1.41.0-wmf.24/includes/MediaWiki.php(942): MediaWiki->performRequest()
#12 /srv/mediawiki/php-1.41.0-wmf.24/includes/MediaWiki.php(591): MediaWiki->main()
#13 /srv/mediawiki/php-1.41.0-wmf.24/index.php(50): MediaWiki->run()
#14 /srv/mediawiki/php-1.41.0-wmf.24/index.php(46): wfIndexMain()
#15 /srv/mediawiki/w/index.php(3): require(string)
#16 {main}
gerritbot added a comment.Aug 31 2023, 5:28 PM

Change 954113 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/CentralNotice@master] Migrate calls to TablePager::getBody to ::getBodyOutput

https://gerrit.wikimedia.org/r/954113

gerritbot added a project: Patch-For-Review.Aug 31 2023, 5:28 PM
AKanji-WMF moved this task from Triage to Current Sprint on the Fundraising-Backlog board.Sep 5 2023, 8:15 PM
Ejegg added a project: Fundraising Sprint Quit playing games with my Phab 🎶.Sep 6 2023, 3:24 PM
Ejegg moved this task from Backlog to Pending Deployment on the Fundraising Sprint Quit playing games with my Phab 🎶 board.
gerritbot added a comment.Sep 6 2023, 3:26 PM

Change 954113 merged by jenkins-bot:

[mediawiki/extensions/CentralNotice@master] Migrate calls to TablePager::getBody to ::getBodyOutput

https://gerrit.wikimedia.org/r/954113

Maintenance_bot removed a project: Patch-For-Review.Sep 6 2023, 3:29 PM
ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.26; 2023-09-12).Sep 6 2023, 4:00 PM
Umherirrender closed this task as Resolved.Sep 6 2023, 4:59 PM
Umherirrender assigned this task to Jdforrester-WMF.
XenoRyet moved this task from Pending Deployment to Done on the Fundraising Sprint Quit playing games with my Phab 🎶 board.Sep 11 2023, 7:11 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL