Error: Unable to parse title
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	Jdlrobson
	Sep 5 2023, 11:10 PM

Description

16,264 errors in the last 7 days (meets criteria of holding train) starting on 31st August https://wikitech.wikimedia.org/wiki/Deployments/Holding_the_train

at Title https://en.m.wikipedia.org/w/load.php:687:596
at https://en.m.wikipedia.org/w/load.php:161:461
at PhonosButton https://en.m.wikipedia.org/w/load.php:159:487
at https://en.m.wikipedia.org/w/load.php:412:708
at https://en.m.wikipedia.org/w/load.php:410:460
at https://en.m.wikipedia.org/w/load.php:158:270
at each https://en.m.wikipedia.org/w/load.php:244:221
at init https://en.m.wikipedia.org/w/load.php:158:246
at add https://en.m.wikipedia.org/w/load.php:733:433
at ext.phonos.js https://en.m.wikipedia.org/w/load.php:158:315
at runScript https://en.m.wikipedia.org/w/load.php:11:831
at execute https://en.m.wikipedia.org/w/load.php:13:105
at doPropagation https://en.m.wikipedia.org/w/load.php:5:943
at https://en.m.wikipedia.org/w/load.php:22:700
	
tags

QA Results - Beta

AC	Status	Details
1	✅	https://phabricator.wikimedia.org/T345672

Details

	Subject	Repo	Branch	Lines +/-
	Avoid linking to invalid filenames in error message	mediawiki/extensions/Phonos	wmf/1.41.0-wmf.25	+11 -5
	Avoid linking to invalid filenames in error message	mediawiki/extensions/Phonos	master	+11 -5

Customize query in gerrit

Related Objects

Mentioned In: rEPHN366d2698936f: Avoid linking to invalid filenames in error message
rEPHNbbbef403a7c9: Avoid linking to invalid filenames in error message
Mentioned Here: rOMWC42e90fc565b6: IS: Enable Phonos on all projects

Event Timeline

Jdlrobson created this task.Sep 5 2023, 11:10 PM

Restricted Application added a project: Community-Tech. · View Herald TranscriptSep 5 2023, 11:10 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Mostly on mobile site.
https://logstash.wikimedia.org/goto/b8a62567e0c0835483f00f4cde6221fa

Change 955068 had a related patch set uploaded (by Samwilson; author: Samwilson):

[mediawiki/extensions/Phonos@master] Avoid linking to invalid filenames in error message

https://gerrit.wikimedia.org/r/955068

gerritbot added a project: Patch-For-Review.Sep 6 2023, 4:38 AM

Looks like we're trying to create a title while reporting an error with that same title. Instead, we'll catch that error and just show the title and not a link to it.

Samwilson claimed this task.Sep 6 2023, 5:02 AM

Samwilson moved this task from Ready 🎬 to In Development 💻 on the Community-Tech (CommTech-Kanban) board.

Change 955068 merged by jenkins-bot:

[mediawiki/extensions/Phonos@master] Avoid linking to invalid filenames in error message

https://gerrit.wikimedia.org/r/955068

Samwilson mentioned this in rEPHNbbbef403a7c9: Avoid linking to invalid filenames in error message.Sep 6 2023, 5:10 AM

Maintenance_bot removed a project: Patch-For-Review.Sep 6 2023, 5:10 AM

Change 955048 had a related patch set uploaded (by Tim Starling; author: Samwilson):

[mediawiki/extensions/Phonos@wmf/1.41.0-wmf.25] Avoid linking to invalid filenames in error message

https://gerrit.wikimedia.org/r/955048

gerritbot added a project: Patch-For-Review.Sep 6 2023, 5:11 AM

Change 955048 merged by jenkins-bot:

[mediawiki/extensions/Phonos@wmf/1.41.0-wmf.25] Avoid linking to invalid filenames in error message

https://gerrit.wikimedia.org/r/955048

tstarling mentioned this in rEPHN366d2698936f: Avoid linking to invalid filenames in error message.Sep 6 2023, 5:13 AM

Mentioned in SAL (#wikimedia-operations) [2023-09-06T05:28:11Z] <tstarling@deploy1002> Synchronized php-1.41.0-wmf.25/extensions/Phonos: Fix UBN client-side error from malformed Phonos tags T345672 (duration: 06m 51s)

Maintenance_bot removed a project: Patch-For-Review.Sep 6 2023, 5:30 AM

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.25; 2023-09-05).Sep 6 2023, 6:01 AM

I've deployed the fix on wmf.25 so the error should go away once this week's train deployment is complete.

The increase in errors was not caused by a train deployment, it was caused by 42e90fc565b6a0231a08138093088a2e0843c4ec.

It's best to avoid reverting that commit, since a revert would break content pages that use the new parser tag.

As fix is deployed

TheresNoTime moved this task from In Development 💻 to QA 🐛 on the Community-Tech (CommTech-Kanban) board.Sep 6 2023, 10:35 AM

@Samwilson and @HMonroy for the information. I did not come across errors when using <phonos file="foo|bar" /> as seen in the screenshots below. The task will be moved to Done. Thanks for all your work!

Status: ✅ PASS
Environment: Beta
OS: macOS Ventura, Windows 11
Browser: Chrome 116, Firefox 116, Edge 116, Safari 16.6
Device: MBP
Emulated Device:Windows 11 Edge from BrowserStack
Test Links:
Previous Patch: https://en.wikipedia.org/wiki/User:GMikesell-WMF/sandbox
Latest Patch: https://en.wikipedia.beta.wmflabs.org/wiki/Phonos_Files

✅AC1:https://phabricator.wikimedia.org/T345672

Previous Patch	Latest Patch

Thanks for the quick response here! Note this is still an issue in wmf24 so I'm not seeing the errors disappear just yet. If there's any problems with the train you may want to also consider backporting there.
https://logstash.wikimedia.org/goto/bede6c212040408e79e2f247cc9074bd

I'll check again on Friday.

MusikAnimal closed this task as Resolved.Sep 13 2023, 6:03 PM

Error: Unable to parse titleClosed, ResolvedPublicBUG REPORTActions