Maniphest T345688

Add CJS build with entry points for every component
Closed, ResolvedPublic3 Estimated Story Points
Actions

Assigned To

Authored By

	Catrope
	Sep 6 2023, 4:41 AM

Tags

Referenced Files

None

Subscribers

Description

In addition to the single-file UMD build, the UMD codex-search build (which will be moved into the Codex package by T335324) and the ESM build (which will be split into smaller chunks by T345687), we need to add a many-file CJS build that provides an entry point for every component and every composable (every thing that is exported by lib.ts).

There is an entry point file for each component/composable/other thing exported by the library
Chunk file names do not contain hashes
A manifest.json file is included (plus manifest-rtl.json, manifest-legacy.json and manifest-legacy-rtl.json)

Details

	Subject	Repo	Branch	Lines +/-
	build: Generate Codex bundles for every component	design/codex	main	+228 -131
	build: Prefer CJS build to UMD for most usage	design/codex	main	+21 -34

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		CCiufo-WMF	T335317 [EPIC] Determine how to support code-splitting when using Codex inside MediaWiki
		Resolved		egardner	T345688 Add CJS build with entry points for every component

Event Timeline

Catrope created this task.Sep 6 2023, 4:41 AM

Restricted Application added a project: Design-System-Team. · View Herald TranscriptSep 6 2023, 4:42 AM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

CCiufo-WMF moved this task from Inbox to Needs Refinement on the Design-System-Team board.Sep 6 2023, 1:46 PM

A lot of this work has already been done in https://gerrit.wikimedia.org/r/c/design/codex/+/943652 and just needs to be polished a bit further.

CCiufo-WMF triaged this task as High priority.Sep 8 2023, 7:58 PM

bmartinezcalvo edited projects, added Design-System-Team (Design-Systems-Sprint-8); removed Design-System-Team.Sep 11 2023, 5:18 PM

bmartinezcalvo set the point value for this task to 3.

egardner claimed this task.Sep 18 2023, 4:31 PM

egardner moved this task from Committed to In Progress on the Design-System-Team (Design-Systems-Sprint-8) board.Sep 18 2023, 6:36 PM

Change 958597 had a related patch set uploaded (by Eric Gardner; author: Eric Gardner):

[design/codex@main] build: Generate Codex bundles for every component

https://gerrit.wikimedia.org/r/958597

gerritbot added a project: Patch-For-Review.Sep 19 2023, 4:16 AM

egardner moved this task from In Progress to Code Review on the Design-System-Team (Design-Systems-Sprint-8) board.Sep 19 2023, 4:25 AM

Change 958596 had a related patch set uploaded (by Catrope; author: Eric Gardner):

[design/codex@main] build: Replace UMD build with CJS

https://gerrit.wikimedia.org/r/958596

Change 958596 merged by jenkins-bot:

[design/codex@main] build: Prefer CJS build to UMD for most usage

https://gerrit.wikimedia.org/r/958596

Change 958597 merged by jenkins-bot:

[design/codex@main] build: Generate Codex bundles for every component

https://gerrit.wikimedia.org/r/958597

egardner moved this task from Code Review to Pending Release on the Design-System-Team (Design-Systems-Sprint-8) board.Sep 22 2023, 8:40 PM

Maintenance_bot removed a project: Patch-For-Review.Sep 22 2023, 9:10 PM

Change 961452 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/core@master] Update Codex from v0.19.0 to v0.20.0

https://gerrit.wikimedia.org/r/961452

gerritbot added a project: Patch-For-Review.Sep 27 2023, 6:54 PM

egardner closed this task as Resolved.Sep 27 2023, 9:38 PM

Catrope mentioned this in T349423: [EPIC] Implement Codex code splitting in ResourceLoader\CodexModule.Oct 25 2023, 10:55 PM