Page MenuHomePhabricator

Notification icons do not render on Minerva desktop skin
Closed, ResolvedPublic1 Estimated Story PointsBUG REPORT

Description

Likely a breakage due to the switch to Codex that we should address for completness.

Steps to replicate the issue (include links if applicable):

What happens?:

  • No icons
  • Stretched notification count

Screenshot 2023-09-06 at 3.48.47 PM.png (781×1 px, 244 KB)

What should have happened instead?:

  • Bell and notices icon should be visible
  • Ideally counts would not be stretched

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

This would also be a good opportunity to switch to the Codex icon mixin and remove the skins.minerva.icons.loggedin module.

QA Results - Beta

ACStatusDetails
1T345785#9165389
2T345785#9165389

Event Timeline

Jdlrobson triaged this task as Medium priority.Sep 6 2023, 11:03 PM

Change 955408 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/MinervaNeue@master] Fix Echo badges on desktop Minerva, remove module

https://gerrit.wikimedia.org/r/955408

Jdlrobson set the point value for this task to 1.Sep 7 2023, 5:27 PM
ovasileva raised the priority of this task from Medium to High.Sep 8 2023, 9:29 PM

Change 955408 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Fix Echo badges on desktop Minerva, remove module

https://gerrit.wikimedia.org/r/955408

Edtadros subscribed.

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Ventura
Browser: Chrome
Device: MBA
Emulated Device:NA

Test Artifact(s):

QA Steps

Login
Visit https://www.mediawiki.org/wiki/MediaWiki?useskin=minerva or https://en.wikipedia.beta.wmflabs.org/wiki/Conflict-title-0.5326881061131701-I%C3%B1t%C3%ABrn%C3%A2ti%C3%B4n%C3%A0liz%C3%A6ti%C3%B8n?useskin=minerva

✅ AC1: Bell and notices icon should be visible
✅ AC2: Ideally counts would not be stretched

screenshot.png (794×1 px, 148 KB)

Test Result - Prod

Status: ✅ PASS
Environment: enwiki
OS: macOS Ventura
Browser: Chrome
Device: MBA
Emulated Device:NA

Test Artifact(s):

QA Steps

Login
Visit https://en.wikipedia.org/w/index.php?title=Main_Page&useskin=minerva

✅ AC1: Bell and notices icon should be visible
✅ AC2: Ideally counts would not be stretched

screenshot.png (852×1 px, 389 KB)