Minerva Codex migration: section edit buttons should use Button template
Closed, ResolvedPublic1 Estimated Story Points
Actions

Assigned To

Authored By

	Jdlrobson
	Aug 10 2023, 5:01 PM

Description

Follow up work from T342908

Section edit buttons currently use MinervaUI::iconClass to generate their markup

TODO

Switch from HTML::element to Mustache templates

QA

Inspect section edit button markup, make sure they are using .cdx-button and .minerva-icon classes
Ensure same design as before, button states work normally

sign off

Verify there are no performance regressions relating to this change.

QA Results - Beta

AC	Status	Details
1	✅	T344007#9124336
2	✅	T344007#9124336

QA Results - Prod

AC	Status	Details
1	❌	T344007#9153890
2	❌	T344007#9153890

Details

	Subject	Repo	Branch	Lines +/-
	Edit icon uses template parser	mediawiki/skins/MinervaNeue	master	+35 -66

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		None	T343920 Minerva Codex migration: Use Codex
		Resolved		Jdrewniak	T344007 Minerva Codex migration: section edit buttons should use Button template

Event Timeline

Jdlrobson created this task.Aug 10 2023, 5:01 PM

Restricted Application removed a project: Patch-For-Review. · View Herald TranscriptAug 10 2023, 5:01 PM

Jdlrobson triaged this task as High priority.Aug 10 2023, 5:01 PM

Jdlrobson mentioned this in T342908: Minerva should use templates for all backend rendering of its icons and buttons.

Change 947377 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/MinervaNeue@master] Edit icon uses template parser

https://gerrit.wikimedia.org/r/947377

gerritbot added a project: Patch-For-Review.Aug 10 2023, 5:03 PM

ovasileva lowered the priority of this task from High to Medium.Aug 10 2023, 5:13 PM

ovasileva set the point value for this task to 1.

ovasileva moved this task from Incoming to Ready for Development on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 4) board.

Jdlrobson updated the task description. (Show Details)Aug 10 2023, 5:35 PM

bwang claimed this task.Aug 14 2023, 4:33 PM

bwang moved this task from Ready for Development to Doing on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 4) board.

bwang moved this task from Doing to Code Review on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 4) board.

bwang moved this task from Code Review to QA on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 4) board.Aug 16 2023, 10:13 PM

Change 947377 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Edit icon uses template parser

https://gerrit.wikimedia.org/r/947377

@bwang to add test steps specific to this issue

Mhurd reassigned this task from Mhurd to bwang.Aug 18 2023, 6:29 AM

Mhurd subscribed.

@NHillard-WMF I'm unsure if I should move this out of QA? Description says "QA To be done as part of T343920", so probably 🤷‍♂️

I will update the test results when T343920 is tested.

bwang updated the task description. (Show Details)Aug 24 2023, 4:39 PM

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Ventura
Browser: Chrome
Device: MBA
Emulated Device:NA

Test Artifact(s):

QA Steps

✅ AC1: Inspect section edit button markup, make sure they are using .cdx-button and .minerva-icon classes
✅ AC2: Ensure same design as before, button states work normally

Screenshot 2023-08-28 at 9.50.55 AM.png (452×949 px, 97 KB)

Edtadros updated the task description. (Show Details)Aug 28 2023, 4:52 PM

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.25; 2023-09-05).Aug 29 2023, 7:02 PM

ovasileva assigned this task to • Mabualruz.Sep 5 2023, 5:40 PM

Since Mo is out we have reassigned to Jan to unblock Edward.

Jdlrobson updated the task description. (Show Details)Sep 8 2023, 9:57 PM

Test Result - Prod

Status: ❌ FAIL
Environment: enwiki
OS: macOS Ventura
Browser: Chrome
Device: MBA
Emulated Device:NA

Test Artifact(s):

QA Steps

❌ AC1: Inspect section edit button markup, make sure they are using .cdx-button and .minerva-icon classes
❌ AC2: Ensure same design as before, button states work normally

I tested this out in prod and found the following issues

In Chrome and Safari the icons appear momentarily on load

The Echo issue is captured in https://phabricator.wikimedia.org/T345785 and the edit icon is captured in T345969. Thanks for capturing these Edward!

Edtadros reopened this task as Open.Sep 9 2023, 12:04 AM

Edtadros updated the task description. (Show Details)

We'll reflect in our team retrospective what happened here. I've moved the QA steps across to T345969.

Jdlrobson mentioned this in T345969: [Follow up][regression] Edit icons not rendering correctly in Minerva and mediawiki.ui.icon is still loaded.Sep 11 2023, 5:22 PM

Jdlrobson mentioned this in T346944: Edit icons appear as text in Minerva desktop.Sep 20 2023, 4:35 PM

	F37638855: Screenshot 2023-08-28 at 9.50.55 AM.png
	Aug 28 2023, 4:51 PM

	F37676826: screenshot 7.mov.gif
	Sep 8 2023, 11:37 PM

	F37676825: screenshot 6.mov.gif
	Sep 8 2023, 11:37 PM

	F37676820: screenshot 21.png
	Sep 8 2023, 11:37 PM

	F37676819: screenshot 20.png
	Sep 8 2023, 11:37 PM

Minerva Codex migration: section edit buttons should use Button templateClosed, ResolvedPublic1 Estimated Story PointsActions

Description

TODO

QA

sign off

QA Results - Beta

QA Results - Prod

Details

Related ObjectsSearch...

Event Timeline

Test Result - Beta

QA Steps

Test Result - Prod

QA Steps

Minerva Codex migration: section edit buttons should use Button template
Closed, ResolvedPublic1 Estimated Story Points
Actions

Related Objects
Search...