[Follow up][regression] Edit icons not rendering correctly in Minerva and mediawiki.ui.icon is still loaded
Closed, ResolvedPublic2 Estimated Story PointsBUG REPORT
Actions

Assigned To

Authored By

	Jdlrobson
	Sep 8 2023, 11:53 PM

Description

Steps to replicate the issue (include links if applicable):

Go to https://en.m.wikipedia.org/wiki/History_of_China
Scroll to references section

What happens?:

Reference edit icon is smaller than notes.

The edit icon at the top of the page also appears unstyled

What should have happened instead?:

A span tag should be used for the icon
The icons should appear.
The labels should disappear when the screen is resized.
The font size should be the same for all icons

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

QA steps

Test the scenario above for Minerva mobile
Re-run QA in T344007#9124336

QA Results - Beta

AC	Status	Details
1	✅	T345969#9189584
2	✅	T345969#9189584
3	✅	T345969#9189584
4	✅	T345969#9189584
5	✅	T345969#9189584
6	✅	T345969#9189584

Details

	Subject	Repo	Branch	Lines +/-
	Ensure header edit icons are the same size	mediawiki/skins/MinervaNeue	master	+2 -1

Customize query in gerrit

Related Objects

Mentioned In: T344007: Minerva Codex migration: section edit buttons should use Button template
Mentioned Here: T346944: Edit icons appear as text in Minerva desktop
T344007: Minerva Codex migration: section edit buttons should use Button template

Event Timeline

Jdlrobson created this task.Sep 8 2023, 11:53 PM

Restricted Application added subscribers: Masumrezarock100, Aklapper. · View Herald TranscriptSep 8 2023, 11:53 PM

Jdlrobson triaged this task as High priority.Sep 8 2023, 11:53 PM

Jdlrobson mentioned this in T344007: Minerva Codex migration: section edit buttons should use Button template.

Jdlrobson renamed this task from Edit icons do not show in desktop Minerva and mediawiki.ui.icon is still loaded to [Follow up][regression] Edit icons do not show in desktop Minerva and mediawiki.ui.icon is still loaded.Sep 8 2023, 11:56 PM

Jdlrobson updated the task description. (Show Details)

Jdlrobson added a project: Regression.

Jdlrobson renamed this task from [Follow up][regression] Edit icons do not show in desktop Minerva and mediawiki.ui.icon is still loaded to [Follow up][regression] Edit icons not rendering correctly in Minerva and mediawiki.ui.icon is still loaded.Sep 10 2023, 6:05 AM

Jdlrobson updated the task description. (Show Details)

ovasileva moved this task from Incoming to Ready for Development on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 6) board.Sep 11 2023, 2:09 PM

ovasileva set the point value for this task to 2.Sep 11 2023, 5:10 PM

Jdlrobson updated the task description. (Show Details)Sep 11 2023, 5:22 PM

Jdlrobson assigned this task to bwang.Sep 11 2023, 5:54 PM

Change 956490 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/skins/MinervaNeue@master] Ensure header edit icons are the same size

https://gerrit.wikimedia.org/r/956490

gerritbot added a project: Patch-For-Review.Sep 11 2023, 7:13 PM

bwang moved this task from Ready for Development to Doing on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 6) board.Sep 11 2023, 7:16 PM

Change 956514 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/extensions/VisualEditor@master] Update handling of minerva icons

https://gerrit.wikimedia.org/r/956514

bwang removed bwang as the assignee of this task.Sep 11 2023, 11:36 PM

bwang moved this task from Doing to Code Review on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 6) board.

bwang subscribed.

Change 956490 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Ensure header edit icons are the same size

https://gerrit.wikimedia.org/r/956490

Jdlrobson moved this task from Code Review to Blocked on Others on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 6) board.Sep 12 2023, 12:15 AM

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.26; 2023-09-12).Sep 12 2023, 1:00 AM

We raised a question on Slack about how important Minerva desktop is to fix.

I've split out a new ticket for the Minerva desktop issue: T346944.

Jdlrobson assigned this task to Edtadros.Sep 20 2023, 4:36 PM

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Ventura
Browser: Chrome
Device: MBA
Emulated Device:NA

Test Artifact(s):

QA Steps

Go to https://en.m.wikipedia.org/wiki/History_of_China
Scroll to references section
✅ AC1: A span tag should be used for the icon

✅ AC2: The icons should appear.
See AC1

✅ AC3: The labels should disappear when the screen is resized.

✅ AC4: The font size should be the same for all icons

✅ AC5: Inspect section edit button markup, make sure they are using .cdx-button and .minerva-icon classes
See AC1
✅ AC6: Ensure same design as before, button states work normally

Edtadros updated the task description. (Show Details)Sep 22 2023, 1:45 AM

Jdlrobson assigned this task to ovasileva.Sep 22 2023, 10:56 PM

Looks good, resolving!

	F37682595: Screenshot 2023-09-09 at 11.05.16 PM.png
	Sep 10 2023, 6:05 AM

	F37676908: Screenshot 2023-09-08 at 4.56.04 PM.png
	Sep 8 2023, 11:56 PM

	F37676898: Screenshot 2023-09-08 at 4.52.25 PM.png
	Sep 8 2023, 11:53 PM

	F37676895: Screenshot 2023-09-08 at 4.50.36 PM.png
	Sep 8 2023, 11:53 PM

	F37748412: screenshot 72.png
	Sep 22 2023, 1:43 AM

	F37748409: screenshot 71.png
	Sep 22 2023, 1:43 AM

	F37748408: screenshot 70.png
	Sep 22 2023, 1:43 AM

[Follow up][regression] Edit icons not rendering correctly in Minerva and mediawiki.ui.icon is still loadedClosed, ResolvedPublic2 Estimated Story PointsBUG REPORTActions