Page MenuHomePhabricator
Create Task
Maniphest T342908

Minerva should use templates for all backend rendering of its icons and buttons
Closed, ResolvedPublic5 Estimated Story Points
Actions

Assigned To
Edtadros
Authored By
Jdlrobson
Jul 27 2023, 4:59 PM
Tags
Referenced Files
F37645539: Screenshot 2023-08-31 at 4.56.48 PM.png
Sep 1 2023, 12:13 AM
F37645537: Screenshot 2023-08-31 at 4.56.31 PM.png
Sep 1 2023, 12:13 AM
F37645535: Screenshot 2023-08-31 at 4.57.00 PM.png
Sep 1 2023, 12:13 AM
Subscribers
Aklapper
• alexhollender_WMF
bmartinezcalvo
bwang
Edtadros
Jdlrobson
Jdrewniak
View All 11 Subscribers

Description

Currently icons and buttons are rendered in a variety of ways, either by:

  • using a template
  • using Html::element class
  • Using raw HTML. inside a template

To make it easier to switch from mw-ui to Codex it would be preferable to switch to a more centralized approach.

Scope

  • Only backend code

TODO

  • create templates for Icons and Buttons.
  • Remove MinervaUI class
  • There should be no change in the markup before and after this change.

QA Results - Prod

ACStatusDetails
1✅T342908#9135763
2✅T342908#9143559

Details

SubjectRepoBranchLines +/-
Remove icons from about and disclaimer link and minerva-icon classmediawiki/skins/MinervaNeuemaster+9 -3
Updates edit selectormediawiki/extensions/MobileFrontendmaster+3 -3
Redo icon sizingmediawiki/skins/MinervaNeuemaster+28 -4
Prepare icon module selectors for Codex markup changemediawiki/skins/MinervaNeuemaster+8 -8
[Icons] Use Button template in PageActionsMenu.mediawiki/skins/MinervaNeuemaster+233 -112
[Icons] Use IconLegacy template in menuGroup and ToggleListItemmediawiki/skins/MinervaNeuemaster+15 -8
[Icons] Main menu, secondary actions and search icon are built via templatesmediawiki/skins/MinervaNeuemaster+73 -18
Customize query in gerrit

Related Objects
Search...

Event Timeline

Jdlrobson created this task.Jul 27 2023, 4:59 PM
Restricted Application removed a project: Patch-For-Review. · View Herald TranscriptJul 27 2023, 4:59 PM
Jdlrobson triaged this task as High priority.Jul 27 2023, 4:59 PM
Jdlrobson edited projects, added Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 3); removed Temporary accounts, Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 2).
Jdlrobson mentioned this in T319260: IP masking: Last modified bar: Minerva uses non-standard version of mw-ui-icon (Codex).
gerritbot added a comment.Jul 27 2023, 5:15 PM

Change 941026 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/MinervaNeue@master] [Icons] Main menu, secondary actions and search icon are built via templates

https://gerrit.wikimedia.org/r/941026

gerritbot added a project: Patch-For-Review.Jul 27 2023, 5:15 PM
ovasileva set the point value for this task to 5.Jul 27 2023, 5:17 PM
Jdlrobson moved this task from Incoming to Ready for Development on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 3) board.Jul 27 2023, 5:38 PM
Aklapper renamed this task from Minerva should use templates for all backend rendering of it's icons and buttons to Minerva should use templates for all backend rendering of its icons and buttons.Jul 28 2023, 1:42 PM
Jdlrobson reassigned this task from Jdlrobson to Jdrewniak.Jul 31 2023, 6:51 PM
Jdlrobson moved this task from Ready for Development to Doing on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 3) board.
gerritbot added a comment.Aug 1 2023, 11:03 AM

Change 944180 had a related patch set uploaded (by Jdrewniak; author: Jdrewniak):

[mediawiki/skins/MinervaNeue@master] [Icons] Use IconLegacy template in menuGroup and ToggleListItem

https://gerrit.wikimedia.org/r/944180

gerritbot added a comment.Aug 1 2023, 1:09 PM

Change 944219 had a related patch set uploaded (by Jdrewniak; author: Jdrewniak):

[mediawiki/skins/MinervaNeue@master] [WIP][Icons] Use Button template in PageActionsMenu.

https://gerrit.wikimedia.org/r/944219

Jdlrobson moved this task from Doing to Code Review on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 3) board.Aug 1 2023, 10:56 PM

@Jdrewniak could you please take a look at https://gerrit.wikimedia.org/r/c/mediawiki/skins/MinervaNeue/+/941026 ?

Jdlrobson mentioned this in T342907: Mobile Echo code scattered between Minerva, Echo and MobileFrontend extensions.Aug 2 2023, 12:09 AM
gerritbot added a comment.Aug 2 2023, 11:09 AM

Change 941026 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] [Icons] Main menu, secondary actions and search icon are built via templates

https://gerrit.wikimedia.org/r/941026

ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.22; 2023-08-15); removed MW-1.41-notes (1.41.0-wmf.20; 2023-08-01).Aug 2 2023, 12:00 PM
Jdlrobson moved this task from Code Review to Doing on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 3) board.Aug 3 2023, 1:24 AM
gerritbot added a comment.Aug 3 2023, 12:16 PM

Change 944180 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] [Icons] Use IconLegacy template in menuGroup and ToggleListItem

https://gerrit.wikimedia.org/r/944180

Jdlrobson claimed this task.Aug 7 2023, 5:36 PM
gerritbot added a comment.Aug 9 2023, 3:38 PM

Change 947377 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/MinervaNeue@master] Edit icon uses template parser

https://gerrit.wikimedia.org/r/947377

gerritbot added a comment.Aug 9 2023, 10:31 PM

Change 947471 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/MinervaNeue@master] Redo icon sizing

https://gerrit.wikimedia.org/r/947471

gerritbot added a comment.Aug 9 2023, 10:31 PM

Change 947473 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/MinervaNeue@master] Prepare icon module selectors for Codex markup change

https://gerrit.wikimedia.org/r/947473

gerritbot added a comment.Aug 9 2023, 10:31 PM

Change 947474 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/MinervaNeue@master] Prepare addPortletLink handler for Codex switchover

https://gerrit.wikimedia.org/r/947474

Jdlrobson moved this task from Doing to Code Review on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 3) board.Aug 9 2023, 10:35 PM
Jdlrobson added a comment.EditedAug 9 2023, 10:51 PM

I believe the above patches cover all the remaining prep work. They can be merged in any order.

The following should be relatively straight forward to review:

The following 3 are a little more risky:

EDIT: Deferred to next sprint:

Jdlrobson removed Jdlrobson as the assignee of this task.Aug 10 2023, 3:26 PM
Jdlrobson assigned this task to bwang.Aug 10 2023, 4:46 PM
Jdlrobson mentioned this in T344006: Minerva Codex migration: Add support for gadget developers with new Codex markup.Aug 10 2023, 4:59 PM
Jdlrobson mentioned this in T344007: Minerva Codex migration: section edit buttons should use Button template.
Jdlrobson added a comment.Aug 10 2023, 5:02 PM

I chatted to @bwang and we've agreed to break out two new tickets to the next sprint: T344007 T344006

gerritbot added a comment.Aug 10 2023, 7:57 PM

Change 944219 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] [Icons] Use Button template in PageActionsMenu.

https://gerrit.wikimedia.org/r/944219

gerritbot added a comment.Aug 10 2023, 9:39 PM

Change 947473 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Prepare icon module selectors for Codex markup change

https://gerrit.wikimedia.org/r/947473

gerritbot added a comment.Aug 10 2023, 11:03 PM

Change 947965 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/MobileFrontend@master] Updates edit selector

https://gerrit.wikimedia.org/r/947965

Jdlrobson added a comment.Aug 11 2023, 12:32 AM

Remaining patches are:

gerritbot added a comment.Aug 11 2023, 5:15 PM

Change 948171 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/MinervaNeue@master] Remove icons from about and disclaimer link and minerva-icon class

https://gerrit.wikimedia.org/r/948171

gerritbot added a comment.Aug 11 2023, 5:34 PM

Change 947471 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Redo icon sizing

https://gerrit.wikimedia.org/r/947471

gerritbot added a comment.Aug 11 2023, 6:06 PM

Change 947965 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontend@master] Updates edit selector

https://gerrit.wikimedia.org/r/947965

Jdlrobson mentioned this in T335440: [EPIC] Web team support for IP masking.Aug 11 2023, 6:51 PM
gerritbot added a comment.Aug 11 2023, 7:43 PM

Change 948171 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Remove icons from about and disclaimer link and minerva-icon class

https://gerrit.wikimedia.org/r/948171

Jdlrobson reassigned this task from bwang to Mhurd.Aug 11 2023, 7:45 PM
Jdlrobson moved this task from Code Review to QA on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 3) board.
Jdlrobson added a subscriber: bwang.
Mhurd added a comment.Aug 15 2023, 8:26 PM

Hey @Jdlrobson

I see this says it's scoped to only backend code. Is there anything I can do to help kick the UI / functionality tires?

Mhurd added a comment.Aug 15 2023, 9:10 PM

^ @bwang ( i hear jon's off for a bit )

Edtadros reassigned this task from Mhurd to bwang.Aug 22 2023, 1:09 PM
Edtadros added subscribers: Mhurd, Edtadros.

Hey @bwang, can you add some test steps if this is testable by QA please.

bwang removed bwang as the assignee of this task.Aug 24 2023, 6:04 PM
bwang moved this task from QA to QA in Production on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 3) board.
ovasileva assigned this task to Edtadros.Aug 31 2023, 2:19 PM
Edtadros added a comment.Sep 1 2023, 12:13 AM

Test Result - Prod

Status: ✅ PASS
Environment: enwiki
OS: macOS Ventura
Browser: Chrome
Device: MBA
Emulated Device:NA

Test Artifact(s):

QA Steps

From Gerrit - https://gerrit.wikimedia.org/r/c/mediawiki/skins/MinervaNeue/+/948171/6//COMMIT_MSG:
Remove icons from about and disclaimer link and minerva-icon class

✅ AC1: Remove icons from about and disclaimer link...

Screenshot 2023-08-31 at 4.57.00 PM.png (1×875 px, 162 KB)

❓ AC2: and minerva-icon class
I am not sure if this only applied to the two links in AC1, but at the footer of the page there are two icons that use the minerva-icon class.

Screenshot 2023-08-31 at 4.56.31 PM.png (1×870 px, 194 KB)

Screenshot 2023-08-31 at 4.56.48 PM.png (1×875 px, 199 KB)

Jdlrobson closed this task as Resolved.Sep 5 2023, 5:29 PM

This is primarily a technical change so this one can be resolved.

Edtadros updated the task description. (Show Details)Sep 6 2023, 4:39 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits