Page MenuHomePhabricator

IP masking: Last modified bar: Minerva uses non-standard version of mw-ui-icon (Codex)
Closed, ResolvedPublic5 Estimated Story Points

Description

NOTE: This ticket has been rescoped to track what actually happened as part of this ticket. Please see new tickets T342907 and T342908.

The last modified bar should be migrated from mw-ui-icon to use Codex icons with the eventual goal of converting all buttons and icons in the mobile site to Codex

TODO

  • Port last modified bar
  • Create a plan for migrating other components.

QA steps

Original ticket

NOTE: Ignore everything that follows. This captures the original scope of this ticket.
Blocked on: T340262

When ready, we should revert the change in https://gerrit.wikimedia.org/r/c/mediawiki/skins/MinervaNeue/+/837759 to bring Minerva in line with Vector's icons and buttons. This will also style the button in the IP masked mode (see current screenshot)
{F37123498}

Several consequences of this change will be:
- All touch areas of icons on mobile will reduce from 46x46 to 44x44
- On desktop the touch areas of icons will reduce to 32x32
- Margins between icons and text labels will be reduced from 8px to 6px


|Before|After
|{F35545752}|{F35545755}|
|{F35545760}|{F35545758}|


# QA

[] When the change is made we should be careful not to break the mw-ui-icon-flush classes behaviour

QA Results - Beta

ACStatusDetails
1T340789#9039700
2T340789#9039700

Event Timeline

Restricted Application added a subscriber: Masumrezarock100. · View Herald Transcript
Jdlrobson updated the task description. (Show Details)
Jdlrobson updated the task description. (Show Details)

@Jdlrobson what is the plan for restoring Minerva to what it was before this change?

I'm not sure I understand @alexhollender_WMF. There's been no change to Minerva yet. What are you seeing?

This task is about updating Minerva to use the latest icon spec. Currently it is running an outdated specification.

@Jdlrobson my understanding was that T314323 would be done in such a way that Minerva would not be affected/changed. In the task description here you describe changes to the icons in Minerva; as far as I know these are not desired/expected changes. Does that make sense?

That's correct. Minerva is not in scope for the changes in T314323. We've taken on fragile technical debt to avoid that. This task is about undoing that technical debt.

Why: We can't have different specifications for Minerva and Vector. Our current setup is that the specification is being shared between the two. To be clear the changes to Minerva proposed here are only for desktop browser. They won't apply to mobile browsers.

Note that the changes proposed in Vector also apply at desktop resolutions - note larger touch areas when you resize Vector down to mobile resolution:
https://en.wikipedia.beta.wmflabs.org/wiki/Spain?useskin=vector-2022&vectorvisualenhancementnext=1

Screen Shot 2022-10-06 at 1.03.20 PM.png (666×508 px, 116 KB)

If somethings not clear about this let's talk about it in our next 1-on-1.

Jdlrobson renamed this task from Update icons in Minerva to Minerva uses non-standard version of mw-ui-icon (Codex) for its buttons and icons.Nov 23 2022, 4:08 PM
Jdlrobson added a project: Web-Team-Backlog.
Jdlrobson set the point value for this task to 3.Jun 29 2023, 5:37 PM
LGoto changed the point value for this task from 3 to 5.Jun 29 2023, 5:38 PM
Jdlrobson renamed this task from Minerva uses non-standard version of mw-ui-icon (Codex) for its buttons and icons to IP masking: Minerva uses non-standard version of mw-ui-icon (Codex) for its buttons and icons.Jun 29 2023, 11:34 PM
Jdlrobson raised the priority of this task from Medium to High.
Jdlrobson updated the task description. (Show Details)
Jdlrobson updated the task description. (Show Details)

Change 939263 had a related patch set uploaded (by Jdrewniak; author: Jdrewniak):

[mediawiki/skins/MinervaNeue@master] Remove mediawiki.ui.icons customizations

https://gerrit.wikimedia.org/r/939263

Change 939659 had a related patch set uploaded (by Jdrewniak; author: Jdrewniak):

[mediawiki/skins/MinervaNeue@master] [WIP] Convert minerva icons to Codex icons (Part 1)

https://gerrit.wikimedia.org/r/939659

Change 940251 had a related patch set uploaded (by Jdrewniak; author: Jdrewniak):

[mediawiki/skins/MinervaNeue@master] [Icons] Convert menu icons to Codex

https://gerrit.wikimedia.org/r/940251

Change 940984 had a related patch set uploaded (by Jdlrobson; author: Bernard Wang):

[mediawiki/skins/MinervaNeue@master] [Icons] Add updated button utility classes, and update usage of MobileFrontend Icon code

https://gerrit.wikimedia.org/r/940984

Change 941026 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/MinervaNeue@master] [Icons] Main menu, secondary actions and search icon are built via templates

https://gerrit.wikimedia.org/r/941026

Change 940984 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] [Icons] Update usage of MobileFrontend Icon code

https://gerrit.wikimedia.org/r/940984

Change 941531 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/MinervaNeue@master] Migrate Echo icons to Codex.

https://gerrit.wikimedia.org/r/941531

Change 942041 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/Popups@master] Scope rule to Popups

https://gerrit.wikimedia.org/r/942041

Change 942041 merged by jenkins-bot:

[mediawiki/extensions/Popups@master] Scope rule to Popups

https://gerrit.wikimedia.org/r/942041

Jdlrobson renamed this task from IP masking: Minerva uses non-standard version of mw-ui-icon (Codex) for its buttons and icons to IP masking: Last modified bar: Minerva uses non-standard version of mw-ui-icon (Codex).Jul 29 2023, 12:16 AM
Jdlrobson reassigned this task from Jdlrobson to Edtadros.
Jdlrobson updated the task description. (Show Details)

Change 939659 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] [Icons] Convert history/next status bar icons to Codex

https://gerrit.wikimedia.org/r/939659

I've rescoped this ticket based on what actually happened and have moved it into QA.

Edtadros subscribed.

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Ventura
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

Go to a page that hasn't been recently edited e.g. https://en.m.wikipedia.beta.wmflabs.org/wiki/Conflict-title-0.45571297002697864-I%C3%B1t%C3%ABrn%C3%A2ti%C3%B4n%C3%A0liz%C3%A6ti%C3%B8n
✅ AC1: There should be a clock and arrow icon and the bar should be gray.

Screenshot 2023-07-31 at 2.39.05 PM.png (576×919 px, 64 KB)

Edit the article.
Refresh the page
✅ AC1: The bar should be green and a clock and arrow icon should be present.

Screenshot 2023-07-31 at 2.39.49 PM.png (594×922 px, 69 KB)

ovasileva claimed this task.
ovasileva subscribed.

Looks good, resolving.

Change 939263 abandoned by Jdlrobson:

[mediawiki/skins/MinervaNeue@master] Remove mediawiki.ui.icons customizations

Reason:

We should retain this for 3rd parties and other extensions still using these modules.

https://gerrit.wikimedia.org/r/939263

Change 950044 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/skins/MinervaNeue@master] Clean up setIcon now that classes and icon types are removed

https://gerrit.wikimedia.org/r/950044

Change 950043 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/skins/MinervaNeue@master] Make togglelist styles consistent, remove duplicated CSS

https://gerrit.wikimedia.org/r/950043

Change 940251 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Switch Minerva button template to use Codex and remove mw-ui-button

https://gerrit.wikimedia.org/r/940251

Change 950044 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Clean up setIcon now that classes and icon types are removed

https://gerrit.wikimedia.org/r/950044