Mobile Echo code scattered between Minerva, Echo and MobileFrontend extensions
Closed, ResolvedPublic3 Estimated Story Points
Actions

Assigned To

Authored By

	Jdlrobson
	Jul 27 2023, 4:49 PM

Description

Echo replaces the Minerva rendered button with a NotificationBadge. The purpose of this seems to purely be to allow Echo to change the badge count.

As we transition this to Codex we should clean this code up, namely:

TODO

Stop Echo replacing the NotificationBadge rendered by Minerva and instead progressively enhance it. Move logic for changing badge into Echo, using hooks if necessary

QA

On mobile site https://en.m.wikipedia.beta.wmflabs.org/ login.

When no notifications a bell icon should show in the top right on mobile
When a user has > 0 notifications a red circle with white text shows with the number inside it.
When clicking the notification icon with JS enabled, the drawer/overlay opens and the number of notifications resets to 0, remains red and white text.
When clicking the noticiation icon with JS disabled, the user navigates to Special:Notifications
Login on desktop site, change skin to Minerva Expected: Two icons show. Clicking notification icons take you to Special:Notifications.

Signoff criteria

Create ticket for preferred behavior for notification icon and state (potentially using component from vector 2022) Done in T343838

QA Results - Beta

AC	Status	Details
1	✅	T342907
2	✅	T342907
3	✅	T342907
4	✅	T342907
5	✅	T342907

Details

Subject	Repo	Branch	Lines +/-
Drop dead code	mediawiki/extensions/Echo	master	+22 -220
Fixes: Echo circle notification appears as large red square	mediawiki/skins/MinervaNeue	master	+3 -2
Disable Echo behaviour on Minerva desktop	mediawiki/extensions/Echo	master	+5 -1
Echo uses Button template	mediawiki/skins/MinervaNeue	master	+351 -129
Migrate Echo icons to Codex.	mediawiki/skins/MinervaNeue	master	+66 -19

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	Jdlrobson	T335440 [EPIC] Web team support for IP masking
Resolved	ovasileva	T319260 IP masking: Last modified bar: Minerva uses non-standard version of mw-ui-icon (Codex)
Resolved	Jdlrobson	T342907 Mobile Echo code scattered between Minerva, Echo and MobileFrontend extensions
Resolved	Jdlrobson	T343908 Page scrolls horizontally when AMC is enabled

Event Timeline

Jdlrobson created this task.Jul 27 2023, 4:49 PM

Restricted Application added a project: Growth-Team. · View Herald TranscriptJul 27 2023, 4:49 PM

Restricted Application added subscribers: Masumrezarock100, Aklapper. · View Herald Transcript

Jdlrobson triaged this task as High priority.Jul 27 2023, 4:50 PM

Jdlrobson updated the task description. (Show Details)

Change 941531 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/MinervaNeue@master] Migrate Echo icons to Codex.

https://gerrit.wikimedia.org/r/941531

gerritbot added a project: Patch-For-Review.Jul 27 2023, 4:50 PM

Jdlrobson added a parent task: T319260: IP masking: Last modified bar: Minerva uses non-standard version of mw-ui-icon (Codex).Jul 27 2023, 4:51 PM

Jdlrobson mentioned this in T319260: IP masking: Last modified bar: Minerva uses non-standard version of mw-ui-icon (Codex).Jul 27 2023, 5:01 PM

ovasileva lowered the priority of this task from High to Medium.Jul 27 2023, 5:24 PM

Jdlrobson updated the task description. (Show Details)Jul 27 2023, 5:31 PM

Discussed in standup. Next steps:

Proceed with code cleanup. Fix current issue with notification number as the link
After completion: create new ticket for preferred behavior, potentially adopting the components from Vector 2022

ovasileva updated the task description. (Show Details)Jul 27 2023, 5:32 PM

ovasileva updated the task description. (Show Details)

ovasileva set the point value for this task to 3.

ovasileva moved this task from Incoming to Ready for Development on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 3) board.Jul 31 2023, 5:56 PM

Jdlrobson claimed this task.Jul 31 2023, 6:00 PM

Jdlrobson moved this task from Ready for Development to Doing on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 3) board.

Change 943647 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/MinervaNeue@master] WIP: Echo uses Button template

https://gerrit.wikimedia.org/r/943647

Change 941531 abandoned by Jdlrobson:

[mediawiki/skins/MinervaNeue@master] Migrate Echo icons to Codex.

Reason:

Please see https://gerrit.wikimedia.org/r/c/mediawiki/skins/MinervaNeue/+/943647

https://gerrit.wikimedia.org/r/941531

Jdlrobson moved this task from Doing to Code Review on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 3) board.Aug 1 2023, 11:14 PM

Change 944352 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/Echo@master] Drop dead code

https://gerrit.wikimedia.org/r/944352

https://gerrit.wikimedia.org/r/943647 is now ready for review. Note, this switches the Echo icon temporarily back to mw-ui-button from Codex to contribute to the work in T342908. This will then switch to Codex along with all the other icons.

There is a follow up patch in Echo to remove code replaced by the code I've added in Minerva. It's not a priority to review this and we probably want to keep the patch around for at least a week to allow ourselves a safe rollback path.

@Jdrewniak would you be able to review this? https://gerrit.wikimedia.org/r/943647 is now ready for review. It moves all code into Minerva. Minor visual changes to be expected.

Jdlrobson added a comment.Aug 3 2023, 1:24 AM

This comment was removed by Jdlrobson.

bwang claimed this task.Aug 3 2023, 4:08 PM

bwang reassigned this task from bwang to Jdlrobson.Aug 4 2023, 4:24 PM

bwang moved this task from Code Review to Needs More Work on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 3) board.

bwang subscribed.

Jdlrobson moved this task from Needs More Work to Doing on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 3) board.Aug 7 2023, 5:17 PM

Jdlrobson reassigned this task from Jdlrobson to bwang.Aug 7 2023, 8:11 PM

Jdlrobson moved this task from Doing to Code Review on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 3) board.

Jdlrobson mentioned this in T343839: Echo has been disabled in Minerva desktop. due to badge replacement issue.Aug 8 2023, 5:42 PM

Change 943647 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Echo uses Button template

https://gerrit.wikimedia.org/r/943647

Change 946984 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/Echo@master] Disable Echo behaviour on Minerva desktop

https://gerrit.wikimedia.org/r/946984

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.22; 2023-08-15).Aug 8 2023, 6:00 PM

Change 946984 merged by jenkins-bot:

[mediawiki/extensions/Echo@master] Disable Echo behaviour on Minerva desktop

https://gerrit.wikimedia.org/r/946984

Jdlrobson reassigned this task from bwang to Mhurd.Aug 8 2023, 8:42 PM

Jdlrobson moved this task from Code Review to QA on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 3) board.

Jdlrobson updated the task description. (Show Details)

Caused T343908.

Change 947417 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/MinervaNeue@master] Fixes: Echo circle notification appears as large red square

https://gerrit.wikimedia.org/r/947417

Pixel flagged an issue with the Echo notification icon: https://pixel.wmcloud.org/reports/test-screenshots-echo/20230808-180728/MediaWiki_Echo_smoke_test_with_1_notifications_minerva_mobile_logged-in_echo_echo-1_0_html_0_phone.png

Fix posted above.

Jdlrobson added a subtask: T343908: Page scrolls horizontally when AMC is enabled.Aug 9 2023, 5:07 PM

Change 947417 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Fixes: Echo circle notification appears as large red square

https://gerrit.wikimedia.org/r/947417

Jdlrobson moved this task from Code Review to QA on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 3) board.Aug 9 2023, 7:09 PM

GMikesell-WMF claimed this task.Aug 9 2023, 9:08 PM

GMikesell-WMF added a subscriber: Mhurd.

Status: Pending
Environment: Beta
OS: macOS Ventura
Browser: Chrome
Device: MBP
Emulated Device:NA
Test Links:
Desktop: https://en.wikipedia.beta.wmflabs.org/wiki/Beer
Mobile: https://en.m.wikipedia.beta.wmflabs.org/wiki/Beer

✅AC1: bell icon should show in the top right on mobile.

T342907_Notifications_Mobile3.png (983×753 px, 169 KB)

❌AC2: > 0 notifications a red circle with white text shows with the number inside it.
The notification of Thanks is there but no number result popped up by the notification bell. Desktop version number pops up though.

Notification config	Desktop Status	Mobile NO Notification	Notification Result

⬜AC3: clicking the notification icon with JS enabled, the drawer/overlay opens and the number of notifications resets to 0, remains red and white text.
I can't test until I see the notification working on mobile

✅AC4: clicking the notification icon with JS disabled, the user navigates to Special: Notifications

T342907_Notifications_Mobile5.png (1×1 px, 163 KB)

GMikesell-WMF removed GMikesell-WMF as the assignee of this task.Aug 10 2023, 10:46 PM

GMikesell-WMF updated the task description. (Show Details)

GMikesell-WMF moved this task from QA to Code Review on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 3) board.

GMikesell-WMF subscribed.

Jdlrobson updated the task description. (Show Details)Aug 10 2023, 11:08 PM

Please note there is a 5th QA step (I've updated formatting to make that clearer)

@GMikesell-WMF regarding AC2 rightly or wrongly this is current behaviour in production. Nice find! I've noted it in T344029 as it doesn't seem related to this change. For now please generate a notification alert (by getting another user to edit your talk page)

Screenshot 2023-08-10 at 4.40.07 PM.png (359×1 px, 57 KB)

Jdlrobson assigned this task to GMikesell-WMF.Aug 10 2023, 11:41 PM

Jdlrobson moved this task from Code Review to QA on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 3) board.

Jdlrobson mentioned this in T344029: Echo in Minerva doesn't notify users of notices.

Status: ✅ PASS
Environment: Beta
OS: macOS Ventura
Browser: Chrome
Device: MBP
Emulated Device:NA
Test Links:
Desktop: https://en.wikipedia.beta.wmflabs.org/wiki/Beer
Mobile: https://en.m.wikipedia.beta.wmflabs.org/wiki/Beer
https://en.wikipedia.beta.wmflabs.org/wiki/Talk:Testuserone

✅AC1: bell icon should show in the top right on mobile.

✅AC2: > 0 notifications a red circle with white text shows with the number inside it.
https://en.wikipedia.beta.wmflabs.org/wiki/Talk:Testuserone

T342907_Notifications_Mobile6.png (979×762 px, 78 KB)

✅AC3: clicking the notification icon with JS enabled, the drawer/overlay opens and the number of notifications resets to 0, remains red and white text.
I can't test until I see the notification working on mobile

T342907_Notifications_Mobile7.png (983×776 px, 79 KB)

✅AC4: clicking the notification icon with JS disabled, the user navigates to Special: Notifications

✅AC5: desktop site, change skin to Minerva Expected: Two icons show. Clicking notification icons take you to Special:Notifications.

GMikesell-WMF removed GMikesell-WMF as the assignee of this task.Aug 11 2023, 4:23 AM

GMikesell-WMF updated the task description. (Show Details)

GMikesell-WMF moved this task from QA to Ready for Signoff on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 3) board.Aug 11 2023, 4:25 AM

Jdlrobson claimed this task.Aug 11 2023, 6:52 PM

QA looks good and I manually reviewed the 6 Pixel failures https://pixel.wmcloud.org/reports/echo/index.html

Jdlrobson closed subtask T343908: Page scrolls horizontally when AMC is enabled as Resolved.Aug 11 2023, 8:11 PM

Change 944352 merged by jenkins-bot: