Page MenuHomePhabricator

Echo should progressively enhance existing notification icon rather than creating its own
Open, Needs TriagePublicBUG REPORT

Description

Echo currently maintains 2 versions of the badge that users interact with:

  • The initial server side rendered version (usually rendered by skins))
  • A client side OOUI version that is rendered when the badge is clicked (replacing the existing version)

We've accumulated various technical debt over the years of skins having to maintain their own styles whenever the OOUI button is rendered

Proposed solution

Please progressively enhance the existing button rather than replacing it.

QA

  • When clicking the button a PopupWidget should be shown pointing to the existing button
  • Hooks should be used to update the notification count

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Something has changed in either Vector or Codex. I think we just need to add background-repeat: no-repeat; background-position: center somewhere.
From a quick glance I think something changed in the implementation of .vector-icon