[Regression pre-wmf.21] The Alerts and the Notices icons disappear a while after the page load
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Ryasmeen
	Sep 3 2024, 8:11 PM

Description

Steps to reproduce:

Go to any page on Beta cluster.
Wait for a while after the page load.

Observed Result:

Observe that, suddenly the Alerts and the Notices icons disappear or appear half painted.

Screenshot/Screen capture:

Screenshot 2024-09-03 at 12.55.39 PM.png (1×2 px, 326 KB)

Browser: Chrome

Wiki: en

Environment: Beta cluster

Derived Requirement

Ensure that the Alerts and Notices icons remain fully visible and do not disappear or appear half-painted after a page is loaded on the Beta cluster.

BDD

Feature: Proper Visibility of Alerts and Notices Icons

Scenario: Ensure Alerts and Notices icons remain fully visible after page load

Given the user is on any page on the Beta cluster
When the user waits for a while after the page has loaded
Then the Alerts and Notices icons should remain fully visible and not disappear or appear half-painted

Test Steps

Test Case 1: Ensure Alerts and Notices Icons Remain Fully Visible After Page Load

Navigate to any page on the Beta cluster in Chrome.
Wait for a while after the page finishes loading.
Observe the Alerts and Notices icons in the top-right of the page.
✅❓❌⬜ AC1: Confirm that the Alerts and Notices icons remain fully visible and do not disappear or appear half-painted.

QA Results - Beta

AC	Status	Details
1	✅	T373936#10130067

QA Results - PROD

AC	Status	Details
1	✅	T373936#10135584

Details

	Subject	Repo	Branch	Lines +/-
	Fixes: Echo icon not visible after click	mediawiki/skins/Vector	wmf/1.43.0-wmf.21	+11 -3
	Fixes: Echo icon not visible after click	mediawiki/skins/Vector	master	+11 -3

Customize query in gerrit

Related Objects

Mentioned In: T374038: Verify 1.43.0-wmf.21 deployment
T374180: Codex icons not loading on Vector 2022 via older versions of Chrome on Windows 7
Mentioned Here: T374180: Codex icons not loading on Vector 2022 via older versions of Chrome on Windows 7
T343838: Echo should progressively enhance existing notification icon rather than creating its own
T363920: Migrate ResourceLoader Icons in Vector to use Codex
T358160: Codex icons in Vector and Minerva are displaying incorrectly

Event Timeline

Ryasmeen created this task.Sep 3 2024, 8:11 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 3 2024, 8:11 PM

Ryasmeen renamed this task from [Regression pre-wmf.21] The Alert and Notification icon disappears a while after the page load to [Regression pre-wmf.21] The Alert and the Notices icons disappear a while after the page load.Sep 3 2024, 8:17 PM

Ryasmeen updated the task description. (Show Details)

Ryasmeen renamed this task from [Regression pre-wmf.21] The Alert and the Notices icons disappear a while after the page load to [Regression pre-wmf.21] The Alerts and the Notices icons disappear a while after the page load.Sep 3 2024, 8:24 PM

Ryasmeen updated the task description. (Show Details)

I had to click one of the icons to reproduce. Only occurs on Vector 2022 for me.

Last time something very like this happened it was because Vector had removed some important CSS rules: T358160

Indeed, it has once again touched those rules as part of T363920, so I would be suspicious of @Jdlrobson's https://gerrit.wikimedia.org/r/1038910.

matmarex unsubscribed.Sep 4 2024, 12:22 AM

Michael merged a task: T373944: [wmf.21-regression] Echo badges are partially visible .Sep 4 2024, 10:15 AM

Michael added subscribers: Etonkovidova, Urbanecm_WMF, Cyndymediawiksim and 2 others.

Jdlrobson added a project: Web-Team-Backlog (FY2024-25 Q1 Sprint 5).Sep 4 2024, 4:07 PM

Marking as UBN since this affects all logged-in users.

Jdlrobson added a parent task: T373640: 1.43.0-wmf.21 deployment blockers.Sep 4 2024, 4:57 PM

Jdlrobson moved this task from Needs analysis to Ready for Development on the Web-Team-Backlog (FY2024-25 Q1 Sprint 5) board.Sep 4 2024, 4:59 PM

Jdlrobson moved this task from Ready for Development to Doing on the Web-Team-Backlog (FY2024-25 Q1 Sprint 5) board.

This is another issue that could have been avoided by prioritizing T343838: mask-image is not compatible with the Echo OOUI icon as it uses a pseudo element to display the box with the number in the bottom right corner.

Patch incoming.

Change #1070651 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@master] Fixes: Echo icon not visible after click

https://gerrit.wikimedia.org/r/1070651

gerritbot added a project: Patch-For-Review.Sep 4 2024, 5:44 PM

Jdlrobson moved this task from Doing to Code Review on the Web-Team-Backlog (FY2024-25 Q1 Sprint 5) board.Sep 4 2024, 5:44 PM

Agusbou2015 subscribed.Sep 4 2024, 5:58 PM

SToyofuku-WMF subscribed.Sep 4 2024, 6:21 PM

Change #1070657 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@wmf/1.43.0-wmf.21] Fixes: Echo icon not visible after click

https://gerrit.wikimedia.org/r/1070657

Change #1070651 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Fixes: Echo icon not visible after click

https://gerrit.wikimedia.org/r/1070651

Change #1070657 merged by jenkins-bot:

[mediawiki/skins/Vector@wmf/1.43.0-wmf.21] Fixes: Echo icon not visible after click

https://gerrit.wikimedia.org/r/1070657

Mentioned in SAL (#wikimedia-operations) [2024-09-04T19:36:20Z] <dancy@deploy1003> Started scap sync-world: Backport for [[gerrit:1070657|Fixes: Echo icon not visible after click (T373936)]]

Mentioned in SAL (#wikimedia-operations) [2024-09-04T19:38:31Z] <dancy@deploy1003> jdlrobson, dancy: Backport for [[gerrit:1070657|Fixes: Echo icon not visible after click (T373936)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.21; 2024-09-03).Sep 4 2024, 8:00 PM

Maintenance_bot removed a project: Patch-For-Review.Sep 4 2024, 8:30 PM

https://gerrit.wikimedia.org/r/1070657 has been fully deployed.

Thanks @dancy! Confirming the fix!

Jdlrobson assigned this task to Edtadros.Sep 4 2024, 10:39 PM

Jdlrobson removed a parent task: T373640: 1.43.0-wmf.21 deployment blockers.

Jdlrobson moved this task from Code Review to QA on the Web-Team-Backlog (FY2024-25 Q1 Sprint 5) board.

I use Chrome (Windows 10, desktop) with Auto Dark Mode for Web Contents which inverts colors. Until Sep 5 the icons were inverted and appeared in white and gray. Now they are not inverted and they are not visible. All user menu icons became invisible. Could you fix this, please? Vector-2022 skin, Wikipedia

In T373936#10124604, @Bean49 wrote:

I use Chrome (Windows 10, desktop) with Auto Dark Mode for Web Contents which inverts colors. Until Sep 5 the icons were inverted and appeared in white and gray. Now they are not inverted and they are not visible. All user menu icons became invisible. Could you fix this, please? Vector-2022 skin, Wikipedia

This is being tracked in T374180 and is already fixed, just pending a deployment.

@Bean49 Chrome 128 (latest so far)? And which version of Windows 10 if not version 22H2, the latest and final version of Windows 10?

gh87 mentioned this in T374180: Codex icons not loading on Vector 2022 via older versions of Chrome on Windows 7.Sep 7 2024, 8:45 AM

Thank you for your attention. Chrome 128.0.6613.120 (64 bit), Windows 10 Enterprise 22H2 build 19045.4780

GMikesell-WMF claimed this task.Sep 9 2024, 12:36 PM

GMikesell-WMF updated Other Assignee, added: Edtadros.

GMikesell-WMF updated the task description. (Show Details)

GMikesell-WMF added a subscriber: Edtadros.

Status: ✅ PASS
Environment: Beta
OS: macOS Sonoma 14.6.1
Browser: Chrome 128
Device: MBA
Emulated Device: NA

Test Artifact(s):

Test Steps

Test Case 1: Ensure Alerts and Notices Icons Remain Fully Visible After Page Load

Navigate to any page on the Beta cluster in Chrome.
Wait for a while after the page finishes loading.
Observe the Alerts and Notices icons in the top-right of the page.
✅ AC1: Confirm that the Alerts and Notices icons remain fully visible and do not disappear or appear half-painted.

No Throttle	2G	Dark

GMikesell-WMF removed GMikesell-WMF as the assignee of this task.Sep 9 2024, 2:16 PM

GMikesell-WMF updated Other Assignee, removed: Edtadros.

GMikesell-WMF updated the task description. (Show Details)

GMikesell-WMF moved this task from QA to Ready for Signoff on the Web-Team-Backlog (FY2024-25 Q1 Sprint 5) board.

GMikesell-WMF subscribed.

Edtadros mentioned this in T374038: Verify 1.43.0-wmf.21 deployment.Sep 9 2024, 5:28 PM

Jdlrobson claimed this task.Sep 9 2024, 5:29 PM

Jdlrobson closed this task as Resolved.Sep 9 2024, 11:23 PM

Status: ✅ PASS
Environment: PROD
OS: macOS Sonoma 14.6.1
Browser: Chrome 128
Device: MBA
Emulated Device: NA

Test Artifact(s):

Test Steps

Test Case 1: Ensure Alerts and Notices Icons Remain Fully Visible After Page Load

Navigate to any page on the Beta cluster in Chrome.
Wait for a while after the page finishes loading.
Observe the Alerts and Notices icons in the top-right of the page.
✅ AC1: Confirm that the Alerts and Notices icons remain fully visible and do not disappear or appear half-painted.

No Throttle	2G	Dark

GMikesell-WMF added a project: Verified.Sep 10 2024, 7:35 PM

GMikesell-WMF updated the task description. (Show Details)

	F57436418: Screenshot 2024-09-03 at 12.55.39 PM.png
	Sep 3 2024, 8:11 PM

[Regression pre-wmf.21] The Alerts and the Notices icons disappear a while after the page loadClosed, ResolvedPublicActions

Description

Derived Requirement

BDD

Test Steps

QA Results - Beta

QA Results - PROD

Details

Related Objects

Event Timeline

Test Steps

Test Steps

[Regression pre-wmf.21] The Alerts and the Notices icons disappear a while after the page load
Closed, ResolvedPublic
Actions