Page MenuHomePhabricator
Create Task
Maniphest T373640

1.43.0-wmf.21 deployment blockers
Closed, ResolvedPublic5 Estimated Story PointsRelease
Actions

Details

Backup Train Conductor
hashar
Release Version
1.43.0-wmf.21
Release Date
Sep 2 2024, 12:00 AM

2024 week 36 1.43-wmf.21 Changes wmf/1.43.0-wmf.21

This MediaWiki Train Deployment is scheduled for the week of Monday, September 2nd:

Monday September 2ndTuesday, September 3rdWednesday, September 4thThursday, September 5thFriday
Backports only.Branch wmf.21 and deploy to Group 0 Wikis.Deploy wmf.21 to Group 1 Wikis.Deploy wmf.21 to all Wikis.No deployments on fridays

How this works

  • Any serious bugs affecting wmf.21 should be added as subtasks beneath this one.
  • Any open subtask(s) block the train from moving forward. This means no further deployments until the blockers are resolved.
  • If something is serious enough to warrant a rollback then you should bring it to the attention of deployers on the #wikimedia-operations IRC channel.
  • If you have a risky change in this week's train add a comment to this task using the Risky patch template
  • For more info about deployment blockers, see Holding the train.

Related Links

Other Deployments

Previous: 1.43.0-wmf.20
Next: 1.43.0-wmf.22
SubjectRepoBranchLines +/-
group2 to 1.43.0-wmf.21operations/mediawiki-configmaster+339 -339
group1 to 1.43.0-wmf.21operations/mediawiki-configmaster+558 -558
group0 to 1.43.0-wmf.21operations/mediawiki-configmaster+132 -132
testwikis to 1.43.0-wmf.21operations/mediawiki-configmaster+132 -132
group0 to 1.43.0-wmf.21operations/mediawiki-configmaster+132 -132
testwikis to 1.43.0-wmf.21operations/mediawiki-configmaster+132 -132
group0 to 1.43.0-wmf.21operations/mediawiki-configmaster+132 -132
testwikis to 1.43.0-wmf.21operations/mediawiki-configmaster+3 -3
Branch commit for wmf/1.43.0-wmf.21mediawiki/corewmf/1.43.0-wmf.21+1 K -3
Customize query in gerrit

Related Objects
Search...

Event Timeline

thcipriani created this task.Aug 29 2024, 9:25 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 29 2024, 9:25 PM
thcipriani assigned this task to dancy.Aug 29 2024, 9:27 PM
thcipriani triaged this task as Medium priority.
thcipriani updated Other Assignee, added: hashar.
thcipriani set the point value for this task to 5.
thcipriani added a project: Release-Engineering-Team (Priority Backlog 📥).
hashar subscribed.Aug 30 2024, 7:12 AM
DLynch added a subtask: T373661: "Cannot read properties of null (reading 'keyedNodes')" opening Basic citation in 2017 Source Editor.Aug 30 2024, 2:20 PM
gerritbot added a comment.Sep 3 2024, 7:25 AM

Change #1070141 had a related patch set uploaded (by TrainBranchBot; author: trainbranchbot):

[mediawiki/core@wmf/1.43.0-wmf.21] Branch commit for wmf/1.43.0-wmf.21

https://gerrit.wikimedia.org/r/1070141

gerritbot added a project: Patch-For-Review.Sep 3 2024, 7:25 AM
gerritbot added a comment.Sep 3 2024, 7:54 AM

Change #1070141 merged by jenkins-bot:

[mediawiki/core@wmf/1.43.0-wmf.21] Branch commit for wmf/1.43.0-wmf.21

https://gerrit.wikimedia.org/r/1070141

gerritbot added a comment.Sep 3 2024, 8:09 AM

Change #1070200 had a related patch set uploaded (by TrainBranchBot; author: Jaime Nuche):

[operations/mediawiki-config@master] testwikis to 1.43.0-wmf.21

https://gerrit.wikimedia.org/r/1070200

gerritbot added a comment.Sep 3 2024, 8:10 AM

Change #1070200 merged by jenkins-bot:

[operations/mediawiki-config@master] testwikis to 1.43.0-wmf.21

https://gerrit.wikimedia.org/r/1070200

Stashbot added a comment.Sep 3 2024, 8:10 AM

Mentioned in SAL (#wikimedia-operations) [2024-09-03T08:10:42Z] <jnuche@deploy1003> Started scap sync-world: testwikis to 1.43.0-wmf.21 refs T373640

Maintenance_bot removed a project: Patch-For-Review.Sep 3 2024, 8:30 AM
Stashbot added a comment.Sep 3 2024, 8:56 AM

Mentioned in SAL (#wikimedia-operations) [2024-09-03T08:56:25Z] <jnuche@deploy1003> Finished scap sync-world: testwikis to 1.43.0-wmf.21 refs T373640 (duration: 45m 42s)

dancy removed a subtask: T373661: "Cannot read properties of null (reading 'keyedNodes')" opening Basic citation in 2017 Source Editor.Sep 3 2024, 3:58 PM
gerritbot added a comment.Sep 3 2024, 6:01 PM

Change #1070306 had a related patch set uploaded (by TrainBranchBot; author: Ahmon Dancy):

[operations/mediawiki-config@master] group0 to 1.43.0-wmf.21

https://gerrit.wikimedia.org/r/1070306

gerritbot added a project: Patch-For-Review.Sep 3 2024, 6:01 PM

Change #1070306 merged by jenkins-bot:

[operations/mediawiki-config@master] group0 to 1.43.0-wmf.21

https://gerrit.wikimedia.org/r/1070306

Stashbot added a comment.Sep 3 2024, 6:13 PM

Mentioned in SAL (#wikimedia-operations) [2024-09-03T18:13:43Z] <dancy@deploy1003> rebuilt and synchronized wikiversions files: group0 to 1.43.0-wmf.21 refs T373640

dancy added a subtask: T373086: PHP Warning: Stats: Cannot associate label keys with label values: Not all initialized labels have an assigned value..Sep 3 2024, 6:15 PM
dancy added a subtask: T373920: TypeError: MediaWiki\Parser\ParserOutput::setNumericPageProperty with non-numeric value.Sep 3 2024, 6:22 PM
Maintenance_bot removed a project: Patch-For-Review.Sep 3 2024, 6:30 PM
Jdforrester-WMF added a subtask: T373921: Error: Typed property MediaWiki\Extension\Translate\TranslatorInterface\Aid\TTMServerAid::$services must not be accessed before initialization.Sep 3 2024, 6:45 PM
gerritbot added a comment.Sep 3 2024, 6:57 PM

Change #1070315 had a related patch set uploaded (by TrainBranchBot; author: Ahmon Dancy):

[operations/mediawiki-config@master] testwikis to 1.43.0-wmf.21

https://gerrit.wikimedia.org/r/1070315

gerritbot added a project: Patch-For-Review.Sep 3 2024, 6:57 PM

Change #1070315 merged by jenkins-bot:

[operations/mediawiki-config@master] testwikis to 1.43.0-wmf.21

https://gerrit.wikimedia.org/r/1070315

Stashbot added a comment.Sep 3 2024, 6:58 PM

Mentioned in SAL (#wikimedia-operations) [2024-09-03T18:58:07Z] <dancy@deploy1003> Started scap sync-world: testwikis to 1.43.0-wmf.21 refs T373640

Stashbot added a comment.Sep 3 2024, 7:06 PM

Mentioned in SAL (#wikimedia-operations) [2024-09-03T19:06:19Z] <dancy@deploy1003> Finished scap sync-world: testwikis to 1.43.0-wmf.21 refs T373640 (duration: 08m 11s)

Maintenance_bot removed a project: Patch-For-Review.Sep 3 2024, 7:31 PM
Aklapper mentioned this in T373925: Cross-wiki API does not work any more.Sep 4 2024, 7:50 AM
dcausse closed subtask T373086: PHP Warning: Stats: Cannot associate label keys with label values: Not all initialized labels have an assigned value. as Resolved.Sep 4 2024, 9:10 AM
hashar closed subtask T373921: Error: Typed property MediaWiki\Extension\Translate\TranslatorInterface\Aid\TTMServerAid::$services must not be accessed before initialization as Resolved.Sep 4 2024, 9:30 AM
matmarex added a subtask: T373925: Cross-wiki API does not work any more.Sep 4 2024, 12:40 PM
IKhitron subscribed.Sep 4 2024, 12:42 PM
hashar added a comment.Sep 4 2024, 3:08 PM

@dancy I ran a couple backports:

  • T373921 was confirmed to be verified since we had a repro url on test.wikidata.org which runs this week 1.43.0-wmf.21
  • T373920 I have completed the deploy, but that needs real traffic to confirm the resolution

That leaves T373925 as the last blocker.

dancy added a comment.Sep 4 2024, 3:53 PM
In T373640#10117851, @hashar wrote:

@dancy I ran a couple backports:

  • T373921 was confirmed to be verified since we had a repro url on test.wikidata.org which runs this week 1.43.0-wmf.21
  • T373920 I have completed the deploy, but that needs real traffic to confirm the resolution

That leaves T373925 as the last blocker.

Thank you @hashar!

matmarex closed subtask T373925: Cross-wiki API does not work any more as Resolved.Sep 4 2024, 4:54 PM
Jdlrobson added a subtask: T373936: [Regression pre-wmf.21] The Alerts and the Notices icons disappear a while after the page load.Sep 4 2024, 4:57 PM
Jdlrobson mentioned this in T374038: Verify 1.43.0-wmf.21 deployment.
gerritbot added a comment.Sep 4 2024, 5:07 PM

Change #1070647 had a related patch set uploaded (by TrainBranchBot; author: Ahmon Dancy):

[operations/mediawiki-config@master] group0 to 1.43.0-wmf.21

https://gerrit.wikimedia.org/r/1070647

gerritbot added a project: Patch-For-Review.Sep 4 2024, 5:07 PM

Change #1070647 merged by jenkins-bot:

[operations/mediawiki-config@master] group0 to 1.43.0-wmf.21

https://gerrit.wikimedia.org/r/1070647

Stashbot added a comment.Sep 4 2024, 5:16 PM

Mentioned in SAL (#wikimedia-operations) [2024-09-04T17:16:51Z] <dancy@deploy1003> rebuilt and synchronized wikiversions files: group0 to 1.43.0-wmf.21 refs T373640

Maintenance_bot removed a project: Patch-For-Review.Sep 4 2024, 5:30 PM
dancy added a subtask: T374046: PHP Warning: MediaWiki\Parser\ParserOutput::collectMetadata: bad type for 'translate-is-translation', set '1' (T373920) [Called from MediaWiki\Parser\ParserOutput::collectMetadata in /srv/mediawiki/php-1.43.0-wmf.21/includes/pa.Sep 4 2024, 5:47 PM
gerritbot added a comment.Sep 4 2024, 5:51 PM

Change #1070652 had a related patch set uploaded (by TrainBranchBot; author: Ahmon Dancy):

[operations/mediawiki-config@master] testwikis to 1.43.0-wmf.21

https://gerrit.wikimedia.org/r/1070652

gerritbot added a project: Patch-For-Review.Sep 4 2024, 5:51 PM
dancy added a comment.Sep 4 2024, 5:51 PM

Rolled the train back due to T374046

gerritbot added a comment.Sep 4 2024, 5:52 PM

Change #1070652 merged by jenkins-bot:

[operations/mediawiki-config@master] testwikis to 1.43.0-wmf.21

https://gerrit.wikimedia.org/r/1070652

Stashbot added a comment.Sep 4 2024, 5:52 PM

Mentioned in SAL (#wikimedia-operations) [2024-09-04T17:52:24Z] <dancy@deploy1003> Started scap sync-world: testwikis to 1.43.0-wmf.21 refs T373640

Stashbot added a comment.Sep 4 2024, 5:59 PM

Mentioned in SAL (#wikimedia-operations) [2024-09-04T17:59:13Z] <dancy@deploy1003> Finished scap sync-world: testwikis to 1.43.0-wmf.21 refs T373640 (duration: 06m 48s)

Maintenance_bot removed a project: Patch-For-Review.Sep 4 2024, 6:30 PM
cscott subscribed.Sep 4 2024, 7:32 PM

T374046 should be resolved with https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1070548 (cherry picked this morning) and https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1070663 (scheduled for a cherry pick in 30min but could be done sooner). https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1070660 is a "more correct" fix but only affects Parsoid and so doesn't need to be cherry picked, it can safely ride the wmf.22 train next week.

gerritbot added a comment.Sep 4 2024, 8:56 PM

Change #1070669 had a related patch set uploaded (by TrainBranchBot; author: Ahmon Dancy):

[operations/mediawiki-config@master] group0 to 1.43.0-wmf.21

https://gerrit.wikimedia.org/r/1070669

gerritbot added a project: Patch-For-Review.Sep 4 2024, 8:56 PM

Change #1070669 merged by jenkins-bot:

[operations/mediawiki-config@master] group0 to 1.43.0-wmf.21

https://gerrit.wikimedia.org/r/1070669

Stashbot added a comment.Sep 4 2024, 9:03 PM

Mentioned in SAL (#wikimedia-operations) [2024-09-04T21:03:35Z] <dancy@deploy1003> rebuilt and synchronized wikiversions files: group0 to 1.43.0-wmf.21 refs T373640

dancy added a comment.Sep 4 2024, 9:22 PM

The target for today was to reach group1, but we only made it to group0 this afternoon. Error logs look ok right now but I want to let it marinate for a while. @hashar If you can, please roll the train to group1 during the next window. Thanks in advance!

Maintenance_bot removed a project: Patch-For-Review.Sep 4 2024, 9:31 PM
Jdlrobson removed a subtask: T373936: [Regression pre-wmf.21] The Alerts and the Notices icons disappear a while after the page load.Sep 4 2024, 10:39 PM
gerritbot added a comment.Sep 5 2024, 4:30 PM

Change #1070991 had a related patch set uploaded (by TrainBranchBot; author: Ahmon Dancy):

[operations/mediawiki-config@master] group1 to 1.43.0-wmf.21

https://gerrit.wikimedia.org/r/1070991

gerritbot added a project: Patch-For-Review.Sep 5 2024, 4:30 PM

Change #1070991 merged by jenkins-bot:

[operations/mediawiki-config@master] group1 to 1.43.0-wmf.21

https://gerrit.wikimedia.org/r/1070991

Maintenance_bot removed a project: Patch-For-Review.Sep 5 2024, 4:30 PM
Stashbot added a comment.Sep 5 2024, 4:38 PM

Mentioned in SAL (#wikimedia-operations) [2024-09-05T16:38:13Z] <dancy@deploy1003> rebuilt and synchronized wikiversions files: group1 to 1.43.0-wmf.21 refs T373640

colewhite subscribed.Sep 5 2024, 5:18 PM

Something in the latest deploy mutates agent: "" to agent: false in logs. This has broken logstash user agent parsing for api-feature-usage.

Agusbou2015 subscribed.Sep 5 2024, 5:56 PM
gerritbot added a comment.Sep 5 2024, 6:23 PM

Change #1071015 had a related patch set uploaded (by TrainBranchBot; author: Ahmon Dancy):

[operations/mediawiki-config@master] group2 to 1.43.0-wmf.21

https://gerrit.wikimedia.org/r/1071015

gerritbot added a project: Patch-For-Review.Sep 5 2024, 6:23 PM

Change #1071015 merged by jenkins-bot:

[operations/mediawiki-config@master] group2 to 1.43.0-wmf.21

https://gerrit.wikimedia.org/r/1071015

Maintenance_bot removed a project: Patch-For-Review.Sep 5 2024, 6:31 PM
Stashbot added a comment.Sep 5 2024, 6:37 PM

Mentioned in SAL (#wikimedia-operations) [2024-09-05T18:37:11Z] <dancy@deploy1003> rebuilt and synchronized wikiversions files: group2 to 1.43.0-wmf.21 refs T373640

Dreamy_Jazz added a subtask: T374210: Error connecting to db1237 as user wikiadmin2023: :real_connect(): (HY000/2002): Connection timed out on labswiki.Sep 6 2024, 10:05 AM
Dreamy_Jazz removed a subtask: T374210: Error connecting to db1237 as user wikiadmin2023: :real_connect(): (HY000/2002): Connection timed out on labswiki.Sep 6 2024, 1:39 PM
thcipriani removed a subtask: T374046: PHP Warning: MediaWiki\Parser\ParserOutput::collectMetadata: bad type for 'translate-is-translation', set '1' (T373920) [Called from MediaWiki\Parser\ParserOutput::collectMetadata in /srv/mediawiki/php-1.43.0-wmf.21/includes/pa.Sep 6 2024, 4:37 PM
thcipriani removed a subtask: T373920: TypeError: MediaWiki\Parser\ParserOutput::setNumericPageProperty with non-numeric value.
thcipriani closed this task as Resolved.Sep 6 2024, 4:50 PM

Live everywhere: https://versions.toolforge.org/

Optimistically, calling this week done.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits