"Cannot read properties of null (reading 'keyedNodes')" opening Basic citation in 2017 Source Editor
Closed, ResolvedPublicBUG REPORT
Actions

Description

What is the problem?

Trying to add a reference on beta in the 2017 Source Editor, it fails and I see the JavaScript exception:

Chrome:

Uncaught TypeError: Cannot read properties of null (reading 'keyedNodes')
    at ve.dm.MWGroupReferences.getRefUsages (ve.dm.MWGroupReferences.js:198:26)
    at ve.ui.MWReferenceEditPanel.updateReuseWarningFromRef (ve.ui.MWReferenceEditPanel.js:251:4)
    at ve.ui.MWReferenceEditPanel.setReferenceForEditing (ve.ui.MWReferenceEditPanel.js:214:7)
    at eval (ve.ui.MWReferenceDialog.js:223:19)
    at eval (oojs-ui-windows.js:756:33)
    at mightThrow (jquery.js:3489:29)
    at process (jquery.js:3557:12)

Firefox:

Uncaught TypeError: this.nodeGroup is null
    getRefUsages https://ar.wikipedia.beta.wmflabs.org/w/load.php?lang=en&modules=ext.cite.visualEditor.core&skin=vector-2022&version=s6bai:5
    updateReuseWarningFromRef https://ar.wikipedia.beta.wmflabs.org/w/load.php?lang=en&modules=ext.cite.visualEditor&skin=vector-2022&version=1fxgb:33
    setReferenceForEditing https://ar.wikipedia.beta.wmflabs.org/w/load.php?lang=en&modules=ext.cite.visualEditor&skin=vector-2022&version=1fxgb:32
    getSetupProcess https://ar.wikipedia.beta.wmflabs.org/w/load.php?lang=en&modules=ext.cite.visualEditor&skin=vector-2022&version=1fxgb:24
    proceed https://ar.wikipedia.beta.wmflabs.org/w/load.php?lang=en&modules=oojs-ui-windows&skin=vector-2022&version=53oow:6
    jQuery 51
load.php:5:716

This only seems to happen in the case where Cite is a dropdown with two options, not when Cite is a single button.

I have checked that the Basic cite does work in the visual VisualEditor.

Steps to reproduce problem

Login to https://cs.wikipedia.beta.wmflabs.org
Enable the 2017 Source Editor:
1. https://cs.wikipedia.beta.wmflabs.org/wiki/Speci%C3%A1ln%C3%AD:Nastaven%C3%AD?uselang=en#mw-prefsection-editing
2. Check Use the wikitext mode inside the visual editor... and submit
https://cs.wikipedia.beta.wmflabs.org/w/index.php?title=Wikimedia_%C4%8Cesk%C3%A1_republika&veaction=editsource
Open the developer toolbar so you see the JS error
Open the Citace (Cite) dropdown and click Základní (Basic)

Expected behaviour: Cite popup appears.
Observed behaviour: JavaScript error.

Environment

Browser: Firefox 115, Chromium 120.
Wiki(s): MediaWiki 1.43.0-alpha (d23abdc) 09:01, 30 August 2024.

Editor: VisualEditor – (dedd30b) 09:20, 30 August 2024.

Screenshots

Details

	Subject	Repo	Branch	Lines +/-
	Finish safety fallback for missing groups	mediawiki/extensions/Cite	master	+7 -3
	Fix null reference error in 2017 source editor	mediawiki/extensions/Cite	master	+2 -1

Customize query in gerrit

Related Objects

Mentioned In: T373787: [Tests] Write a basic e2e test for Cite WT2017 integration
Mentioned Here: rECIT6e03d2cafa67: Moving ref group knowledge into a dedicated data structure
T372871: Continue to render subrefs in VE as such when parent is (temporarily) missing
rMWd23abdc88db2: Localisation updates from https://translatewiki.net.
rEVEDdedd30bfef2b: Localisation updates from https://translatewiki.net.

Event Timeline

dom_walden created this task.Aug 30 2024, 8:23 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 30 2024, 8:23 AM

dom_walden renamed this task from "Cannot read properties of null (reading 'keyedNodes')" opening Basic citation to "Cannot read properties of null (reading 'keyedNodes')" opening Basic citation in 2017 Source Editor.Aug 30 2024, 8:29 AM

dom_walden updated the task description. (Show Details)

dom_walden updated the task description. (Show Details)Aug 30 2024, 8:31 AM

Caused by 6e03d2cafa67ede47df133f5023515b1aa4fcddd (or some of the follow-on work from it) on T372871.

DLynch added a parent task: T373640: 1.43.0-wmf.21 deployment blockers.Aug 30 2024, 2:20 PM

Change #1069236 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Cite@master] Fix null reference error in 2017 source editor

https://gerrit.wikimedia.org/r/1069236

gerritbot added a project: Patch-For-Review.Aug 30 2024, 3:43 PM

thiemowmde claimed this task.Aug 30 2024, 3:44 PM

thiemowmde moved this task from Incoming to In progress on the WMDE-References-FocusArea board.

thiemowmde added a project: WMDE-TechWish-Sprint-2024-08-21.

thiemowmde moved this task from Sprint Backlog to Tech Review on the WMDE-TechWish-Sprint-2024-08-21 board.

thiemowmde added subscribers: WMDE-Fisch, awight, thiemowmde.

WMDE-Fisch mentioned this in T373787: [Tests] Write a basic e2e test for Cite WT2017 integration.Sep 2 2024, 9:08 AM

Change #1069236 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Fix null reference error in 2017 source editor

https://gerrit.wikimedia.org/r/1069236

Maintenance_bot removed a project: Patch-For-Review.Sep 2 2024, 9:30 AM

WMDE-Fisch moved this task from Tech Review to Done on the WMDE-TechWish-Sprint-2024-08-21 board.Sep 2 2024, 9:31 AM

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.21; 2024-09-03).Sep 2 2024, 10:00 AM

WMDE-Fisch moved this task from In progress to Done on the WMDE-References-FocusArea board.Sep 3 2024, 9:43 AM

Change #1070232 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/extensions/Cite@master] Finish safety fallback for missing groups

https://gerrit.wikimedia.org/r/1070232

gerritbot added a project: Patch-For-Review.Sep 3 2024, 11:39 AM

One small breadcrumb about this weird bug: the difference between the 2017 (VE) source editor and visual editing seems to be that it doesn't add a placeholder reference node to the empty document fragment before opening the dialog, so no default reference group gets implicitly created.

Change #1070232 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Finish safety fallback for missing groups

https://gerrit.wikimedia.org/r/1070232

ReleaseTaggerBot edited projects, added MW-1.43-notes (1.43.0-wmf.22; 2024-09-10); removed MW-1.43-notes (1.43.0-wmf.21; 2024-09-03).Sep 3 2024, 1:00 PM

Maintenance_bot removed a project: Patch-For-Review.Sep 3 2024, 1:30 PM

Will someone be backporting https://gerrit.wikimedia.org/r/1070232 to wmf/1.43.0-wmf.21 ?

https://gerrit.wikimedia.org/r/1070232 is essentially just ongoing code cleanup. We are not aware of a way a user could trigger an error in the spots touched by https://gerrit.wikimedia.org/r/1070232. Therefor we don't think this needs backporting.

Thanks @thiemowmde. So this issue is no longer a train blocker?

To my knowledge, no, this is not a blocker any more. https://gerrit.wikimedia.org/r/1069236 fixed it before the branch cut.

dancy removed a parent task: T373640: 1.43.0-wmf.21 deployment blockers.Sep 3 2024, 3:58 PM

WMDE-Fisch closed this task as Resolved.Sep 27 2024, 6:34 AM

WMDE-Fisch removed thiemowmde as the assignee of this task.

	F57354352: ve_cite_basic.png
	Aug 30 2024, 8:23 AM

"Cannot read properties of null (reading 'keyedNodes')" opening Basic citation in 2017 Source EditorClosed, ResolvedPublicBUG REPORTActions