Clicking Echo icon breaks Echo notification icon display
Closed, ResolvedPublic1 Estimated Story PointsBUG REPORT
Actions

Assigned To

Authored By

	Jdlrobson
	May 20 2024, 11:45 PM

Description

This regression has happened several times (see notes). We really should prioritize addressing the technical debt (see more information)

Steps to replicate the issue (include links if applicable):

Go to https://en.wikipedia.beta.wmflabs.org/w/index.php?title=T352930
Click one of the notification icons

What happens?:

Screenshot 2024-05-20 at 4.41.56 PM.png (310×592 px, 44 KB)

Display becomes garbled.

What should have happened instead?:
No repeating icons.

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):
The Echo notification icon is very fragile and a more long term solution is described in https://phabricator.wikimedia.org/T343838

Requirement

Ensure that clicking the Echo notification icon does not break the Echo notification icon display.

BDD

gherkin
Feature: Echo Notification Icon Display

  Scenario: Ensure Echo notification icon display is correct when clicked
    Given the user is on a page with the Echo notification icon
    When the user clicks the Echo notification icon
    Then the Echo notification icon display should not break

Test Steps

Test Case 1: Ensure Echo Notification Icon Display is Correct When Clicked

Go to this page.
Click one of the notification icons.
AC1: Confirm that the Echo notification icon display does not break.

QA Results - Beta

AC	Status	Details
1	✅	T365409#9840560

QA Results - PROD

AC	Status	Details
1	✅	T365409#9857401

Details

	Subject	Repo	Branch	Lines +/-
	Fixes: Echo icon display when clicked	mediawiki/skins/Vector	master	+2 -0

Customize query in gerrit

Related Objects

Mentioned In: T365384: Verify 1.43.0-wmf.7 deployment
Mentioned Here: T356540: Make CSS-only icons compatible with CSS variables
T343838: Echo should progressively enhance existing notification icon rather than creating its own

Event Timeline

Jdlrobson created this task.May 20 2024, 11:45 PM

Restricted Application added a project: Growth-Team. · View Herald TranscriptMay 20 2024, 11:45 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Jdlrobson triaged this task as Unbreak Now! priority.May 20 2024, 11:45 PM

Jdlrobson added a parent task: T361400: 1.43.0-wmf.6 deployment blockers.

SToyofuku-WMF subscribed.May 20 2024, 11:50 PM

Jdlrobson added a project: Web-Team-Backlog (FY2023-24 Q4 Sprint 4).May 20 2024, 11:52 PM

This is a deploy blocker - as it's highly visible to editors, and they will complain :)

Change #1034200 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@master] Fixes: Echo icon display when clicked

https://gerrit.wikimedia.org/r/1034200

gerritbot added a project: Patch-For-Review.May 21 2024, 12:16 AM

Okay I've tracked this down to https://gerrit.wikimedia.org/r/c/mediawiki/skins/Vector/+/1028371 which removed some styles for T356540 which were apparently also used here.
Reverting that patch seemed riskier to me (and would leave an unclear commented piece of code which could lead to a repeat version of this happening again), so I restored the styles in the skinStyle stylesheet for Echo ^ I would appreciate a review ASAP to unblock the train!