Page MenuHomePhabricator
Create Task
Maniphest T340789

IP masking: Use temporary icon in Vector and Minerva skins
Closed, ResolvedPublic1 Estimated Story Points
Actions

Assigned To
ovasileva
Authored By
Jdlrobson
Jun 29 2023, 8:31 PM
Tags
Referenced Files
F37148828: Screenshot 2023-07-24 at 4.59.17 PM.png
Jul 25 2023, 12:02 AM
F37148826: Screenshot 2023-07-24 at 4.58.31 PM.png
Jul 25 2023, 12:02 AM
F37001060: image.png
Jul 25 2023, 12:02 AM
File Not Attached
F37123398: Screenshot 2023-06-29 at 1.30.21 PM.png
Jun 29 2023, 8:31 PM
Subscribers
Aklapper
Edtadros
Jdlrobson
Masumrezarock100

Description

The Vector and Minerva skins need updating to use the correct IP masked icon (added in T338165). We should update it.

Screenshot 2023-06-29 at 1.30.21 PM.png (145×1 px, 27 KB)

TODO

https://phabricator.wikimedia.org/T340789#9039700

QA Results - Beta

ACStatusDetails
1✅T340789#9039700
2✅T340789#9039700

Details

SubjectRepoBranchLines +/-
Add temporary user iconmediawiki/skins/MinervaNeuemaster+1 -1
Remove anonymous user iconmediawiki/skins/Vectormaster+0 -1
Display temporary user iconmediawiki/coremaster+1 -1
Add temporary user iconmediawiki/skins/Vectormaster+1 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

Jdlrobson created this task.Jun 29 2023, 8:31 PM
Restricted Application added subscribers: Masumrezarock100, Aklapper. · View Herald TranscriptJun 29 2023, 8:31 PM
Jdlrobson triaged this task as Medium priority.Jun 29 2023, 8:31 PM
Jdlrobson mentioned this in T338165: IP Masking: Create the OOUI version of the temporary account icon.
Jdlrobson updated the task description. (Show Details)
LGoto set the point value for this task to 1.Jul 6 2023, 5:34 PM
Jdlrobson moved this task from Incoming to For Iteration on the Desktop Improvements (Vector 2022) board.Jul 7 2023, 10:05 PM
ovasileva added a parent task: T335440: [EPIC] Web team support for IP masking.Jul 11 2023, 5:26 PM
ovasileva moved this task from Incoming to Ready for Development on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 2) board.Jul 17 2023, 5:31 PM
Jdlrobson moved this task from Backlog to TODO on the MinervaNeue board.Jul 19 2023, 4:48 PM
Jdlrobson moved this task from Ready for Development to Doing on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 2) board.Jul 20 2023, 6:26 PM
gerritbot added a comment.Jul 20 2023, 6:30 PM

Change 940235 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@master] Add temporary user icon

https://gerrit.wikimedia.org/r/940235

gerritbot added a project: Patch-For-Review.Jul 20 2023, 6:30 PM

Change 940237 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/core@master] Display temporary user icon

https://gerrit.wikimedia.org/r/940237

gerritbot added a comment.Jul 20 2023, 6:32 PM

Change 940236 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/MinervaNeue@master] Add temporary user icon

https://gerrit.wikimedia.org/r/940236

Jdlrobson moved this task from Doing to Code Review on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 2) board.Jul 20 2023, 6:33 PM
gerritbot added a comment.Jul 20 2023, 10:58 PM

Change 940235 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Add temporary user icon

https://gerrit.wikimedia.org/r/940235

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.19; 2023-07-25).Jul 20 2023, 11:00 PM
gerritbot added a comment.Jul 20 2023, 11:08 PM

Change 940263 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@master] Remove anonymous user icon

https://gerrit.wikimedia.org/r/940263

gerritbot added a comment.Jul 21 2023, 12:26 AM

Change 940237 merged by jenkins-bot:

[mediawiki/core@master] Display temporary user icon

https://gerrit.wikimedia.org/r/940237

Jdlrobson moved this task from Code Review to QA on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 2) board.Jul 21 2023, 3:33 PM
gerritbot added a comment.Jul 21 2023, 3:58 PM

Change 940263 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Remove anonymous user icon

https://gerrit.wikimedia.org/r/940263

gerritbot added a comment.Jul 21 2023, 7:01 PM

Change 940236 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Add temporary user icon

https://gerrit.wikimedia.org/r/940236

Jdlrobson assigned this task to Edtadros.Jul 21 2023, 7:02 PM
Maintenance_bot removed a project: Patch-For-Review.Jul 21 2023, 7:11 PM
PatchDemoBot added a comment.Jul 24 2023, 5:19 PM

Test wiki created on Patch demo by Jdlrobson using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/67c6ac3826/w

Edtadros moved this task from QA to Ready for Signoff on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 2) board.Jul 25 2023, 12:02 AM

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Ventura
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

The new IP masked user icon (below) should be used in Vector and Minerva

image.png (20×20 px, 3 KB)

✅ AC1: Vector

Screenshot 2023-07-24 at 4.58.31 PM.png (331×995 px, 50 KB)

✅ AC2: Minerva
I couldn't get the skin to switch to minerva using the param, but this looks good in mobile.

Screenshot 2023-07-24 at 4.59.17 PM.png (504×993 px, 56 KB)

Edtadros removed Edtadros as the assignee of this task.Jul 25 2023, 12:03 AM
Edtadros updated the task description. (Show Details)
Edtadros subscribed.
Edtadros assigned this task to ovasileva.Jul 25 2023, 4:56 PM
ovasileva closed this task as Resolved.Jul 28 2023, 8:35 PM

Looks good, resolving.

Edtadros mentioned this in T319260: IP masking: Last modified bar: Minerva uses non-standard version of mw-ui-icon (Codex).Jul 31 2023, 9:41 PM
PatchDemoBot added a comment.Tue, Apr 23, 1:18 PM

Test wiki on Patch demo by Jdlrobson using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/67c6ac3826/w/

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL