Page MenuHomePhabricator
Create Task
Maniphest T345936

After logging out of a temporary account using the no-JS method, the grey bar says "You are using a temporary account: <your IP address>"
Closed, ResolvedPublic
Actions

Assigned To
kostajh
Authored By
matmarex
Sep 8 2023, 5:43 PM
Tags
Referenced Files
F55908113: image.png
Thu, Jun 27, 3:45 AM
F55908110: image.png
Thu, Jun 27, 3:45 AM
F37675152: image.png
Sep 8 2023, 5:43 PM
F37675157: image.png
Sep 8 2023, 5:43 PM
F37675155: image.png
Sep 8 2023, 5:43 PM
Subscribers
Aklapper
Djackson-ctr
matmarex
Ryasmeen

Description

(Discovered by @Ryasmeen, I simplified the reproduction steps)

Steps to reproduce:

  1. Become a temporary user
  2. Visit Special:UserLogout
    image.png (2×3 px, 232 KB)
  3. Click "Submit"
    image.png (2×3 px, 204 KB)

The grey bar is still visible, although it should only appear while using a temporary account, and it shows the IP address as the "temporary username". I guess this is just a visual bug, but it could be disconcerting.

This is not reproducible when using the "Exit session" menu option with JS enabled, which logs you out in a different manner (unless you open that link in a new window to navigate to Special:UserLogout).

image.png (551×1 px, 73 KB)

Details

SubjectRepoBranchLines +/-
User: Reset default value for isTemp in loadDefaultsmediawiki/coremaster+13 -0
Customize query in gerrit

Event Timeline

matmarex created this task.Sep 8 2023, 5:43 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 8 2023, 5:43 PM
Jdlrobson moved this task from Backlog to Menus 2.0 on the MediaWiki-Core-Skin-Architecture board.Sep 8 2023, 9:53 PM
Jdlrobson edited projects, added MediaWiki-Core-Skin-Architecture (Menus 2.0); removed MediaWiki-Core-Skin-Architecture.
Tchanders edited projects, added Temporary accounts (Update MediaWiki Core to introduce temp accounts); removed Temporary accounts.Tue, Jun 11, 5:25 PM
kostajh claimed this task.Thu, Jun 20, 9:48 AM
gerritbot added a comment.Thu, Jun 20, 11:08 AM

Change #1047944 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/core@master] User: Set default value for isTemp

https://gerrit.wikimedia.org/r/1047944

gerritbot added a project: Patch-For-Review.Thu, Jun 20, 11:08 AM
Tchanders added a project: Data Pipelines (Sprint 12).Fri, Jun 21, 10:31 AM
kostajh edited projects, added Trust and Safety Product Sprint (Sprint 12 (Jun 24 - July 5)); removed Data Pipelines (Sprint 12).Tue, Jun 25, 3:19 PM
kostajh moved this task from Priority Backlog to Needs Review on the Trust and Safety Product Sprint (Sprint 12 (Jun 24 - July 5)) board.
gerritbot added a comment.Tue, Jun 25, 10:05 PM

Change #1047944 merged by jenkins-bot:

[mediawiki/core@master] User: Reset default value for isTemp in loadDefaults

https://gerrit.wikimedia.org/r/1047944

Maintenance_bot removed a project: Patch-For-Review.Tue, Jun 25, 10:30 PM
ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.12; 2024-07-02).Tue, Jun 25, 11:00 PM
Dreamy_Jazz moved this task from Needs Review to Needs QA on the Trust and Safety Product Sprint (Sprint 12 (Jun 24 - July 5)) board.Wed, Jun 26, 8:20 AM
Djackson-ctr moved this task from Needs QA to Done on the Trust and Safety Product Sprint (Sprint 12 (Jun 24 - July 5)) board.Thu, Jun 27, 3:45 AM
Djackson-ctr subscribed.

I have verified the new code has been implemented and is functioning and displaying as expected:

image.png (540×1 px, 269 KB)

image.png (502×1 px, 188 KB)

kostajh closed this task as Resolved.Thu, Jun 27, 4:48 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL