Phonos button has no tooltip
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	Nardog
	Sep 13 2023, 12:13 AM

Description

Steps to replicate the issue (include links if applicable):

Preview <phonos file="Example.ogg"/>
Hover your mouse cursor over the speaker icon

What happens?:
Nothing except the cursor changes to a pointer.

What should have happened instead?:
A tooltip indicating what clicking it will do appears.

It's great that it has the aria-label "Play audio", but for sighted readers the lack of any indication of what clicking it will do is quite confusing.

QA Results - Beta

AC	Status	Details
1	✅	https://phabricator.wikimedia.org/T346193 here

Details

	Subject	Repo	Branch	Lines +/-
	PhonosButton: add tooltip, using the same message as the aria-label	mediawiki/extensions/Phonos	master	+11 -7

Customize query in gerrit

Related Objects

Mentioned In: T346429: Add tooltip to inline toggle
rEPHN703ac1309876: PhonosButton: add tooltip, using the same message as the aria-label
Mentioned Here: rMWd1368ff43839: Merge "Add since tag to UserOptionsManager::MAX_BYTES_OPTION_VALUE"

Event Timeline

Nardog created this task.Sep 13 2023, 12:13 AM

Restricted Application added a project: Community-Tech. · View Herald TranscriptSep 13 2023, 12:14 AM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

TheresNoTime edited projects, added Language-Team; removed Community-Tech.Sep 13 2023, 9:41 AM

Change 957826 had a related patch set uploaded (by MusikAnimal; author: MusikAnimal):

[mediawiki/extensions/Phonos@master] PhonosButton: add tooltip, using the same message as the aria-label

https://gerrit.wikimedia.org/r/957826

gerritbot added a project: Patch-For-Review.Sep 14 2023, 9:22 PM

MusikAnimal claimed this task.Sep 14 2023, 9:23 PM

MusikAnimal added a project: Community-Tech (CommTech-Kanban).

MusikAnimal moved this task from Ready 🎬 to Review/Feedback 💬 on the Community-Tech (CommTech-Kanban) board.

Samwilson moved this task from Review/Feedback 💬 to QA 🐛 on the Community-Tech (CommTech-Kanban) board.Sep 19 2023, 11:43 AM

Needs review again as I had to push another patchset

Change 957826 merged by jenkins-bot:

[mediawiki/extensions/Phonos@master] PhonosButton: add tooltip, using the same message as the aria-label

https://gerrit.wikimedia.org/r/957826

MusikAnimal mentioned this in rEPHN703ac1309876: PhonosButton: add tooltip, using the same message as the aria-label.Sep 20 2023, 12:03 AM

Maintenance_bot removed a project: Patch-For-Review.Sep 20 2023, 12:10 AM

Samwilson moved this task from Review/Feedback 💬 to QA 🐛 on the Community-Tech (CommTech-Kanban) board.Sep 20 2023, 12:14 AM

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.28; 2023-09-26).Sep 20 2023, 1:00 AM

@MusikAnimal Besides the accessibility from zooming in, the tooltip indicating what clicking it will do does appear. I will move this to Done and let me know if I should create a ticket on the zoom accessibility font being small. Thanks for all your work!

Status:✅ Pass
Environment: Beta: 1.41.0-alpha (d1368ff)
OS: macOS Ventura
Browser: Chrome 117, Firefox 117, Safari 16.6
Device: MBA M2
Emulated Device:: N/A
Test Links:
https://en.wikipedia.beta.wmflabs.org/wiki/Phonos_testGM

✅AC1: https://phabricator.wikimedia.org/T346193

2023-09-20_15-09-44.png (369×1 px, 69 KB)

Possible Issue- This is more on the accessibility issue. Do you think it's fine the "play audio" stays the same size even if you zoom in or make it bigger for those people who have a hard time reading small fonts?