RTP- reloads at the bottom of the page
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	GMikesell-WMF
	Sep 14 2023, 4:30 PM

Description

Steps to replicate the issue (include links if applicable):

Login to https://en.wikipedia.beta.wmflabs.org
Go to https://en.wikipedia.beta.wmflabs.org/w/index.php?title=Barack_Obama_Editable&action=edit
Make an edit to the page (but don't save)
Wait at least 5 seconds or however long it takes to have the edit on the RTP side
Reload the page

What happens?:
Once you make an edit on the page and it shows up on the RTP, refresh it, during the reload it goes to the bottom of the article

What should have happened instead?:
During reload it should go to the top of the article.

Other information (browser name/version, screenshots, etc.):
Environment: Beta
OS: macOS Ventura 13.5
Browser: Chrome 116
Device: MBA M2

QA Results - Beta

AC	Status	Details
1	✅	https://phabricator.wikimedia.org/T346370

Details

	Subject	Repo	Branch	Lines +/-
	Edit Recovery: reset textarea caret position to top	mediawiki/core	master	+2 -1

Customize query in gerrit

Related Objects

Mentioned In: T345315: Phonos attribution link (superscript "i") can wrap to next line, separated from the button
T343795: Performance problem on Chromium

Event Timeline

GMikesell-WMF created this task.Sep 14 2023, 4:30 PM

GMikesell-WMF mentioned this in T343795: Performance problem on Chromium.Sep 14 2023, 4:36 PM

I think this is a Edit Recovery bug.

The idea with TextSelection.setContents is that the caret position is restored, but when we're inserting the recovered contents the field likely doesn't have focus and so it doesn't have any before-state to restore it to.

Change 957849 had a related patch set uploaded (by Samwilson; author: Samwilson):

[mediawiki/core@master] Edit Recovery: reset textarea caret position to top

https://gerrit.wikimedia.org/r/957849

gerritbot added a project: Patch-For-Review.Sep 15 2023, 6:28 AM

Samwilson claimed this task.Sep 15 2023, 6:38 AM

Samwilson moved this task from Ready 🎬 to Review/Feedback 💬 on the Community-Tech (CommTech-Kanban) board.

HMonroy moved this task from Review/Feedback 💬 to QA 🐛 on the Community-Tech (CommTech-Kanban) board.Sep 19 2023, 6:40 AM

Change 957849 merged by jenkins-bot:

[mediawiki/core@master] Edit Recovery: reset textarea caret position to top

https://gerrit.wikimedia.org/r/957849

Maintenance_bot removed a project: Patch-For-Review.Sep 19 2023, 7:12 AM

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.28; 2023-09-26).Sep 19 2023, 1:01 PM

@Samwilson After you reload the article does appear at the top of the page now as seen in the gif. I will move this to Done. Thanks for all your work!

Status: ✅ PASS
Environment: Beta
OS: macOS Ventura
Browser: Chrome 116
Device: MBA M2
Emulated Device:: N/A
Test Links:
https://en.wikipedia.beta.wmflabs.org/w/index.php?title=Barack_Obama_Editable&action=edit

✅AC1: https://phabricator.wikimedia.org/T346370

2023-09-19_11-01-01.mp4.gif (1×1 px, 3 MB)

GMikesell-WMF mentioned this in T345315: Phonos attribution link (superscript "i") can wrap to next line, separated from the button.Sep 19 2023, 10:02 PM

MusikAnimal closed this task as Resolved.Sep 20 2023, 6:04 PM

RTP- reloads at the bottom of the pageClosed, ResolvedPublicBUG REPORTActions