| Nardog | |
| Aug 31 2023, 3:13 AM |
| F38208717: 2023-10-11_10-35-39.png | |
| Oct 11 2023, 5:50 PM |
| F38208714: 2023-10-11_08-20-11.png | |
| Oct 11 2023, 5:50 PM |
| F37740402: 2023-09-19_14-48-14.png | |
| Sep 19 2023, 10:00 PM |
| F37740384: 2023-09-19_14-49-45.png | |
| Sep 19 2023, 10:00 PM |
| F37740379: 2023-09-19_14-52-55.png | |
| Sep 19 2023, 10:00 PM |
| F37740329: 2023-09-19_14-52-22.png | |
| Sep 19 2023, 10:00 PM |
| F37740016: 2023-09-19_12-15-00.png | |
| Sep 19 2023, 7:18 PM |
| F37740014: 2023-09-19_12-10-24.png | |
| Sep 19 2023, 7:18 PM |
Steps to replicate the issue (include links if applicable):
What happens?:
Wrapping occurs between the text of a Phonos button and superscript "i".
What should have happened instead?:
The superscript is never separated from the last word in the label of the button.
| AC | Status | Details |
|---|---|---|
| 1 | ✅ | https://phabricator.wikimedia.org/T346370 can be seen here |
Change 957790 had a related patch set uploaded (by MusikAnimal; author: MusikAnimal):
[mediawiki/extensions/Phonos@master] PhonosButton.less: prevent attribution link from wrapping to new line
Change 957790 merged by jenkins-bot:
[mediawiki/extensions/Phonos@master] PhonosButton.less: prevent attribution link from wrapping to new line
@MusikAnimal I came across a couple of issues on Chrome as seen from the screenshots below. Let me know what you think and I'll move this back to Development, thanks!
Status:❌ FAIL
Environment: Local: 1.41.0-alpha (04a039e)20:19, 19 September 2023. Phonos: 0.1.0 (5b4f85d) 02:28, 19 September 2023 & Beta
OS: macOS Ventura
Browser: Chrome 116 Firefox 116, Safari 16.6
Device: MBA M2
Emulated Device:: N/A
Test Links:
http://localhost:8080/wiki/Phonos4
❌AC1: https://phabricator.wikimedia.org/T345315
| Safari-✅ | Firefox- ✅ | Chrome-❌ |
 |  |  |
Possible Issue
The superscript "i" is smaller in Firefox compared to Chrome and Safari. Also only in Chrome the speaker icons are clipped as seen in the screenshot below.
Both browsers zoom levels are at 100%
Change 959870 had a related patch set uploaded (by MusikAnimal; author: MusikAnimal):
[mediawiki/extensions/Phonos@master] Add wrapper around PhonosButton and attribution link
Change 959870 merged by jenkins-bot:
[mediawiki/extensions/Phonos@master] Add wrapper around PhonosButton and attribution link
@MusikAnimal The Chrome issue is now resolved as seen in the screenshots below, along with what was tested above. After talking about it, the small superscript "i" in Firefox is probably just a normal browser variance. I will move this to Done. Thanks for all your work!
Status: ✅PASS
Environment: Local: 1.42.0-alpha (489c7de)14:39, 11 October 2023. Phonos: 0.1.0 (4f99fd5) 06:45, 11 October 2023
OS: macOS Sonoma 14.0
Browser: Chrome 117
Device: MBA M2
Emulated Device:: n/a
Test Links:
http://localhost:8080/wiki/Phonos4
✅AC1: https://phabricator.wikimedia.org/T345315
| Chrome- Resolution | Chrome- Zoom |
 |  |