Maniphest T341956

Delete edit recovery data after 30 days
Open, Needs TriagePublicFeature
Actions

Assigned To

Authored By

	Samwilson
	Jul 17 2023, 5:12 AM

Description

Feature summary:

When saving any page, that page's edit recovery data is deleted. This is a good point at which to also delete any out of date data for other pages.

Pages have a lastModified field in their recovery data, which can be used to determine the last time a page was opened for editing. If a page hasn't been opened for editing within 30 days, its data should be deleted.

Acceptance criteria:

Pages that have not been edited for 30 days are removed from the edit recovery indexedDB storage.

Use cases:

As a user, I don't want my browser's storage filling up with unwanted recovery data for pages that I've not edited in a long time.

QA notes:

Details

	Project	Branch	Lines +/-	Subject
	mediawiki/core	master	+76 -7	editRecovery: Delete edit recovery data after 30 days

Customize query in gerrit

Related Objects

Mentioned In: T341853: Clear all data if $wgEnableEditRecovery == false
T342738: Delete edit recovery data of logged in user when anonymous or other user interacts with website
Mentioned Here: T121646: Document usage policy for LocalStorage in MediaWiki code

Event Timeline

Samwilson created this task.Jul 17 2023, 5:12 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 17 2023, 5:12 AM

Is 30 days appropriate here?

Samwilson updated the task description. (Show Details)Jul 17 2023, 5:54 AM

Samwilson moved this task from Backlog to Ready on the Edit Recovery board.Jul 26 2023, 6:12 AM

Restricted Application added a project: Community-Tech. · View Herald TranscriptJul 26 2023, 6:12 AM

TheDJ mentioned this in T342738: Delete edit recovery data of logged in user when anonymous or other user interacts with website.Jul 26 2023, 10:06 AM

MusikAnimal moved this task from New & TBD Tickets to To Be Estimated/Discussed on the Community-Tech board.Jul 26 2023, 2:08 PM

dmaza moved this task from To Be Estimated/Discussed to CommTech-Kanban on the Community-Tech board.Aug 2 2023, 2:21 PM

dmaza edited projects, added Community-Tech (CommTech-Kanban); removed Community-Tech.

Esanders mentioned this in T341853: Clear all data if $wgEnableEditRecovery == false.Aug 7 2023, 10:37 AM

I would recommend implementing a generic expiry API, like we did with localStorage in T121646.

Yes, definitely a good idea. I've been investigating doing that, and it has been a bit of a trade off between building something now for this use case, and building a framework that could work for future use cases as well (without actually knowing what those are, at the moment — which is why I've hesitated so far).

We'll look at moving the generic bits of the storage layer to a central place e.g. mediawiki.indexedDB. mw.storage has an optional expiry, but we could make it mandatory probably.