Page MenuHomePhabricator
Create Task
Maniphest T346401

Clean Cache HTML support classes for TOC pinned/ unpinned
Closed, ResolvedPublic0 Estimated Story Points
Actions

Assigned To
None
Authored By
• Mabualruz
Sep 14 2023, 9:46 PM
Tags
Referenced Files
F37922242: screenshot 52.mov.gif
Oct 5 2023, 3:43 PM
F37922239: screenshot 51.mov.gif
Oct 5 2023, 3:43 PM
F37866489: screenshot 46.mov.gif
Sep 30 2023, 5:30 PM
F37866487: screenshot 47.mov.gif
Sep 30 2023, 5:30 PM
Subscribers
Aklapper
Edtadros
Jdlrobson
• Mabualruz
ovasileva

Description

Description

mediawiki 1.41.0-wmf.27 will have the changes from the parent task
We need to 1.41.0-wmf.29 or 1.41.0-wmf.30 to have this task released with it so we can remove vector-feature-toc-pinned-(enabled|disabled) when cache is updated with new classes

QA

  • Table of contents should persist for anons
  • Table of contents should persist for registered users

QA Results - Beta

ACStatusDetails
1✅T346401#9213286
2✅T346401#9213286

QA Results - Prod

ACStatusDetails
1✅T346401#9228780
2✅T346401#9228780

Details

SubjectRepoBranchLines +/-
Clean up FIXMES now the cache has clearedmediawiki/skins/Vectormaster+9 -31
Customize query in gerrit

Related Objects
Search...

Event Timeline

• Mabualruz created this task.Sep 14 2023, 9:46 PM
• Mabualruz renamed this task from Clean CAche HTML support classes for TOC pinned/ unpinned to Clean Cache HTML support classes for TOC pinned/ unpinned.Sep 14 2023, 9:48 PM
• Mabualruz updated the task description. (Show Details)
Jdlrobson moved this task from Incoming to Web Team FY2023-24 Q1 Sprint 6.5 (Quarter wrap up) on the Web-Team-Backlog board.Sep 14 2023, 10:23 PM
Jdlrobson edited projects, added Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 6.5 (Quarter wrap up)); removed Web-Team-Backlog.
gerritbot added a comment.Sep 14 2023, 11:29 PM

Change 957795 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@master] Clean up FIXMES now the cache has cleared

https://gerrit.wikimedia.org/r/957795

gerritbot added a project: Patch-For-Review.Sep 14 2023, 11:29 PM
gerritbot added a comment.Sep 20 2023, 7:50 AM

Change 957795 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Clean up FIXMES now the cache has cleared

https://gerrit.wikimedia.org/r/957795

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.28; 2023-09-26).Sep 20 2023, 8:00 AM
Maintenance_bot removed a project: Patch-For-Review.Sep 20 2023, 8:10 AM
Jdlrobson removed • Mabualruz as the assignee of this task.Sep 20 2023, 11:40 PM
Jdlrobson triaged this task as Low priority.
Jdlrobson moved this task from Incoming to QA on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 6.5 (Quarter wrap up)) board.
Jdlrobson updated the task description. (Show Details)
Jdlrobson set the point value for this task to 0.Sep 25 2023, 5:42 PM
Jdlrobson assigned this task to Edtadros.Sep 26 2023, 4:38 PM
Edtadros removed Edtadros as the assignee of this task.EditedSep 30 2023, 5:30 PM
Edtadros moved this task from QA to Ready for Signoff on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 6.5 (Quarter wrap up)) board.
Edtadros subscribed.

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Ventura
Browser: Chrome
Device: MBA
Emulated Device:NA

Test Artifact(s):

QA Steps

✅ AC1: Table of contents should persist for anons

screenshot 47.mov.gif (930×1 px, 2 MB)

✅ AC2: Table of contents should persist for registered users

screenshot 46.mov.gif (930×1 px, 2 MB)

Edtadros updated the task description. (Show Details)Sep 30 2023, 5:31 PM
Jdlrobson assigned this task to • Mabualruz.Oct 2 2023, 5:10 PM
• Mabualruz moved this task from Ready for Signoff to QA in Production on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 6.5 (Quarter wrap up)) board.Oct 2 2023, 5:12 PM

I have checked in in prod manually seems to be good to go just a quick QA input to verify and resolve

• Mabualruz removed • Mabualruz as the assignee of this task.Oct 2 2023, 5:14 PM
Jdlrobson assigned this task to Edtadros.Oct 2 2023, 6:24 PM
Jdlrobson moved this task from Incoming to Technical architecture on the Desktop Improvements (Vector 2022) board.Oct 2 2023, 6:34 PM
bwang mentioned this in T348039: TOC "move to sidebar" and "hide" labels are incorrect for anon users when TOC is hidden by default.Oct 3 2023, 6:11 PM
Edtadros added a comment.EditedOct 5 2023, 3:43 PM

Test Result - Prod

Status: ✅ PASS
Environment: enwiki
OS: macOS Ventura
Browser: Chrome
Device: MBA
Emulated Device:NA

Test Artifact(s):

QA Steps

✅ AC1: Table of contents should persist for anons

screenshot 51.mov.gif (1×1 px, 3 MB)

✅ AC2: Table of contents should persist for registered users

screenshot 52.mov.gif (1×1 px, 2 MB)

Edtadros closed this task as Resolved.Oct 5 2023, 3:50 PM
Edtadros removed Edtadros as the assignee of this task.
Edtadros updated the task description. (Show Details)
Edtadros added a project: Verified.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits