Maniphest T346449

[BUG] Watchlist does not theme with Dim Images selected
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	Tsevener
	Sep 15 2023, 2:48 PM

Tags

Referenced Files

	F37766123: IMG_BEDACDB0D930-1.jpeg
	Sep 25 2023, 3:21 PM

Subscribers

Description

Steps to reproduce

Go to Settings > Reading preferences
Select Dark or Black theme
Check on Dim images
Go to Watchlist

Expected results

Watchlist is themed with dark or black theme

Actual results

Watchlist is themed with light theme

Environments observed

App version: 7.4.2 (2622)
OS versions: 16.6.1
Device model: iPhone 12 mini
Device language: EN

Related Objects

Mentioned In: T347778: Release 7.4.2
T335606: Create designs for iOS watchlist list home and contextual actions for list items

Event Timeline

Tsevener created this task.Sep 15 2023, 2:48 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 15 2023, 2:48 PM

Tsevener updated the task description. (Show Details)Sep 15 2023, 2:49 PM

JTannerWMF triaged this task as Low priority.Sep 19 2023, 4:49 PM

JTannerWMF moved this task from Needs Triage to Engineering Backlog on the Wikipedia-iOS-App-Backlog board.

Tsevener mentioned this in T335606: Create designs for iOS watchlist list home and contextual actions for list items .Sep 21 2023, 7:16 PM

• Dmantena claimed this task.Sep 21 2023, 9:47 PM

• Dmantena added a project: iOS Release FY2023-24 (Archive).

• Dmantena moved this task from Tasks from Product Backlog to Doing on the iOS Release FY2023-24 (Archive) board.Sep 21 2023, 9:51 PM

PR: https://github.com/wikimedia/wikipedia-ios/pull/4637

• Dmantena moved this task from Needs Code Review to Needs QA on the iOS Release FY2023-24 (Archive) board.Sep 21 2023, 11:34 PM

This one is still happening for me on 7.4.2 (Build 2654)

Note - It only happens if Dim Images is turned on

IMG_BEDACDB0D930-1.jpeg (2×1 px, 602 KB)

In T346449#9195835, @ABorbaWMF wrote:

This one is still happening for me on 7.4.2 (Build 2654)

Note - It only happens if Dim Images is turned on

@ABorbaWMF Odd – I'm still trying to understanding how this is occurring as the fix for this should have been in the build. Can you confirm your Reading Preferences page settings? Is just "Dim images" enabled, or are "Expand tables" and article text sizing also changed from default?

In T346449#9195835, @ABorbaWMF wrote:

This one is still happening for me on 7.4.2 (Build 2654)

@ABorbaWMF Apologies – I was confused looking at the wrong build. Can you please recheck this in 7.4.2 (2658) which I added you as a tester to (also available to external testers)? It should be resolved in that build.

Looks good to me on 7.4.2 (2658)

Tsevener mentioned this in T347778: Release 7.4.2.Sep 29 2023, 10:10 PM

JTannerWMF moved this task from Ready for PM Signoff to Ready for Release on the iOS Release FY2023-24 (Archive) board.Oct 2 2023, 9:49 PM

Tsevener closed this task as Resolved.Oct 11 2023, 2:16 PM