Mobile main menu icon missing when Growth home page enabled
Closed, ResolvedPublic2 Estimated Story PointsBUG REPORT
Actions

Assigned To

Authored By

	Jdlrobson
	Sep 15 2023, 5:54 PM

Description

NOTE: likely broken due to the mediawiki UI to Codex migration

Steps to replicate the issue (include links if applicable):

*On https://en.wikipedia.org/wiki/Special:Preferences set https://en.wikipedia.org/wiki/Special:Preferences set Default to newcomer homepage from username link in personal tools

Visit https://en.m.wikipedia.org/
Open main menu

What happens?:
No icon

Screenshot 2023-09-15 at 10.52.07 AM.png (1×1 px, 363 KB)

What should have happened instead?:
Should show newspaper icon

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

QA Results - Beta

AC	Status	Details
1	✅	T346459#9189610

Details

	Subject	Repo	Branch	Lines +/-
	Change CSS selector for Minerva mobile menu icon	mediawiki/extensions/GrowthExperiments	wmf/1.41.0-wmf.27	+1 -1
	Change CSS selector for Minerva mobile menu icon	mediawiki/extensions/GrowthExperiments	master	+1 -1

Customize query in gerrit

Related Objects

Mentioned In: T346629: GrowthExperiments CI fails on master: mwgate-node16-docker
Mentioned Here: T346629: GrowthExperiments CI fails on master: mwgate-node16-docker

Event Timeline

Jdlrobson created this task.Sep 15 2023, 5:54 PM

Restricted Application added a project: Growth-Team. · View Herald TranscriptSep 15 2023, 5:54 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Jdlrobson renamed this task from Mobile main menu icon missing when Growth home page missing to Mobile main menu icon missing when Growth home page enabled.Sep 15 2023, 5:54 PM

ovasileva triaged this task as Medium priority.Sep 18 2023, 4:18 PM

The modules is here: https://github.com/wikimedia/mediawiki-extensions-GrowthExperiments/blob/e0211b6f6a0aebba086b6c3940569348b43e8023/extension.json#L653

ovasileva set the point value for this task to 2.Sep 18 2023, 5:26 PM

Jdlrobson moved this task from Incoming to Ready for Development on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 6) board.Sep 18 2023, 5:27 PM

Jdlrobson assigned this task to Jdrewniak.Sep 18 2023, 5:32 PM

Jdlrobson moved this task from Ready for Development to Doing on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 6) board.

Change 958950 had a related patch set uploaded (by Jdrewniak; author: Jdrewniak):

[mediawiki/extensions/GrowthExperiments@master] Change CSS selector for Minerva mobile menu icon

https://gerrit.wikimedia.org/r/958950

gerritbot added a project: Patch-For-Review.Sep 19 2023, 2:39 PM

Jdrewniak removed Jdrewniak as the assignee of this task.Sep 19 2023, 2:47 PM

Jdrewniak moved this task from Doing to Code Review on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 6) board.

Jdrewniak subscribed.

Change 958950 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Change CSS selector for Minerva mobile menu icon

https://gerrit.wikimedia.org/r/958950

Maintenance_bot removed a project: Patch-For-Review.Sep 19 2023, 3:31 PM

Jdlrobson assigned this task to Edtadros.Sep 19 2023, 3:47 PM

Jdlrobson moved this task from Code Review to QA on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 6) board.

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.28; 2023-09-26).Sep 19 2023, 4:00 PM

Change 959007 had a related patch set uploaded (by Jdlrobson; author: Jdrewniak):

[mediawiki/extensions/GrowthExperiments@wmf/1.41.0-wmf.27] Change CSS selector for Minerva mobile menu icon

https://gerrit.wikimedia.org/r/959007

gerritbot added a project: Patch-For-Review.Sep 19 2023, 5:04 PM

Change 959007 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@wmf/1.41.0-wmf.27] Change CSS selector for Minerva mobile menu icon

https://gerrit.wikimedia.org/r/959007

Mentioned in SAL (#wikimedia-operations) [2023-09-20T13:21:48Z] <urbanecm@deploy2002> Started scap: Backport for [[gerrit:959014|build: Update eslint-config-wikimedia to 0.25.1 (T346629)]], [[gerrit:959007|Change CSS selector for Minerva mobile menu icon (T346459)]]

Maintenance_bot removed a project: Patch-For-Review.Sep 20 2023, 1:32 PM

Mentioned in SAL (#wikimedia-operations) [2023-09-20T13:42:17Z] <urbanecm@deploy2002> urbanecm and jdlrobson: Backport for [[gerrit:959014|build: Update eslint-config-wikimedia to 0.25.1 (T346629)]], [[gerrit:959007|Change CSS selector for Minerva mobile menu icon (T346459)]] synced to the testservers mwdebug1002.eqiad.wmnet, mwdebug1001.eqiad.wmnet, mwdebug2001.codfw.wmnet, mwdebug2002.codfw.wmnet, and mw-debug kubernetes deployment (accessible via k8s-experimental XWD option)

Mentioned in SAL (#wikimedia-operations) [2023-09-20T13:56:12Z] <urbanecm@deploy2002> Finished scap: Backport for [[gerrit:959014|build: Update eslint-config-wikimedia to 0.25.1 (T346629)]], [[gerrit:959007|Change CSS selector for Minerva mobile menu icon (T346459)]] (duration: 34m 21s)

ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.27; 2023-09-19); removed MW-1.41-notes (1.41.0-wmf.28; 2023-09-26).Sep 20 2023, 2:00 PM

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Ventura
Browser: Chrome
Device: MBA
Emulated Device:NA

Test Artifact(s):

QA Steps

*On https://en.wikipedia.org/wiki/Special:Preferences set https://en.wikipedia.org/wiki/Special:Preferences set Default to newcomer homepage from username link in personal tools

Visit https://en.m.wikipedia.org/ or beta equivalent
Open main menu
✅ AC1: Should show newspaper icon

Edtadros updated the task description. (Show Details)Sep 22 2023, 2:15 AM

Checked as a part of post-deployment checking for wmf.27 - the issue has been fixed:

Screen Shot 2023-09-22 at 1.26.33 PM.png (1×860 px, 146 KB)

Jdlrobson assigned this task to ovasileva.Sep 22 2023, 10:56 PM

All done, thank you all!

	F37751898: Screen Shot 2023-09-22 at 1.26.33 PM.png
	Sep 22 2023, 8:28 PM

	F37727779: Screenshot 2023-09-15 at 10.52.07 AM.png
	Sep 15 2023, 5:54 PM

	F37748485: screenshot 78.png
	Sep 22 2023, 2:12 AM

Mobile main menu icon missing when Growth home page enabledClosed, ResolvedPublic2 Estimated Story PointsBUG REPORTActions