Page MenuHomePhabricator

Don't convert Vorbis into MP3
Open, LowPublic

Description

The extension PHONOS converts Vorbis files into MP3 for no reason. The effect is observable for the examples at https://www.mediawiki.org/wiki/Help:Extension:Phonos This should NOT happen. Expected outcome: the Vorbis file plays natively.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Tacsipacsi renamed this task from Don't convert Vorbis into MP5 to Don't convert Vorbis into MP3.Sep 17 2023, 10:03 AM
Tacsipacsi subscribed.
  1. MP3 is no longer a proprietary technology
  2. MP3, unlike Vorbis, is universally supported, and works in any browser without using non-native technology, which is what makes this a simpler and less intrusive solution than for instance TimedMediaHandler’s player.
MusikAnimal triaged this task as Low priority.EditedSep 17 2023, 5:47 PM
MusikAnimal removed a project: Community-Tech.
MusikAnimal subscribed.

Phonos has a soft dependency on TimedMediaHandler. TMH will check if OGG is supported, and if not it will serve MP3 (or possibly other formats). We were not able to fully leverage this functionality in Phonos, so it seemed best to just check if a MP3 transcoded variant exists and use it anywhere and everywhere possible, as per above, it is universally supported and also non-proprietary. See T322368 for more.

That said, I see OGG can sometimes have a smaller file size, so I don't think anyone is against using it if it's supported by the client. The issue is checking if it is supported, and choosing the right format accordingly, without duplicating a ton of code in TimedMediaHandler.

The fault is in the proprietary "Ios" and the proprietary "InternerExplorer". I am aware that some of the patents on MP3 expired, still converting Vorbis to (inferior) MP3 is anything else than a gain. As long as users of proprietary stuff are the most privileged group having everything working smoothly and "natively", whereas users of free software and free file formats have trouble, the power of the proprietary companies will not shrink. PNG as a temporary solution until the patent on LZW84 expires, Vorbis as a temporary solution until the patents on MP3 expire, Theora as a temporary solution until the patents on old MPEG expire ... who would want to ever design a free file format under such provisions?

Would it be too complicated or hurt performance if it did what TMH does with [[File:...]], namely <audio> with <source src="..." type="audio/ogg; codecs='vorbis'" />, <source src="..." type="audio/mpeg" />, and so on? Although I see no problem with MP3, that approach strikes me as the obvious one as it leaves figuring out which formats are supported up to the browser itself.

Would it be too complicated or hurt performance if it did what TMH does with [[File:...]], namely <audio> with <source src="..." type="audio/ogg; codecs='vorbis'" />, <source src="..." type="audio/mpeg" />, and so on? Although I see no problem with MP3, that approach strikes me as the obvious one as it leaves figuring out which formats are supported up to the browser itself.

Yes, we can look into something like that. What I was avoiding was use of the shim and the source selection logic therein, but I guess we don't care about those old browsers, anyway.