Page MenuHomePhabricator
Create Task
Maniphest T347067

Remove feature flag for email participants
Closed, ResolvedPublic
Actions

Description

Acceptance criteria

  • The CampaignEventsEnableEmail setting is removed from the CampaignEvents extension codebase
  • The CampaignEventsEnableEmail flag is no longer set in the Wikimedia configuration

Details

SubjectRepoBranchLines +/-
Remove feature flag for emailmediawiki/extensions/CampaignEventswmf/1.42.0-wmf.4+10 -50
Remove feature flag for emailmediawiki/extensions/CampaignEventswmf/1.42.0-wmf.3+10 -50
prod: Stop setting $wgCampaignEventsEnableEmail, unusedoperations/mediawiki-configmaster+0 -8
beta: Stop setting $wgCampaignEventsEnableEmail, unusedoperations/mediawiki-configmaster+0 -3
Remove feature flag for emailmediawiki/extensions/CampaignEventsmaster+10 -50
Customize query in gerrit

Related Objects
Search...

Event Timeline

ifried renamed this task from Remove feature flag foe email participants to Remove feature flag for email participants.Sep 21 2023, 2:46 PM
ifried removed MHorsey-WMF as the assignee of this task.
ifried created this task.
ifried removed a project: Epic.
ifried removed subscribers: Aklapper, MHorsey-WMF, • vyuen and 3 others.
Daimona moved this task from Backlog to To be Estimated/Discussed on the Campaigns-Product-Team board.Oct 5 2023, 9:08 PM
ifried edited projects, added Campaigns-Product-Team (Campaign-Tools-Current-Sprint); removed Campaigns-Product-Team.Oct 31 2023, 3:15 PM
ifried moved this task from Upcoming / refining 💡 to Ready for development on the Campaigns-Product-Team (Campaign-Tools-Current-Sprint) board.
Daimona claimed this task.Oct 31 2023, 8:51 PM
Daimona updated the task description. (Show Details)
Daimona updated the task description. (Show Details)

Given this is not urgent, I'm going to remove the flag from the codebase now, and then we can remove it from the Wikimedia config once the version of the extension without the flag has reached all production wikis.

gerritbot added a comment.Oct 31 2023, 8:58 PM

Change 970449 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/extensions/CampaignEvents@master] Remove feature flag for email

https://gerrit.wikimedia.org/r/970449

gerritbot added a project: Patch-For-Review.Oct 31 2023, 8:59 PM
Daimona moved this task from Ready for development to Code Review 💬 on the Campaigns-Product-Team (Campaign-Tools-Current-Sprint) board.Oct 31 2023, 9:03 PM
gerritbot added a comment.Nov 7 2023, 4:58 PM

Change 970449 merged by jenkins-bot:

[mediawiki/extensions/CampaignEvents@master] Remove feature flag for email

https://gerrit.wikimedia.org/r/970449

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.5; 2023-11-14).Nov 7 2023, 5:00 PM
Maintenance_bot removed a project: Patch-For-Review.Nov 7 2023, 5:10 PM
gerritbot added a comment.Nov 7 2023, 5:22 PM

Change 972428 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[operations/mediawiki-config@master] beta: Stop setting $wgCampaignEventsEnableEmail, unused

https://gerrit.wikimedia.org/r/972428

gerritbot added a project: Patch-For-Review.Nov 7 2023, 5:22 PM

Change 972429 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[operations/mediawiki-config@master] prod: Stop setting $wgCampaignEventsEnableEmail, unused

https://gerrit.wikimedia.org/r/972429

Daimona added a comment.Nov 7 2023, 5:25 PM

The extension patch didn't make it into the wmf.4 branch. I will schedule a backport so that we can get this done sooner.

gerritbot added a comment.Nov 7 2023, 5:26 PM

Change 972260 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/extensions/CampaignEvents@wmf/1.42.0-wmf.4] Remove feature flag for email

https://gerrit.wikimedia.org/r/972260

Daimona added a comment.Nov 7 2023, 5:55 PM

All changes are scheduled for tomorrow.

gerritbot added a comment.Nov 8 2023, 2:02 PM

Change 972713 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/extensions/CampaignEvents@wmf/1.42.0-wmf.3] Remove feature flag for email

https://gerrit.wikimedia.org/r/972713

gerritbot added a comment.Nov 8 2023, 2:06 PM

Change 972428 merged by jenkins-bot:

[operations/mediawiki-config@master] beta: Stop setting $wgCampaignEventsEnableEmail, unused

https://gerrit.wikimedia.org/r/972428

gerritbot added a comment.Nov 8 2023, 2:08 PM

Change 972429 merged by jenkins-bot:

[operations/mediawiki-config@master] prod: Stop setting $wgCampaignEventsEnableEmail, unused

https://gerrit.wikimedia.org/r/972429

gerritbot added a comment.Nov 8 2023, 2:10 PM

Change 972713 merged by jenkins-bot:

[mediawiki/extensions/CampaignEvents@wmf/1.42.0-wmf.3] Remove feature flag for email

https://gerrit.wikimedia.org/r/972713

gerritbot added a comment.Nov 8 2023, 2:10 PM

Change 972260 merged by jenkins-bot:

[mediawiki/extensions/CampaignEvents@wmf/1.42.0-wmf.4] Remove feature flag for email

https://gerrit.wikimedia.org/r/972260

Stashbot added a comment.Nov 8 2023, 2:10 PM

Mentioned in SAL (#wikimedia-operations) [2023-11-08T14:10:57Z] <taavi@deploy2002> Started scap: Backport for [[gerrit:972713|Remove feature flag for email (T347067)]], [[gerrit:972260|Remove feature flag for email (T347067)]], [[gerrit:972429|prod: Stop setting $wgCampaignEventsEnableEmail, unused (T347067)]]

Stashbot added a comment.Nov 8 2023, 2:12 PM

Mentioned in SAL (#wikimedia-operations) [2023-11-08T14:12:22Z] <taavi@deploy2002> taavi and daimona: Backport for [[gerrit:972713|Remove feature flag for email (T347067)]], [[gerrit:972260|Remove feature flag for email (T347067)]], [[gerrit:972429|prod: Stop setting $wgCampaignEventsEnableEmail, unused (T347067)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Stashbot added a comment.Nov 8 2023, 2:23 PM

Mentioned in SAL (#wikimedia-operations) [2023-11-08T14:23:16Z] <taavi@deploy2002> Finished scap: Backport for [[gerrit:972713|Remove feature flag for email (T347067)]], [[gerrit:972260|Remove feature flag for email (T347067)]], [[gerrit:972429|prod: Stop setting $wgCampaignEventsEnableEmail, unused (T347067)]] (duration: 12m 19s)

Maintenance_bot removed a project: Patch-For-Review.Nov 8 2023, 2:30 PM
Daimona moved this task from Code Review 💬 to QA 🐛 on the Campaigns-Product-Team (Campaign-Tools-Current-Sprint) board.Nov 8 2023, 2:32 PM
Daimona added a subscriber: vaughnwalters.

@vaughnwalters: The only thing to test here is that the email functionality is still working as usual. There should be no change in behaviour.

ReleaseTaggerBot edited projects, added MW-1.42-notes (1.42.0-wmf.4; 2023-11-07); removed MW-1.42-notes (1.42.0-wmf.5; 2023-11-14).Nov 8 2023, 3:00 PM
vaughnwalters closed this task as Resolved.Nov 9 2023, 4:26 PM
vaughnwalters moved this task from QA 🐛 to Done 🏁 on the Campaigns-Product-Team (Campaign-Tools-Current-Sprint) board.

This is still working as expected. Marking as done / resolved.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits