PHP Notice: Undefined index: tasks
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Assigned To

Authored By

	Etonkovidova
	Sep 21 2023, 11:47 PM

Description

Error

mwversion: 1.41.0-wmf.27
reqId: fe9224257d627cea8c9068ab
Find reqId in Logstash

normalized_message

[{reqId}] {exception_url}   PHP Notice: Undefined index: tasks

exception.trace

from /srv/mediawiki/php-1.41.0-wmf.27/extensions/GrowthExperiments/maintenance/listTaskCounts.php(125)
#0 /srv/mediawiki/php-1.41.0-wmf.27/extensions/GrowthExperiments/maintenance/listTaskCounts.php(125): MWExceptionHandler::handleError(integer, string, string, integer, array)
#1 /srv/mediawiki/php-1.41.0-wmf.27/extensions/GrowthExperiments/maintenance/listTaskCounts.php(65): GrowthExperiments\Maintenance\ListTaskCounts->getStats(array, array)
#2 /srv/mediawiki/php-1.41.0-wmf.27/maintenance/includes/MaintenanceRunner.php(703): GrowthExperiments\Maintenance\ListTaskCounts->execute()
#3 /srv/mediawiki/php-1.41.0-wmf.27/maintenance/run.php(51): MediaWiki\Maintenance\MaintenanceRunner->run()
#4 /srv/mediawiki/multiversion/MWScript.php(159): require_once(string)
#5 {main}

Impact

there are 174 errors in 1 day - link to the error in logstash
the Console also displays the error: task preview data unavailable: Invalid task type(s): initSuggestedTasks
there are quite few wikis where Suggested edit tasks are not available. A user with enabled Special:Homepage still sees the tasks filters (empty) and topic selections. This might confuse users - they can select some topics, but not task difficulty filters.

The screenshot from tywiki Special:Homrpage:

Screen Shot 2023-09-21 at 4.37.08 PM.png (1×1 px, 189 KB)

Details

	Subject	Repo	Branch	Lines +/-
	listTaskCounts: Do not expect tasks key to be present	mediawiki/extensions/GrowthExperiments	wmf/1.41.0-wmf.27	+3 -1
	listTaskCounts: Do not expect tasks key to be present	mediawiki/extensions/GrowthExperiments	master	+3 -1

Customize query in gerrit

Related Objects

Mentioned In: T346277: Addimage feedback API cannot be called successfully
T342871: Parsoid + Kartographer roll-out plan
Mentioned Here: T342871: Parsoid + Kartographer roll-out plan
T346277: Addimage feedback API cannot be called successfully

Event Timeline

Etonkovidova created this task.Sep 21 2023, 11:47 PM

Restricted Application added a project: Growth-Team. · View Herald TranscriptSep 21 2023, 11:47 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Etonkovidova updated the task description. (Show Details)Sep 22 2023, 12:07 AM

This happens very frequently. A recent fallout from a change to listTaskCounts.php...

Change 960032 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] listTaskCounts: Do not expect tasks key to be present

https://gerrit.wikimedia.org/r/960032

gerritbot added a project: Patch-For-Review.Sep 22 2023, 12:06 PM

Urbanecm_WMF edited projects, added Growth-Team (Sprint 0 (Growth Team)); removed Growth-Team.Sep 22 2023, 12:07 PM

Urbanecm_WMF moved this task from Incoming to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.

Change 960032 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] listTaskCounts: Do not expect tasks key to be present

https://gerrit.wikimedia.org/r/960032

Urbanecm_WMF moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Sep 22 2023, 2:45 PM

Change 959987 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@wmf/1.41.0-wmf.27] listTaskCounts: Do not expect tasks key to be present

https://gerrit.wikimedia.org/r/959987

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.28; 2023-09-26).Sep 22 2023, 3:00 PM

Etonkovidova awarded a token.Sep 22 2023, 5:28 PM

Etonkovidova moved this task from QA to Test in Production | Watching on the Growth-Team (Sprint 0 (Growth Team)) board.Sep 22 2023, 11:03 PM

Change 959987 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@wmf/1.41.0-wmf.27] listTaskCounts: Do not expect tasks key to be present

https://gerrit.wikimedia.org/r/959987

Mentioned in SAL (#wikimedia-operations) [2023-09-25T13:26:03Z] <urbanecm@deploy2002> Started scap: Backport for [[gerrit:959987|listTaskCounts: Do not expect tasks key to be present (T347120)]], [[gerrit:959993|AddImageFeedbackHandler: Add missing parameters (T346277)]], [[gerrit:960552|Enable Parsoid support for Kartographer on enwikivoyage (T342871)]]

Maintenance_bot removed a project: Patch-For-Review.Sep 25 2023, 1:31 PM

Mentioned in SAL (#wikimedia-operations) [2023-09-25T13:38:33Z] <urbanecm@deploy2002> urbanecm and ihurbain: Backport for [[gerrit:959987|listTaskCounts: Do not expect tasks key to be present (T347120)]], [[gerrit:959993|AddImageFeedbackHandler: Add missing parameters (T346277)]], [[gerrit:960552|Enable Parsoid support for Kartographer on enwikivoyage (T342871)]] synced to the testservers mwdebug1001.eqiad.wmnet, mwdebug2001.codfw.wmnet, mwdebug2002.codfw.wmnet, mwdebug1002.eqiad.w

ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.27; 2023-09-19); removed MW-1.41-notes (1.41.0-wmf.28; 2023-09-26).Sep 25 2023, 2:00 PM

Mentioned in SAL (#wikimedia-operations) [2023-09-25T14:04:38Z] <urbanecm@deploy2002> Finished scap: Backport for [[gerrit:959987|listTaskCounts: Do not expect tasks key to be present (T347120)]], [[gerrit:959993|AddImageFeedbackHandler: Add missing parameters (T346277)]], [[gerrit:960552|Enable Parsoid support for Kartographer on enwikivoyage (T342871)]] (duration: 38m 35s)

The errors have stopped after the fix was deployed logstash link.

	F37748107: Screen Shot 2023-09-21 at 4.37.08 PM.png
	Sep 21 2023, 11:47 PM

PHP Notice: Undefined index: tasksClosed, ResolvedPublicPRODUCTION ERRORActions