Page MenuHomePhabricator
Create Task
Maniphest T347604

Remove links field and rely on links automatically included in the report
Closed, ResolvedPublic
Actions

Assigned To
kostajh
Authored By
Madalina
Sep 28 2023, 3:55 PM
Tags
Referenced Files
F40000611: image.png
Oct 25 2023, 5:26 AM
F40000592: image.png
Oct 25 2023, 5:26 AM
F39779937: image.png
Oct 25 2023, 5:26 AM
F39779935: image.png
Oct 25 2023, 5:26 AM
F39779940: image.png
Oct 25 2023, 5:26 AM
F39779942: image.png
Oct 25 2023, 5:26 AM
F38000726: image.png
Oct 6 2023, 1:25 PM
F38000720: image.png
Oct 6 2023, 1:25 PM
Subscribers
Aklapper
Djackson-ctr
Dreamy_Jazz
JSengupta-WMF
kostajh
Madalina
Tchanders

Description

Background
The form includes a Links field where the user is supposed to provide evidence of the incident. We should remove the links field for the following reasons:

  • Users interacting with DiscussionTools will have a link to the topic/comment automatically included in the report
  • the report includes the revision ID of the page
  • providing links might be difficult to achieve by users who are not very experienced

User Stories

  • As a user I need to be able to include the comment/thread that is harmful in the report so that the responder can check it.
  • As a user I need to be able to include in the report any additional links that might be helpful to clarify my case so that the respond can have all the information.
  • As a responder I need to be able to check the comments/threads that are being reported so that I can decide whether the case is valid.

Acceptance criteria:

  • Email with the report contains a link to the comment/thread being reported - T349570
  • Email with the report contains the revision ID of the page at the state the user saw it
  • Email with the report contains any additional links user might have added in the "Details" area
  • There is no links field in the form

Details

SubjectRepoBranchLines +/-
form: Remove links fieldmediawiki/extensions/ReportIncidentmaster+3 -105
Customize query in gerrit

Related Objects
Search...

Event Timeline

Madalina created this task.Sep 28 2023, 3:55 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 28 2023, 3:56 PM
Madalina updated the task description. (Show Details)Sep 28 2023, 3:56 PM
kostajh added a parent task: T337566: [EPIC]: Incident Reporting System - Minimal Testable Product (MTP).Oct 6 2023, 1:21 PM
kostajh added subscribers: JSengupta-WMF, kostajh.Oct 6 2023, 1:25 PM

@JSengupta-WMF @Madalina do we want to update the "Additional details" field help text to prompt the user that they can add links there if they want?

image.png (286×964 px, 30 KB)

image.png (340×1 px, 32 KB)

kostajh claimed this task.Oct 6 2023, 1:25 PM
gerritbot added a comment.Oct 6 2023, 1:38 PM

Change 964010 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/ReportIncident@master] form: Remove links field

https://gerrit.wikimedia.org/r/964010

gerritbot added a project: Patch-For-Review.Oct 6 2023, 1:38 PM
kostajh edited projects, added Trust and Safety Tools Team Backlog (Kanban); removed Trust and Safety Tools Team Backlog.Oct 6 2023, 1:39 PM
kostajh moved this task from 🎬 Ready to 🔍 Review/Feedback on the Trust and Safety Tools Team Backlog (Kanban) board.
gerritbot added a comment.Oct 6 2023, 2:15 PM

Change 964010 merged by jenkins-bot:

[mediawiki/extensions/ReportIncident@master] form: Remove links field

https://gerrit.wikimedia.org/r/964010

kostajh mentioned this in rEREIcf5f99f1e77a: form: Remove links field.Oct 6 2023, 2:15 PM
Maintenance_bot removed a project: Patch-For-Review.Oct 6 2023, 2:30 PM
JSengupta-WMF added a comment.Oct 6 2023, 4:47 PM

How about "Add context that could be helpful for a reviewer. You may include links that highlight the incident."?

kostajh added a comment.Oct 9 2023, 8:18 AM
In T347604#9231545, @JSengupta-WMF wrote:

How about "Add context that could be helpful for a reviewer. You may include links that highlight the incident."?

Sounds good to me. @Madalina, what do you think?

Madalina added a comment.Oct 10 2023, 12:15 PM

Sounds good to me as well.

Dreamy_Jazz moved this task from 🔍 Review/Feedback to 🐛 QA on the Trust and Safety Tools Team Backlog (Kanban) board.Oct 23 2023, 11:16 PM
Dreamy_Jazz subscribed.

Suggested QA steps specific to Patch Demo (let me know if you would like steps specific to wikis other than patch demo wikis):

  1. Create a Patch Demo wiki with the Inbox and ReportIncident extension installed
  2. Log into an account
  3. Go to Special:Preferences#mw-prefsection-personal-email
  4. Click Change or remove email address
  5. Re-login to verify your identity if prompted to do so
  6. Use the form to change the email address for the Patch Demo account to a@example.com
  7. Load Special:Inbox
  8. Click on the email with the subject similar to Patch demo ... email address confirmation
  9. Find link with that includes the text Special:ConfirmEmail and copy the entire URL
  10. Paste the URL in a new tab
  11. Open a user talk page
  12. Create the user talk page if it does not exist
  13. Click on Report in the Tools menu
  14. Navigate to step 2
  15. Verification step 1: Verify that there is no links field in the form
  16. Fill in the form with valid data, specifying a link in the Additional details field
  17. Submit the form
  18. Load Special:Inbox
  19. Click on the email from b@example.com (by clicking the link on the subject text)
  20. Verification step 2: The body of the email contains a link to the current revision of the page, does not include a specific line for the removed links field, and includes the specified link in the Additional details area of the email.

Adding links to the specific comment via a DiscussionTools integration will be done in T349570.

Dreamy_Jazz mentioned this in T349572: Update additional details placeholder to indicate that links can be included in the textarea.Oct 23 2023, 11:19 PM
In T347604#9231545, @JSengupta-WMF wrote:

How about "Add context that could be helpful for a reviewer. You may include links that highlight the incident."?

Splitting this to a new task (T349572), so this does not need to be a part of QA for this ticket.

Djackson-ctr moved this task from 🐛 QA to 🤘 Done on the Trust and Safety Tools Team Backlog (Kanban) board.Oct 25 2023, 5:26 AM
Djackson-ctr subscribed.

Using the QA Steps: I have verified the following 2 items have been implemented, and are displaying and functioning as expected at url https://patchdemo.wmflabs.org/wikis/c45087b29b/wiki/User_talk:Bob#Topic_Header_for_Report_Incident_for_English_Beta_Wiki
Good Work as always @Dreamy_Jazz, and thank you for the QA Steps!

  • Verification step 1: Verify that there is no links field in the form

image.png (908×471 px, 179 KB)

image.png (914×480 px, 201 KB)

  • Verification step 2: The body of the email contains a link to the current revision of the page, does not include a specific line for the removed links field, and includes the specified link in the Additional details area of the email.

image.png (474×1 px, 80 KB)

image.png (237×1 px, 35 KB)

image.png (644×1 px, 113 KB)

image.png (258×710 px, 25 KB)

Dreamy_Jazz mentioned this in rEREI599de9d54bbc: Update reportincident-dialog-additional-details-input-placeholder.Oct 25 2023, 11:57 AM
Dreamy_Jazz closed this task as Resolved.Oct 25 2023, 1:06 PM
Dreamy_Jazz updated the task description. (Show Details)
Tchanders subscribed.Oct 31 2023, 4:32 PM
In T347604#9274587, @Dreamy_Jazz wrote:

Suggested QA steps specific to Patch Demo (let me know if you would like steps specific to wikis other than patch demo wikis):

  1. Create a Patch Demo wiki with the Inbox and ReportIncident extension installed
  2. Log into an account
  3. Go to Special:Preferences#mw-prefsection-personal-email
  4. Click Change or remove email address
  5. Re-login to verify your identity if prompted to do so
  6. Use the form to change the email address for the Patch Demo account to a@example.com
  7. Load Special:Inbox
  8. Click on the email with the subject similar to Patch demo ... email address confirmation
  9. Find link with that includes the text Special:ConfirmEmail and copy the entire URL
  10. Paste the URL in a new tab
  11. Open a user talk page
  12. Create the user talk page if it does not exist
  13. Click on Report in the Tools menu
  14. Navigate to step 2
  15. Verification step 1: Verify that there is no links field in the form
  16. Fill in the form with valid data, specifying a link in the Additional details field
  17. Submit the form
  18. Load Special:Inbox
  19. Click on the email from b@example.com (by clicking the link on the subject text)
  20. Verification step 2: The body of the email contains a link to the current revision of the page, does not include a specific line for the removed links field, and includes the specified link in the Additional details area of the email.

Adding links to the specific comment via a DiscussionTools integration will be done in T349570.

We've updated Inbox/PatchDemo to mean that steps 3-10 should no longer be needed: https://gitlab.wikimedia.org/repos/ci-tools/patchdemo/-/merge_requests/595

I was able to log in as user Patch Demo and skip straight to adding a talk page comment and filing a report.

(I realise this task is closed, but hopefully this helps for future tests!)

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits