Page MenuHomePhabricator
Create Task
Maniphest T347682

Missing file error links to the main namespace without "File:"
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To
Fomafix
Authored By
Nardog
Sep 29 2023, 11:21 AM
Tags
Referenced Files
F41914939: T347682_Phonos_Safari_error.webm
Feb 15 2024, 6:58 PM
F41914910: 2024-02-15_09-19-21.png
Feb 15 2024, 6:58 PM
F41914906: 2024-02-15_09-17-52.png
Feb 15 2024, 6:58 PM
F40227149: 2023-10-25_12-16-25.png
Oct 25 2023, 7:39 PM
F40227064: 2023-10-25_12-16-45.png
Oct 25 2023, 7:39 PM
Subscribers
Aklapper
GMikesell-WMF
MusikAnimal
Nardog
TheDJ
TheresNoTime

Description

Steps to replicate the issue (include links if applicable):

What happens?:
"Example.oggz" in the error message is linked to https://en.wikipedia.beta.wmflabs.org/w/index.php?title=Example.oggz&action=edit&redlink=1, a nonexistent page in the main namespace.

What should have happened instead?:
"Example.oggz" in the error message is linked to https://en.wikipedia.org/wiki/Special:Upload?wpDestFile=Example.oggz, the same as the attribution link (ⓘ).

QA Results - Beta

ACStatusDetails
1✅https://phabricator.wikimedia.org/T347682 here

Details

SubjectRepoBranchLines +/-
Improve the links in the popup messagemediawiki/extensions/Phonosmaster+15 -9
Generate error messages on client sidemediawiki/extensions/Phonosmaster+62 -31
Phonos: Add plain() message for missing file uploadmediawiki/extensions/Phonosmaster+28 -13
Make function Linker::getUploadUrl publicmediawiki/coremaster+1 -1
Phonos: Fix file error linkmediawiki/extensions/Phonosmaster+30 -10
Customize query in gerrit

Related Objects

Event Timeline

Nardog created this task.Sep 29 2023, 11:21 AM
Restricted Application added a project: Community-Tech. · View Herald TranscriptSep 29 2023, 11:21 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
TheDJ subscribed.EditedSep 29 2023, 9:51 PM

Caused by:
$wikitextLink = '[[' . $options['file'] . ']]';

Nardog added a comment.Sep 30 2023, 1:15 AM

This is worse when the error is "File '...' is not an audio file", as seen here. The error is that the file type doesn't match but it looks like a missing file.

TheresNoTime claimed this task.Oct 11 2023, 12:14 PM
TheresNoTime edited projects, added Community-Tech (CommTech-Kanban); removed Community-Tech.
TheresNoTime moved this task from Ready 🎬 to In Development 💻 on the Community-Tech (CommTech-Kanban) board.
gerritbot added a comment.Oct 11 2023, 1:05 PM

Change 965152 had a related patch set uploaded (by Samtar; author: Samtar):

[mediawiki/extensions/Phonos@master] Phonos: Fix file error link

https://gerrit.wikimedia.org/r/965152

gerritbot added a project: Patch-For-Review.Oct 11 2023, 1:05 PM
TheresNoTime moved this task from In Development 💻 to Review/Feedback 💬 on the Community-Tech (CommTech-Kanban) board.Oct 11 2023, 1:23 PM
gerritbot added a comment.Oct 24 2023, 8:18 PM

Change 965152 merged by jenkins-bot:

[mediawiki/extensions/Phonos@master] Phonos: Fix file error link

https://gerrit.wikimedia.org/r/965152

MusikAnimal mentioned this in rEPHNb378b1128bba: Phonos: Fix file error link.Oct 24 2023, 8:18 PM
MusikAnimal moved this task from Review/Feedback 💬 to QA 🐛 on the Community-Tech (CommTech-Kanban) board.Oct 24 2023, 8:19 PM
Maintenance_bot removed a project: Patch-For-Review.Oct 24 2023, 8:30 PM
ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.3; 2023-10-31).Oct 24 2023, 9:00 PM
GMikesell-WMF subscribed.Oct 25 2023, 7:39 PM

@TheresNoTime Links don't match between the error message and the attribution link (ⓘ) as seen in the screenshots below.

Status: ❌Fail
Environment: Beta: 1.42.0-alpha (d5ff499)
OS: macOS Sonoma 14.0
Browser: Chrome 117
Device: MBA M2
Emulated Device:: n/a
Test Links:
https://en.wikipedia.beta.wmflabs.org/wiki/Phonos_Errors

❌AC1: https://phabricator.wikimedia.org/T348593

Error Link(ⓘ) Link
2023-10-25_12-16-45.png (1×2 px, 273 KB)
2023-10-25_12-16-25.png (1×2 px, 266 KB)
GMikesell-WMF updated the task description. (Show Details)Oct 25 2023, 7:41 PM
GMikesell-WMF moved this task from QA 🐛 to Needs Attention 👀 on the Community-Tech (CommTech-Kanban) board.
TheresNoTime added a comment.EditedOct 31 2023, 1:46 PM

@GMikesell-WMF ack, thank you — I'm going to ask for opinions on if this is desired behaviour, as afaik LinkRenderer (which creates the missing file upload link) returns HTML and the error popup just accepts wikitext (and thus renders the broken file link as just that)

@Nardog any suggestions on this? Should both the red link in the error popup and the attribution link go to the file upload page?

Nardog added a comment.EditedOct 31 2023, 6:52 PM

@Nardog any suggestions on this? Should both the red link in the error popup and the attribution link go to the file upload page?

I believe it should, in that both links should be consistent with whatever [[File:<nonexistent filename>]] yields (which currently is /wiki/Special:Upload?wpDestFile=...).

Linking to the creation of the description for a file that doesn't exist does little to help resolve the error. Even simply not linking the missing filename to anything would be an improvement, although that's obviously not desirable when the file exists but isn't audio.

TheresNoTime moved this task from Needs Attention 👀 to In Development 💻 on the Community-Tech (CommTech-Kanban) board.Nov 13 2023, 12:35 PM
gerritbot added a comment.Nov 13 2023, 1:14 PM

Change 973774 had a related patch set uploaded (by Samtar; author: Samtar):

[mediawiki/extensions/Phonos@master] Phonos: Add plain() message for missing file upload

https://gerrit.wikimedia.org/r/973774

gerritbot added a project: Patch-For-Review.Nov 13 2023, 1:14 PM
gerritbot added a comment.Nov 18 2023, 11:29 AM

Change 975395 had a related patch set uploaded (by Fomafix; author: Fomafix):

[mediawiki/extensions/Phonos@master] Remove namespace prefix in popup message

https://gerrit.wikimedia.org/r/975395

gerritbot added a comment.Nov 21 2023, 8:38 PM

Change 976309 had a related patch set uploaded (by Fomafix; author: Fomafix):

[mediawiki/core@master] Make function Linker::getUploadUrl public

https://gerrit.wikimedia.org/r/976309

gerritbot added a comment.Dec 5 2023, 5:10 PM

Change 976309 merged by jenkins-bot:

[mediawiki/core@master] Make function Linker::getUploadUrl public

https://gerrit.wikimedia.org/r/976309

gerritbot added a comment.Dec 5 2023, 5:24 PM

Change 973437 had a related patch set uploaded (by Samtar; author: Fomafix):

[mediawiki/extensions/Phonos@master] Generate error messages on client side

https://gerrit.wikimedia.org/r/973437

gerritbot added a comment.Dec 5 2023, 5:34 PM

Change 973437 merged by jenkins-bot:

[mediawiki/extensions/Phonos@master] Generate error messages on client side

https://gerrit.wikimedia.org/r/973437

gerritbot added a comment.Dec 5 2023, 5:34 PM

Change 973774 abandoned by Samtar:

[mediawiki/extensions/Phonos@master] Phonos: Add plain() message for missing file upload

Reason:

I4109a5bae4f42ad3b3767864473e49f0a2bdb677 & chain

https://gerrit.wikimedia.org/r/973774

Restricted Repository Identity mentioned this in rEPHN90b6e1775f57: Generate error messages on client side.Dec 5 2023, 5:35 PM
TheresNoTime reassigned this task from TheresNoTime to Fomafix.Dec 5 2023, 5:40 PM
TheresNoTime subscribed.
ReleaseTaggerBot edited projects, added MW-1.42-notes (1.42.0-wmf.9; 2023-12-12); removed MW-1.42-notes (1.42.0-wmf.3; 2023-10-31).Dec 5 2023, 7:00 PM
gerritbot added a comment.Feb 15 2024, 3:36 AM

Change 975395 merged by jenkins-bot:

[mediawiki/extensions/Phonos@master] Improve the links in the popup message

https://gerrit.wikimedia.org/r/975395

Fomafix mentioned this in rEPHN393596de9a28: Improve the links in the popup message.Feb 15 2024, 3:36 AM
ReleaseTaggerBot edited projects, added MW-1.42-notes (1.42.0-wmf.19; 2024-02-20); removed MW-1.42-notes (1.42.0-wmf.9; 2023-12-12).Feb 15 2024, 4:00 AM
Maintenance_bot removed a project: Patch-For-Review.Feb 15 2024, 4:30 AM
MusikAnimal moved this task from In Development 💻 to QA 🐛 on the Community-Tech (CommTech-Kanban) board.Feb 15 2024, 4:41 PM
GMikesell-WMF added a comment.Feb 15 2024, 6:58 PM

@TheresNoTime Links now do match between the error message and the attribution link (ⓘ) as seen in the screenshots below. How come Safari does not show links at all compared to Chrome/Firefox/Edge as seen in the .webm? If you want me to create a separate task, just let me know, otherwise I'm moving this to Done since the links do match. Thanks for all your work!

Status: ✅ PASS
Environment: Beta: 1.42.0-alpha (6e1bca9)
OS: macOS Sonoma 14.3
Browser: Chrome 121, Firefox 123, Safari 17.3, Edge 121
Device: MBA M2
Emulated Device:: n/a
Test Links:
https://en.wikipedia.beta.wmflabs.org/wiki/Phonos_Errors

✅AC1: https://phabricator.wikimedia.org/T347682

Chrome/Edge/Firefox

Error Link(ⓘ) Link
2024-02-15_09-17-52.png (1×2 px, 232 KB)
2024-02-15_09-19-21.png (1×2 px, 230 KB)

Safari Error- Shows Chrome first then Safari after

GMikesell-WMF updated the task description. (Show Details)Feb 15 2024, 7:00 PM
GMikesell-WMF moved this task from QA 🐛 to Done 🏁 on the Community-Tech (CommTech-Kanban) board.
MusikAnimal closed this task as Resolved.Feb 15 2024, 7:57 PM
MusikAnimal subscribed.

Thanks @Fomafix! Resolving

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL