Maniphest T348091

[Sub Task] Add find and replace functionality to NativeEditor toolbar
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Seddon
	Oct 4 2023, 2:28 AM

Tags

Referenced Files

None

Subscribers

Description

Goal:
Add find & replace functionality

Requirements:

Mocks
Figma

Testing Notes
Please test find and replace function on native editor.

Engineering note

Old prototype work here in app > native-editor-prototype branch

Replace not prototyped

Special attention to “fix scrolling during find” commit should improve some scrolling bugs we saw here.

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Open		None	T344258 [Main Epic] 2023-2024 Enhancements to Editing on the iOS app
		Open		None	T344282 [Sub Epic] Make the iOS editor native
		Resolved		JTannerWMF	T347928 [Task] Add formatting options to NativeEditor tool bar
		Resolved		JTannerWMF	T348091 [Sub Task] Add find and replace functionality to NativeEditor toolbar

Event Timeline

Seddon created this task.Oct 4 2023, 2:28 AM

Seddon moved this task from Needs Triage to Engineering Backlog on the Wikipedia-iOS-App-Backlog board.Oct 13 2023, 12:14 PM

Seddon triaged this task as Low priority.Oct 13 2023, 2:10 PM

Tsevener claimed this task.Jan 17 2024, 5:14 PM

Tsevener added a project: iOS Release FY2023-24 (Archive).

Tsevener moved this task from Tasks from Product Backlog to Doing on the iOS Release FY2023-24 (Archive) board.

Part 1 (find) - https://github.com/wikimedia/wikipedia-ios/pull/4715
Part 2 (replace) - https://github.com/wikimedia/wikipedia-ios/pull/4716

@JTannerWMF FYI, I'm changing the priority of all the native editor tasks to "Medium".

Tsevener moved this task from Doing to Needs Code Review on the iOS Release FY2023-24 (Archive) board.Jan 19 2024, 9:30 PM

Tsevener removed Tsevener as the assignee of this task.Jan 22 2024, 4:35 PM

Tsevener moved this task from Needs Code Review to Needs Design Review on the iOS Release FY2023-24 (Archive) board.

Tsevener subscribed.

OTichonova moved this task from Needs Design Review to Needs Code Review on the iOS Release FY2023-24 (Archive) board.Jan 23 2024, 3:13 PM

Tsevener moved this task from Needs Code Review to Waiting for Build on the iOS Release FY2023-24 (Archive) board.Jan 23 2024, 5:55 PM

Tsevener updated the task description. (Show Details)Feb 2 2024, 12:03 AM

Tsevener moved this task from Waiting for Build to Needs QA on the iOS Release FY2023-24 (Archive) board.

Tsevener updated the task description. (Show Details)Feb 2 2024, 12:26 AM

Works for me on 7.4.7 (3152)

Tsevener mentioned this in T356461: Release 7.4.7.Feb 12 2024, 9:44 PM

JTannerWMF moved this task from Ready for PM Signoff to Ready for Release on the iOS Release FY2023-24 (Archive) board.Feb 13 2024, 12:03 AM

JTannerWMF closed this task as Resolved.Feb 13 2024, 8:57 PM

JTannerWMF claimed this task.