Page MenuHomePhabricator
Create Task
Maniphest T348181

TypeError: Argument 1 passed to Wikibase\Search\Elastic\CirrusShowSearchHitHandler::newFromGlobalState() must implement interface IContextSource, instance of MediaWiki\Config\GlobalVarConfig given, called in /srv/mediawiki/php-
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error
labels.normalized_message
[{reqId}] {exception_url}   TypeError: Argument 1 passed to Wikibase\Search\Elastic\CirrusShowSearchHitHandler::newFromGlobalState() must implement interface IContextSource, instance of MediaWiki\Config\GlobalVarConfig given, called in /srv/mediawiki/php-
error.stack_trace
from /srv/mediawiki/php-1.41.0-wmf.29/extensions/WikibaseCirrusSearch/src/CirrusShowSearchHitHandler.php(57)
#0 /srv/mediawiki/php-1.41.0-wmf.29/vendor/wikimedia/object-factory/src/ObjectFactory.php(227): Wikibase\Search\Elastic\CirrusShowSearchHitHandler::newFromGlobalState(MediaWiki\Config\GlobalVarConfig)
#1 /srv/mediawiki/php-1.41.0-wmf.29/vendor/wikimedia/object-factory/src/ObjectFactory.php(149): Wikimedia\ObjectFactory\ObjectFactory::getObjectFromSpec(array, array)
#2 /srv/mediawiki/php-1.41.0-wmf.29/includes/HookContainer/HookContainer.php(258): Wikimedia\ObjectFactory\ObjectFactory->createObject(array)
#3 /srv/mediawiki/php-1.41.0-wmf.29/includes/HookContainer/HookContainer.php(350): MediaWiki\HookContainer\HookContainer->makeExtensionHandlerCallback(string, array, array)
#4 /srv/mediawiki/php-1.41.0-wmf.29/includes/HookContainer/HookContainer.php(525): MediaWiki\HookContainer\HookContainer->normalizeHandler(string, array, array)
#5 /srv/mediawiki/php-1.41.0-wmf.29/includes/HookContainer/HookContainer.php(148): MediaWiki\HookContainer\HookContainer->getHandlers(string, array)
#6 /srv/mediawiki/php-1.41.0-wmf.29/includes/HookContainer/HookRunner.php(3474): MediaWiki\HookContainer\HookContainer->run(string, array)
#7 /srv/mediawiki/php-1.41.0-wmf.29/includes/search/searchwidgets/FullSearchResultWidget.php(189): MediaWiki\HookContainer\HookRunner->onShowSearchHitTitle(MediaWiki\Title\Title, HtmlArmor, Wikibase\Search\Elastic\EntityResult, array, MediaWiki\Specials\SpecialSearch, array, array)
#8 /srv/mediawiki/php-1.41.0-wmf.29/includes/search/searchwidgets/FullSearchResultWidget.php(76): MediaWiki\Search\SearchWidgets\FullSearchResultWidget->generateMainLinkHtml(Wikibase\Search\Elastic\EntityResult, integer)
#9 /srv/mediawiki/php-1.41.0-wmf.29/includes/search/searchwidgets/BasicSearchResultSetWidget.php(131): MediaWiki\Search\SearchWidgets\FullSearchResultWidget->render(Wikibase\Search\Elastic\EntityResult, integer)
#10 /srv/mediawiki/php-1.41.0-wmf.29/includes/search/searchwidgets/BasicSearchResultSetWidget.php(73): MediaWiki\Search\SearchWidgets\BasicSearchResultSetWidget->renderResultSet(Wikibase\Search\Elastic\EntityResultSet, integer)
#11 /srv/mediawiki/php-1.41.0-wmf.29/includes/specials/SpecialSearch.php(582): MediaWiki\Search\SearchWidgets\BasicSearchResultSetWidget->render(string, integer, NULL, Wikibase\Search\Elastic\EntityResultSet)
#12 /srv/mediawiki/php-1.41.0-wmf.29/includes/specials/SpecialSearch.php(248): MediaWiki\Specials\SpecialSearch->showResults(string)
#13 /srv/mediawiki/php-1.41.0-wmf.29/includes/specialpage/SpecialPage.php(727): MediaWiki\Specials\SpecialSearch->execute(NULL)
#14 /srv/mediawiki/php-1.41.0-wmf.29/includes/specialpage/SpecialPageFactory.php(1623): MediaWiki\SpecialPage\SpecialPage->run(NULL)
#15 /srv/mediawiki/php-1.41.0-wmf.29/includes/MediaWiki.php(357): MediaWiki\SpecialPage\SpecialPageFactory->executePath(string, RequestContext)
#16 /srv/mediawiki/php-1.41.0-wmf.29/includes/MediaWiki.php(961): MediaWiki->performRequest()
#17 /srv/mediawiki/php-1.41.0-wmf.29/includes/MediaWiki.php(614): MediaWiki->main()
#18 /srv/mediawiki/php-1.41.0-wmf.29/index.php(50): MediaWiki->run()
#19 /srv/mediawiki/php-1.41.0-wmf.29/index.php(46): wfIndexMain()
#20 /srv/mediawiki/w/index.php(3): require(string)
#21 {main}
Impact

Noticed during group1 promotion. High error rate.

Notes

Details

Request URL
https://www.wikidata.org/w/index.php?ns0=*&search=*
SubjectRepoBranchLines +/-
Revert "Use HookHandlers for core hooks"mediawiki/extensions/WikibaseCirrusSearchwmf/1.41.0-wmf.29+39 -53
Revert "Use HookHandlers for core hooks"mediawiki/extensions/WikibaseCirrusSearchmaster+39 -53
Fix factory for CirrusShowSearchHitHandlermediawiki/extensions/WikibaseCirrusSearchmaster+18 -24
Customize query in gerrit

Related Objects
Search...

Event Timeline

dduvall triaged this task as Unbreak Now! priority.Oct 4 2023, 6:17 PM
dduvall created this task.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 4 2023, 6:17 PM
dduvall added a parent task: T347080: 1.41.0-wmf.29 deployment blockers.Oct 4 2023, 6:19 PM
dduvall added a project: CirrusSearch.
Restricted Application added a project: Discovery-Search. · View Herald TranscriptOct 4 2023, 6:19 PM
brennen subscribed.Oct 4 2023, 6:54 PM
Novem_Linguae subscribed.Oct 4 2023, 7:01 PM
Umherirrender subscribed.EditedOct 4 2023, 7:57 PM

You can revert the corresponding change https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikibaseCirrusSearch/+/962177

gerritbot added a comment.Oct 4 2023, 8:00 PM

Change 963405 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/WikibaseCirrusSearch@master] Fix factory for CirrusShowSearchHitHandler

https://gerrit.wikimedia.org/r/963405

gerritbot added a project: Patch-For-Review.Oct 4 2023, 8:00 PM
brennen added a comment.Oct 4 2023, 9:46 PM

@Umherirrender for clarity, should we just revert https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikibaseCirrusSearch/+/962177 on wmf.29, rather than wait for review on the followup fix?

jeena subscribed.Oct 4 2023, 10:04 PM
gerritbot added a comment.Oct 5 2023, 6:13 AM

Change 963353 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/WikibaseCirrusSearch@master] Revert "Use HookHandlers for core hooks"

https://gerrit.wikimedia.org/r/963353

gerritbot added a comment.Oct 5 2023, 6:14 AM

Change 963354 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/WikibaseCirrusSearch@wmf/1.41.0-wmf.29] Revert "Use HookHandlers for core hooks"

https://gerrit.wikimedia.org/r/963354

gerritbot added a comment.Oct 5 2023, 6:14 AM

Change 963405 abandoned by Umherirrender:

[mediawiki/extensions/WikibaseCirrusSearch@master] Fix factory for CirrusShowSearchHitHandler

Reason:

Going with the revert - Id3efdb5bd658d2c00889706701069d28b4b7501e

https://gerrit.wikimedia.org/r/963405

Umherirrender added a comment.Oct 5 2023, 6:16 AM
In T348181#9226698, @brennen wrote:

@Umherirrender for clarity, should we just revert https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikibaseCirrusSearch/+/962177 on wmf.29, rather than wait for review on the followup fix?

I have written the sentence to clarify that a revert is possible, when the failure is a big problem and a fast fix is needed.
But it seems better to go with the revert for now (also in master) and convert the hooks later.

I have created the necessary patch sets.

gerritbot added a comment.Oct 5 2023, 1:20 PM

Change 963353 merged by jenkins-bot:

[mediawiki/extensions/WikibaseCirrusSearch@master] Revert "Use HookHandlers for core hooks"

https://gerrit.wikimedia.org/r/963353

gerritbot added a comment.Oct 5 2023, 2:07 PM

Change 963354 merged by jenkins-bot:

[mediawiki/extensions/WikibaseCirrusSearch@wmf/1.41.0-wmf.29] Revert "Use HookHandlers for core hooks"

https://gerrit.wikimedia.org/r/963354

Stashbot added a comment.Oct 5 2023, 2:08 PM

Mentioned in SAL (#wikimedia-operations) [2023-10-05T14:08:12Z] <lucaswerkmeister-wmde@deploy2002> Started scap: Backport for [[gerrit:963354|Revert "Use HookHandlers for core hooks" (T348181)]]

Stashbot added a comment.Oct 5 2023, 2:09 PM

Mentioned in SAL (#wikimedia-operations) [2023-10-05T14:09:37Z] <lucaswerkmeister-wmde@deploy2002> umherirrender and lucaswerkmeister-wmde: Backport for [[gerrit:963354|Revert "Use HookHandlers for core hooks" (T348181)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Lucas_Werkmeister_WMDE subscribed.Oct 5 2023, 2:10 PM
Maintenance_bot removed a project: Patch-For-Review.Oct 5 2023, 2:10 PM
Stashbot added a comment.Oct 5 2023, 2:17 PM

Mentioned in SAL (#wikimedia-operations) [2023-10-05T14:17:08Z] <lucaswerkmeister-wmde@deploy2002> Finished scap: Backport for [[gerrit:963354|Revert "Use HookHandlers for core hooks" (T348181)]] (duration: 08m 50s)

Lucas_Werkmeister_WMDE closed this task as Resolved.Oct 5 2023, 2:18 PM
Lucas_Werkmeister_WMDE lowered the priority of this task from Unbreak Now! to High.

Should be fixed now.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL