Page MenuHomePhabricator
Create Task
Maniphest T349055

User rights: Users can run functions
Closed, ResolvedPublic
Actions

Description

Description

  • Set wikilambda-execute to true for all users (even not logged-in users) (remove corePermissions override)
  • Enable "Run Function" button in FunctionEvaluator.vue component for logged-out users

Completion checklist

Details

SubjectRepoBranchLines +/-
Allow logged out users to run FunctionEvaluator widgetmediawiki/extensions/WikiLambdawmf/1.42.0-wmf.1+276 -29
[wikifunctions] Allow logged-out users to run approved functionsoperations/mediawiki-configmaster+6 -2
Allow logged out users to run FunctionEvaluator widgetmediawiki/extensions/WikiLambdamaster+276 -29
Customize query in gerrit

Related Objects
Search...

Event Timeline

gengh created this task.Oct 17 2023, 6:22 AM
gengh mentioned this in T349054: Adjust and improve Wikifunctions user rights grants for General Availability.
gengh removed projects: function-schemata, function-evaluator, function-orchestrator.Oct 17 2023, 6:55 AM
Jdforrester-WMF added a parent task: T349054: Adjust and improve Wikifunctions user rights grants for General Availability.Oct 17 2023, 2:05 PM
gerritbot added a comment.Oct 17 2023, 4:14 PM

Change 966570 had a related patch set uploaded (by Jforrester; author: Jforrester):

[operations/mediawiki-config@master] [wikifunctions] Alter site to General Availability

https://gerrit.wikimedia.org/r/966570

gerritbot added a project: Patch-For-Review.Oct 17 2023, 4:14 PM
gengh claimed this task.Oct 18 2023, 11:21 AM
gerritbot added a comment.Oct 19 2023, 2:40 PM

Change 967224 had a related patch set uploaded (by Genoveva Galarza; author: Genoveva Galarza):

[mediawiki/extensions/WikiLambda@master] Allow logged out users to run FunctionEvaluator widget

https://gerrit.wikimedia.org/r/967224

Jdforrester-WMF changed the task status from Open to In Progress.Oct 19 2023, 4:39 PM
Jdforrester-WMF triaged this task as High priority.
Jdforrester-WMF moved this task from To triage to In Progress on the Abstract Wikipedia team board.
gerritbot added a comment.Oct 20 2023, 1:27 PM

Change 967224 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Allow logged out users to run FunctionEvaluator widget

https://gerrit.wikimedia.org/r/967224

Jdforrester-WMF mentioned this in T349354: [wmf.1] wikilambda-zerror displayed for logged in users when running Implementation .Oct 20 2023, 1:31 PM
Jdforrester-WMF merged a task: T349354: [wmf.1] wikilambda-zerror displayed for logged in users when running Implementation .
Jdforrester-WMF moved this task from In Progress to To deploy on the Abstract Wikipedia team board.
Jdforrester-WMF added subscribers: Etonkovidova, Jdforrester-WMF, • CCoxwell-WMF, Jdforrester-PERSONAL.
gerritbot added a comment.Oct 24 2023, 10:15 PM

Change 968362 had a related patch set uploaded (by Jforrester; author: Jforrester):

[operations/mediawiki-config@master] [wikifunctions] Allow logged-out users to run approved functions

https://gerrit.wikimedia.org/r/968362

gerritbot added a comment.Oct 25 2023, 1:12 PM

Change 968362 merged by jenkins-bot:

[operations/mediawiki-config@master] [wikifunctions] Allow logged-out users to run approved functions

https://gerrit.wikimedia.org/r/968362

Stashbot added a comment.Oct 25 2023, 1:13 PM

Mentioned in SAL (#wikimedia-operations) [2023-10-25T13:13:21Z] <jforrester@deploy2002> Started scap: Backport for [[gerrit:968362|[wikifunctions] Allow logged-out users to run approved functions (T349055)]]

Stashbot added a comment.Oct 25 2023, 1:14 PM

Mentioned in SAL (#wikimedia-operations) [2023-10-25T13:14:43Z] <jforrester@deploy2002> jforrester: Backport for [[gerrit:968362|[wikifunctions] Allow logged-out users to run approved functions (T349055)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

gerritbot added a comment.Oct 25 2023, 1:16 PM

Change 968319 had a related patch set uploaded (by Jforrester; author: Genoveva Galarza):

[mediawiki/extensions/WikiLambda@wmf/1.42.0-wmf.1] Allow logged out users to run FunctionEvaluator widget

https://gerrit.wikimedia.org/r/968319

Stashbot added a comment.Oct 25 2023, 1:21 PM

Mentioned in SAL (#wikimedia-operations) [2023-10-25T13:21:21Z] <jforrester@deploy2002> Finished scap: Backport for [[gerrit:968362|[wikifunctions] Allow logged-out users to run approved functions (T349055)]] (duration: 07m 59s)

gerritbot added a comment.Oct 25 2023, 1:34 PM

Change 968319 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@wmf/1.42.0-wmf.1] Allow logged out users to run FunctionEvaluator widget

https://gerrit.wikimedia.org/r/968319

Stashbot mentioned this in T349057: User rights: Users can run unsaved code on the implementation page.Oct 25 2023, 1:35 PM
Stashbot mentioned this in T301670: Create a placeholder Roles module in Vuex ahead of future role work.

Mentioned in SAL (#wikimedia-operations) [2023-10-25T13:34:59Z] <jforrester@deploy2002> Started scap: Backport for [[gerrit:968319|Allow logged out users to run FunctionEvaluator widget (T301670 T349055 T349057)]]

Jdforrester-WMF added a project: MW-1.42-notes (1.42.0-wmf.1; 2023-10-17).Oct 25 2023, 1:38 PM
Jdforrester-WMF moved this task from To deploy to Verify in production on the Abstract Wikipedia team board.
Stashbot added a comment.Oct 25 2023, 1:53 PM

Mentioned in SAL (#wikimedia-operations) [2023-10-25T13:53:56Z] <jforrester@deploy2002> jforrester: Backport for [[gerrit:968319|Allow logged out users to run FunctionEvaluator widget (T301670 T349055 T349057)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Stashbot added a comment.Oct 25 2023, 2:30 PM

Mentioned in SAL (#wikimedia-operations) [2023-10-25T14:30:10Z] <jforrester@deploy2002> sync-world aborted: Backport for [[gerrit:968319|Allow logged out users to run FunctionEvaluator widget (T301670 T349055 T349057)]] (duration: 55m 10s)

Jdforrester-WMF removed a project: Patch-For-Review.Oct 30 2023, 4:11 PM
Etonkovidova updated the task description. (Show Details)Nov 2 2023, 8:45 PM
Etonkovidova closed this task as Resolved.Nov 2 2023, 8:50 PM

Checked on wikifunctions wmf.3 - works as expected.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits