Page MenuHomePhabricator
Create Task
Maniphest T349366

Remove unused NewPagesFeed code following Vue.js migration
Closed, ResolvedPublic
Actions

Description

Now that we have deployed the new NewPagesFeed implementation, using vue.js, we can remove the old unusued code.

Note the folder changes in T342323 which may help localise the code requiring removal.

  • move images from modules/ext.pageTriage.views.newPagesFeed/images/ to modules/ext.pageTriage.newPagesFeed.vue/images/ (or similar), and update all places these images are referenced (gerrit:973426)
  • remove feature flag pagetriage_ui (gerrit:990372)
  • delete modules/ext.pageTriage.views.newPagesFeed/(gerrit:990373)
  • rename modules/ext.pageTriage.newPagesFeed.vue/ to modules/ext.pageTriage.newPagesFeed/ (no .vue), and update all places these paths are referenced (gerrit:990426)

Details

SubjectRepoBranchLines +/-
Rename the modules/ext.pageTriage.newPagesFeed.vue/ directorymediawiki/extensions/PageTriagemaster+43 -43
Remove a redundant test casemediawiki/extensions/PageTriagemaster+0 -15
Remove pagetriage_ui feature flagmediawiki/extensions/PageTriagemaster+3 -15
Delete the modules/ext.pageTriage.views.newPagesFeed directorymediawiki/extensions/PageTriagemaster+0 -2 K
Code cleanup after Vue.js migrationmediawiki/extensions/PageTriagemaster+44 -1 K
Move images out of folder that will be deleted soonmediawiki/extensions/PageTriagemaster+12 -12
Customize query in gerrit

Related Objects
Search...

Event Timeline

Samwalton9-WMF created this task.Oct 20 2023, 10:05 AM
Samwalton9-WMF added a parent task: T348541: [Epic] Q2 FY 2023-24 Moderator Tools Maintenance Work.
Novem_Linguae added a comment.Oct 20 2023, 10:11 AM

Looks like the Vue Page Curation toolbar uses pagetriage_tb, so should be safe to remove pagetriage_ui.

Samwalton9-WMF moved this task from Backlog to Vue migration bugs on the PageTriage board.Oct 20 2023, 3:37 PM
Novem_Linguae updated the task description. (Show Details)Oct 21 2023, 8:16 PM
Novem_Linguae updated the task description. (Show Details)
Novem_Linguae updated the task description. (Show Details)Oct 21 2023, 8:23 PM
gerritbot added a comment.Nov 12 2023, 2:14 PM

Change 973426 had a related patch set uploaded (by Punith.nyk; author: Punith.nyk):

[mediawiki/extensions/PageTriage@master] move images from modules/ext.pageTriage.views.newPagesFeed/images/ to modules/ext.pageTriage.newPagesFeed.vue/images/ (or similar), and update all places these images are referenced

https://gerrit.wikimedia.org/r/973426

gerritbot added a project: Patch-For-Review.Nov 12 2023, 2:14 PM
Samwalton9-WMF assigned this task to Punith.nyk.Nov 27 2023, 2:05 PM
Samwalton9-WMF edited projects, added Moderator-Tools-Team (Kanban); removed Moderator-Tools-Team.
Samwalton9-WMF moved this task from Ready to Eng review on the Moderator-Tools-Team (Kanban) board.
MPGuy2824 changed the task status from Open to In Progress.Dec 1 2023, 3:23 AM
MPGuy2824 updated the task description. (Show Details)
MPGuy2824 moved this task from Vue migration bugs to Code Review on the PageTriage board.
gerritbot added a comment.Dec 4 2023, 9:44 PM

Change 973426 merged by jenkins-bot:

[mediawiki/extensions/PageTriage@master] Move images out of folder that will be deleted soon

https://gerrit.wikimedia.org/r/973426

Maintenance_bot removed a project: Patch-For-Review.Dec 4 2023, 10:10 PM
ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.9; 2023-12-12).Dec 4 2023, 11:00 PM
Scardenasmolinar updated the task description. (Show Details)Dec 5 2023, 12:03 AM
Scardenasmolinar moved this task from Eng review to Ready on the Moderator-Tools-Team (Kanban) board.Dec 5 2023, 12:06 AM
Scardenasmolinar moved this task from Code Review to Waiting for enwiki deploy on the PageTriage board.
HouseBlaster moved this task from Unsorted to Needs removal on the Technical-Debt board.Dec 8 2023, 6:02 PM
MPGuy2824 moved this task from Waiting for enwiki deploy to Vue migration bugs on the PageTriage board.Dec 15 2023, 4:31 AM
gerritbot added a comment.Dec 20 2023, 7:17 AM

Change 984326 had a related patch set uploaded (by MPGuy2824; author: MPGuy2824):

[mediawiki/extensions/PageTriage@master] Code cleanup after Vue.js migration

https://gerrit.wikimedia.org/r/984326

gerritbot added a project: Patch-For-Review.Dec 20 2023, 7:17 AM
MPGuy2824 moved this task from Vue migration bugs to Code Review on the PageTriage board.Dec 20 2023, 7:19 AM
MPGuy2824 subscribed.

Patchdemo wiki: https://patchdemo.wmflabs.org/wikis/391be8fa41

MPGuy2824 moved this task from Ready to Eng review on the Moderator-Tools-Team (Kanban) board.Dec 20 2023, 7:20 AM
gerritbot added a comment.Jan 14 2024, 6:02 AM

Change 990372 had a related patch set uploaded (by MPGuy2824; author: MPGuy2824):

[mediawiki/extensions/PageTriage@master] Remove pagetriage_ui feature flag

https://gerrit.wikimedia.org/r/990372

gerritbot added a comment.Jan 14 2024, 6:11 AM

Change 984326 abandoned by MPGuy2824:

[mediawiki/extensions/PageTriage@master] Code cleanup after Vue.js migration

Reason:

Abandoning this patch in favor of 3 smaller patches. The first one is at https://gerrit.wikimedia.org/r/c/mediawiki/extensions/PageTriage/+/990372

https://gerrit.wikimedia.org/r/984326

gerritbot added a comment.Jan 14 2024, 6:52 AM

Change 990373 had a related patch set uploaded (by MPGuy2824; author: MPGuy2824):

[mediawiki/extensions/PageTriage@master] Delete the modules/ext.pageTriage.views.newPagesFeed directory

https://gerrit.wikimedia.org/r/990373

MPGuy2824 updated the task description. (Show Details)Jan 14 2024, 7:46 AM
gerritbot added a comment.Jan 14 2024, 6:16 PM

Change 990372 merged by jenkins-bot:

[mediawiki/extensions/PageTriage@master] Remove pagetriage_ui feature flag

https://gerrit.wikimedia.org/r/990372

gerritbot added a comment.Jan 14 2024, 6:16 PM

Change 990373 merged by jenkins-bot:

[mediawiki/extensions/PageTriage@master] Delete the modules/ext.pageTriage.views.newPagesFeed directory

https://gerrit.wikimedia.org/r/990373

Maintenance_bot removed a project: Patch-For-Review.Jan 14 2024, 6:30 PM
ReleaseTaggerBot edited projects, added MW-1.42-notes (1.42.0-wmf.14; 2024-01-16); removed MW-1.42-notes (1.42.0-wmf.9; 2023-12-12).Jan 14 2024, 7:00 PM
gerritbot added a comment.Jan 15 2024, 2:52 AM

Change 990426 had a related patch set uploaded (by MPGuy2824; author: MPGuy2824):

[mediawiki/extensions/PageTriage@master] Rename the modules/ext.pageTriage.newPagesFeed.vue/ directory

https://gerrit.wikimedia.org/r/990426

gerritbot added a project: Patch-For-Review.Jan 15 2024, 2:52 AM
gerritbot added a comment.Jan 15 2024, 2:57 AM

Change 990427 had a related patch set uploaded (by MPGuy2824; author: MPGuy2824):

[mediawiki/extensions/PageTriage@master] Remove a redundant test case

https://gerrit.wikimedia.org/r/990427

MPGuy2824 updated the task description. (Show Details)Jan 15 2024, 3:13 AM
gerritbot added a comment.Jan 15 2024, 3:37 AM

Change 990427 merged by jenkins-bot:

[mediawiki/extensions/PageTriage@master] Remove a redundant test case

https://gerrit.wikimedia.org/r/990427

MPGuy2824 changed the subtype of this task from "Task" to "Bug Report".Jan 15 2024, 4:15 AM
MPGuy2824 changed the subtype of this task from "Bug Report" to "Task".
gerritbot added a comment.Jan 17 2024, 2:56 PM

Change 990426 merged by jenkins-bot:

[mediawiki/extensions/PageTriage@master] Rename the modules/ext.pageTriage.newPagesFeed.vue/ directory

https://gerrit.wikimedia.org/r/990426

Novem_Linguae updated the task description. (Show Details)Jan 17 2024, 3:01 PM
Maintenance_bot removed a project: Patch-For-Review.Jan 17 2024, 3:31 PM
ReleaseTaggerBot edited projects, added MW-1.42-notes (1.42.0-wmf.15; 2024-01-23); removed MW-1.42-notes (1.42.0-wmf.14; 2024-01-16).Jan 17 2024, 4:00 PM
MPGuy2824 closed this task as Resolved.Jan 18 2024, 10:39 AM
MPGuy2824 moved this task from Code Review to Done on the PageTriage board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits