Page MenuHomePhabricator

Display IPInfo for a temporary account on a new SpecialPage
Closed, ResolvedPublic

Description

This task is for showing information for the all the IP addresses known to be used by the temp account, on a new special page

From the parent task:

A new special page that shows tabulated IP data for a temporary user. This page will be linked from the accordion on the Contributions page. This would be a default MediaWiki table with sorting on IP addresses. There will be no pagination (see note #1) but we will show the maximum records possible (500? 1000?).

image.png (914×2 px, 444 KB)
image.png (720×2 px, 393 KB)
With Show IP button for those have access to view IPsNo 'Show IP' button

Notes:

  • Only users with the IP Info rights should be able to access this page. Based on if they have Basic or Full access the number of columns will change.
  • Apart from the IP information we receive from Spur, we’ll add another column “Edits made using this IP” to show which IP was used most often.
  • Users with IP Reveal rights will see an extra column on the left where they can reveal an IP on a row.

Link to help page from this special page: https://meta.wikimedia.org/wiki/IP_Editing:_Privacy_Enhancement_and_Abuse_Mitigation/IP_Info_feature (for now, may change later)

Design note: If possible, implement using Codex table styling.

Event Timeline

@Tchanders if we complete T349715: Show IPInfo infobox on Special:Contributions for temporary accounts, do we also need to do this task? I am unsure why we'd need a separate special page for this.

@Tchanders if we complete T349715: Show IPInfo infobox on Special:Contributions for temporary accounts, do we also need to do this task? I am unsure why we'd need a separate special page for this.

(Discussed in person, but for anyone else reading this...)

T349715: Show IPInfo infobox on Special:Contributions for temporary accounts only shows information for one IP address, whereas this task is for displaying information about all known IP addresses.

As discussed in our engineering meeting, the designs are quite old, and we've heard a lot since from volunteers about preferring to see information inline. We should talk to @KColeman-WMF about revisiting the designs before we go ahead with this.

Update: Per a discussion with the stewards over Discord it seems like the table designs Prateek sketched out still make sense. There were no objections to using them. This task is good to go!

Thanks for the update!

I wanted to add that if we are creating a new page and implementing a table without pagination, then we should be able to use Codex table rather than OOUI (the older design is displaying OOUI table).

mszabo changed the task status from Open to In Progress.Sep 2 2024, 8:40 PM

Change #1070659 had a related patch set uploaded (by Máté Szabó; author: Máté Szabó):

[mediawiki/extensions/IPInfo@master] Add method to retrieve distinct IPs used by a temp user

https://gerrit.wikimedia.org/r/1070659

Change #1070918 had a related patch set uploaded (by Máté Szabó; author: Máté Szabó):

[mediawiki/extensions/IPInfo@master] Add batch retrieval method to InfoRetriever

https://gerrit.wikimedia.org/r/1070918

Change #1071033 had a related patch set uploaded (by Máté Szabó; author: Máté Szabó):

[mediawiki/extensions/IPInfo@master] Implement batch retrieval for IPoidInfoRetriever

https://gerrit.wikimedia.org/r/1071033

Change #1071217 had a related patch set uploaded (by Máté Szabó; author: Máté Szabó):

[mediawiki/extensions/IPInfo@master] Add batch retrieval method to InfoManager

https://gerrit.wikimedia.org/r/1071217

Change #1071220 had a related patch set uploaded (by Máté Szabó; author: Máté Szabó):

[mediawiki/extensions/IPInfo@master] Allow fetching info from a subset of InfoRetrievers

https://gerrit.wikimedia.org/r/1071220

Change #1070918 merged by jenkins-bot:

[mediawiki/extensions/IPInfo@master] Add batch retrieval method to InfoRetriever

https://gerrit.wikimedia.org/r/1070918

Change #1071033 merged by jenkins-bot:

[mediawiki/extensions/IPInfo@master] Implement batch retrieval for IPoidInfoRetriever

https://gerrit.wikimedia.org/r/1071033

Change #1071217 merged by jenkins-bot:

[mediawiki/extensions/IPInfo@master] Add batch retrieval method to InfoManager

https://gerrit.wikimedia.org/r/1071217

Change #1071220 merged by jenkins-bot:

[mediawiki/extensions/IPInfo@master] Allow fetching info from a subset of InfoRetrievers

https://gerrit.wikimedia.org/r/1071220

Change #1072732 had a related patch set uploaded (by Máté Szabó; author: Máté Szabó):

[mediawiki/extensions/IPInfo@master] Add Special:IPInfo

https://gerrit.wikimedia.org/r/1072732

Change #1074132 had a related patch set uploaded (by Máté Szabó; author: Máté Szabó):

[mediawiki/extensions/IPInfo@master] Check IPoid configuration before batch queries

https://gerrit.wikimedia.org/r/1074132

@KColeman-WMF @mszabo should we have a (sortable) column for timestamp, so it's easy to see the IPs in order of use?

I'm also curious if anyone will actually make use of the sorting ability on the table -- maybe it's better to leave it out, to reduce noise?

I'm also wondering if we can do something for the width of this table. I found it to not really be very usable with a single row, because half of the information is hidden behind a scrollbar. I imagine that once you have several rows of data, it will become even trickier to make sense of.

ip info.gif (730×1 px, 95 KB)

@kostajh wrote:

I'm also wondering if we can do something for the width of this table. I found it to not really be very usable with a single row, because half of the information is hidden behind a scrollbar. I imagine that once you have several rows of data, it will become even trickier to make sense of.

ip info.gif (730×1 px, 95 KB)

I agree we want to keep horizontal scroll to a minimum. @mszabo do you think we can reduce the widths on some of the columns (especially ones with shorter descriptions like Version)? In the original design it looks like they are tighter widths.

Change #1070659 merged by jenkins-bot:

[mediawiki/extensions/IPInfo@master] Add method to retrieve distinct IPs used by a temp user

https://gerrit.wikimedia.org/r/1070659

Change #1074132 merged by jenkins-bot:

[mediawiki/extensions/IPInfo@master] Check IPoid configuration before batch queries

https://gerrit.wikimedia.org/r/1074132

Change #1072732 merged by jenkins-bot:

[mediawiki/extensions/IPInfo@master] Add Special:IPInfo

https://gerrit.wikimedia.org/r/1072732

@kostajh wrote:

I'm also wondering if we can do something for the width of this table. I found it to not really be very usable with a single row, because half of the information is hidden behind a scrollbar. I imagine that once you have several rows of data, it will become even trickier to make sense of.

ip info.gif (730×1 px, 95 KB)

I agree we want to keep horizontal scroll to a minimum. @mszabo do you think we can reduce the widths on some of the columns (especially ones with shorter descriptions like Version)? In the original design it looks like they are tighter widths.

@mszabo made an adjustment for this in the patch we've merged.

Change #1075589 had a related patch set uploaded (by Máté Szabó; author: Máté Szabó):

[mediawiki/extensions/IPInfo@master] Special:IPInfo: Implement fast follow improvements

https://gerrit.wikimedia.org/r/1075589

Testing Notes

  • Special:IPInfo should be available if temporary users are known on the local wiki, and accessible to any user with the ipinfo permission.
  • The page should show a single input field that allows selecting temporary accounts only and provides autocompletion.
  • If the user has not yet accepted the IPInfo data use agreement, a checkbox should be shown on the form to do so. Not accepting the agreement should fail submission.
  • The page description should reflect the configured maximum number of results displayed by this page, as set in $wgIPInfoMaxDistinctIPResults.
  • Data in the table should be subject to the same access control restrictions as the data in the IPInfo infobox on contributions pages.
  • Users with the checkuser-temporary-account right should see IP reveal buttons in the "IP" column within the results table that allow revealing the IPs for those rows.

Change #1075589 merged by jenkins-bot:

[mediawiki/extensions/IPInfo@master] Special:IPInfo: Implement fast follow improvements

https://gerrit.wikimedia.org/r/1075589

Djackson-ctr subscribed.

I have verified the new code has been implemented and is functioning as expected... Thank you for the Testing Notes @mszabo.