Page MenuHomePhabricator
Create Task
Maniphest T350519

Regression: Syntax error in Vector gadget API for portlets and older browsers
Closed, ResolvedPublic1 Estimated Story PointsBUG REPORT
Actions

Assigned To
Jdlrobson
Authored By
Dudhhr
Nov 3 2023, 11:52 PM
Tags
Referenced Files
F41443486: 6BB9411E-BE0E-41F6-91C7-2F861C781AFC.png
Nov 3 2023, 11:52 PM
F41443487: 0568C0AF-78D9-4C9F-8ADC-52D2AD0AC9FD.png
Nov 3 2023, 11:52 PM
Subscribers
Aklapper
Dudhhr
Frostly
Izno
Jdlrobson
Novem_Linguae
TheDJ
Tokens
"Like" token, awarded by Dudhhr.

Description

NOTE: Raised on VPT

Steps to replicate the issue (include links if applicable):

  • Use a device running any version of iOS 12 (iPhone 6, etc)
  • Access any Wikimedia site using the latest version of Mediawiki
  • Log in to the desktop site (tested with Vector 2010 and Vector 2022)
  • Attempt to use a user script

What happens?:
All user scripts (those in common.js, as well as enabled through Preferences) do not load or run.

What should have happened instead?:
User scripts should load and run.

Other information (browser name/version, screenshots, etc.):
The issue was introduced in the MediaWiki update yesterday.
Browser: Safari on iOS 12, tested on iPhone 6 and iPad 5
The issue does not occur on the other browsers I tested (latest Firefox on macOS Ventura, and latest Chrome on Windows 10).
screenshots:

0568C0AF-78D9-4C9F-8ADC-52D2AD0AC9FD.png (1×2 px, 574 KB)

Search previews do not load, either
6BB9411E-BE0E-41F6-91C7-2F861C781AFC.png (1×2 px, 436 KB)

User scripts not loading in the "More" tab, and no Twinkle tab appears
my common.js

Details

SubjectRepoBranchLines +/-
Avoid nullish coalescing operatorsmediawiki/skins/Vectorwmf/1.42.0-wmf.3+6 -7
Avoid nullish coalescing operatorsmediawiki/skins/Vectormaster+6 -7
Customize query in gerrit

Related Objects

Event Timeline

Dudhhr created this task.Nov 3 2023, 11:52 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 3 2023, 11:53 PM
Dudhhr updated the task description. (Show Details)Nov 3 2023, 11:59 PM
Dudhhr awarded a token.
Frostly subscribed.Nov 4 2023, 12:34 AM

Can't reproduce personally; is it working for you now? Have you tried bypassing your cache?

Dudhhr added a comment.Nov 4 2023, 12:39 AM

I deleted my cache and cookies (there's no way to bypass cache on iOS), the issue was not resolved. Are you using iOS 12?

Bugreporter added a project: Browser-Support-Apple-Safari.Nov 4 2023, 3:10 PM
Dudhhr added a comment.Nov 4 2023, 10:05 PM

This issue might be disabling all JavaScript, not just user scripts; I'm not sure. All custom CSS still works.

Dudhhr unsubscribed.Nov 5 2023, 3:39 PM
Dudhhr subscribed.
Dudhhr added a comment.Nov 5 2023, 3:52 PM

This issue does not affect the mobile site.

Izno added subscribers: Jdlrobson, Izno.EditedNov 5 2023, 4:45 PM

@Jdlrobson this is a task that goes with https://en.wikipedia.org/wiki/WP:VPT#Editor_stopped_working , but I don't think it's the same issue as the one described by the OP of that section (who was having their issue in Firefox 119).

Izno added a project: Desktop Improvements (Vector 2022).Nov 5 2023, 4:46 PM
Izno added a comment.Nov 5 2023, 5:44 PM

It's gerrit:963165 and gerrit:967991. ??, the nullish coalescing operator, is from ES2020, so I'm at a loss as to how this got in (@Jdlrobson and Jon (WMF)). Nardog (talk) 08:27, 5 November 2023 (UTC)

Is the relevant line.

Jdlrobson renamed this task from User scripts no longer work on iOS 12 (desktop site) to Syntax error in Vector gadget API for portlets.Nov 5 2023, 7:35 PM
Jdlrobson triaged this task as High priority.
Jdlrobson added a project: Web-Team-Backlog (Web Team FY2023-24 Q2 Sprint 3).

I will get this fixed and backported on Monday.

TheDJ subscribed.Nov 5 2023, 8:54 PM
Jdlrobson renamed this task from Syntax error in Vector gadget API for portlets to Regression: Syntax error in Vector gadget API for portlets and older browsers.Nov 6 2023, 4:37 PM
Jdlrobson added a project: Regression.
Jdlrobson mentioned this in T342815: Provide an API for creating dropdowns in Vector and Vector legacy.
Jdlrobson updated the task description. (Show Details)Nov 6 2023, 4:52 PM
gerritbot added a comment.Nov 6 2023, 5:24 PM

Change 971997 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@master] Avoid nullish coalescing operators

https://gerrit.wikimedia.org/r/971997

gerritbot added a project: Patch-For-Review.Nov 6 2023, 5:24 PM
Jdlrobson added a comment.Nov 6 2023, 5:24 PM

I've opened https://github.com/wikimedia/eslint-config-wikimedia/issues/534 to prevent this happening again.

Novem_Linguae subscribed.Nov 6 2023, 6:29 PM
Jdlrobson set the point value for this task to 1.Nov 6 2023, 6:34 PM
Jdlrobson moved this task from Incoming to Ready for Development on the Web-Team-Backlog (Web Team FY2023-24 Q2 Sprint 3) board.
Jdlrobson moved this task from Ready for Development to Code Review on the Web-Team-Backlog (Web Team FY2023-24 Q2 Sprint 3) board.Nov 6 2023, 6:59 PM
gerritbot added a comment.Nov 6 2023, 7:48 PM

Change 971997 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Avoid nullish coalescing operators

https://gerrit.wikimedia.org/r/971997

gerritbot added a comment.Nov 6 2023, 7:49 PM

Change 972029 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@wmf/1.42.0-wmf.3] Avoid nullish coalescing operators

https://gerrit.wikimedia.org/r/972029

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.4; 2023-11-07).Nov 6 2023, 8:00 PM
Jdlrobson moved this task from Incoming to Technical architecture on the Desktop Improvements (Vector 2022) board.Nov 6 2023, 8:48 PM
gerritbot added a comment.Nov 6 2023, 9:26 PM

Change 972029 merged by jenkins-bot:

[mediawiki/skins/Vector@wmf/1.42.0-wmf.3] Avoid nullish coalescing operators

https://gerrit.wikimedia.org/r/972029

Stashbot added a comment.Nov 6 2023, 9:30 PM

Mentioned in SAL (#wikimedia-operations) [2023-11-06T21:30:35Z] <cjming@deploy2002> Started scap: Backport for [[gerrit:972029|Avoid nullish coalescing operators (T350519)]]

Maintenance_bot removed a project: Patch-For-Review.Nov 6 2023, 9:30 PM
Stashbot added a comment.Nov 6 2023, 9:31 PM

Mentioned in SAL (#wikimedia-operations) [2023-11-06T21:31:50Z] <cjming@deploy2002> jdlrobson and cjming: Backport for [[gerrit:972029|Avoid nullish coalescing operators (T350519)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Jdlrobson moved this task from Code Review to QA on the Web-Team-Backlog (Web Team FY2023-24 Q2 Sprint 3) board.Nov 6 2023, 9:38 PM
Stashbot added a comment.Nov 6 2023, 9:45 PM

Mentioned in SAL (#wikimedia-operations) [2023-11-06T21:45:44Z] <cjming@deploy2002> Finished scap: Backport for [[gerrit:972029|Avoid nullish coalescing operators (T350519)]] (duration: 15m 09s)

ReleaseTaggerBot edited projects, added MW-1.42-notes (1.42.0-wmf.3; 2023-10-31); removed MW-1.42-notes (1.42.0-wmf.4; 2023-11-07).Nov 6 2023, 10:00 PM
Jdlrobson moved this task from QA to Ready for Signoff on the Web-Team-Backlog (Web Team FY2023-24 Q2 Sprint 3) board.Nov 6 2023, 10:26 PM

Can skip QA since it's difficult to test. Will sign off once we've had confirmation on Village technical pump.

Izno closed this task as Resolved.Nov 7 2023, 2:41 AM
Izno assigned this task to Jdlrobson.

Confirmed onwiki to be fixed.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL