Use expression builder instead of raw SQL in TranslationNotifications
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

Now that T210206: Deprecate raw SQL conditions for IDatabase methods (select, insert, etc.) is done, this extension should migrate away from building and passing around raw SQL to expression builders.

It improves readability and security of the code and is more aligned with industry practices easing onboarding.

For more information check T210206 and T350075.

Calls to Database::addQuotes(), ::buildLike(), ::makeList() indicate that raw SQL is being built and passed around.

Details

Subject	Repo	Branch	Lines +/-
Use SelectQueryBuilder::andWhere for conditional conditions	mediawiki/extensions/TranslationNotifications	master	+14 -15
Use Expression builder instead of raw SQL and deprecated methods	mediawiki/extensions/TranslationNotifications	master	+35 -31
Use expression builder to replace uses of addQuotes().	mediawiki/extensions/TranslationNotifications	master	+2 -2

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Open		None	T350075 Migrate raw SQL building in conditions to expression builder in WMF-deployed extensions
		Resolved		Wangombe	T350958 Use expression builder instead of raw SQL in TranslationNotifications

Event Timeline

Maintenance_bot created this task.Nov 10 2023, 4:18 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 10 2023, 4:18 PM

Ladsgroup added a project: TranslationNotifications.Nov 10 2023, 5:07 PM

• Nikerabbit triaged this task as Medium priority.Jan 16 2024, 7:29 AM

• Nikerabbit moved this task from Backlog to Maintenance on the TranslationNotifications board.

Change 992153 had a related patch set uploaded (by Wangombe; author: Wangombe):

[mediawiki/extensions/TranslationNotifications@master] Use expression builder to replace uses of addQuotes().

https://gerrit.wikimedia.org/r/992153

Change 992154 had a related patch set uploaded (by Wangombe; author: Wangombe):

[mediawiki/extensions/TranslationNotifications@master] Use Expression builder instead of raw SQL and deprecared methods

https://gerrit.wikimedia.org/r/992154

Change 992153 merged by jenkins-bot:

[mediawiki/extensions/TranslationNotifications@master] Use expression builder to replace uses of addQuotes().

https://gerrit.wikimedia.org/r/992153

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.16; 2024-01-30).Jan 24 2024, 7:01 PM

Change 992154 merged by jenkins-bot:

[mediawiki/extensions/TranslationNotifications@master] Use Expression builder instead of raw SQL and deprecated methods

https://gerrit.wikimedia.org/r/992154

Maintenance_bot removed a project: Patch-For-Review.Feb 14 2024, 7:30 AM

ReleaseTaggerBot edited projects, added MW-1.42-notes (1.42.0-wmf.19; 2024-02-20); removed MW-1.42-notes (1.42.0-wmf.16; 2024-01-30).Feb 14 2024, 8:01 AM

Wangombe changed the task status from Open to In Progress.Feb 15 2024, 7:43 AM

Wangombe claimed this task.

Wangombe added a project: Language-Team (Language-2024-January-March).

Wangombe set the point value for this task to 2.

Wangombe moved this task from Quarter Backlog to Check after deployment on the Language-Team (Language-2024-January-March) board.

abi_ added a project: Localization Infrastructure FY2023-24.Feb 21 2024, 6:39 AM

Tested existing functionality on MediaWiki.org by sending a test translations to Odia translators. Nothing appears to be broken.

Change 1005643 had a related patch set uploaded (by Wangombe; author: Wangombe):

[mediawiki/extensions/TranslationNotifications@master] Replace usage of wfGetDB(). Use ConnectionProvider

https://gerrit.wikimedia.org/r/1005643

gerritbot added a project: Patch-For-Review.Feb 22 2024, 5:37 AM

• Nikerabbit moved this task from Backlog to Support (LM) on the Localization Infrastructure FY2023-24 board.Feb 26 2024, 10:00 AM

• Nikerabbit removed a project: Patch-For-Review.Feb 29 2024, 3:13 PM

Change #1032875 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/TranslationNotifications@master] Use SelectQueryBuilder::andWhere for conditional conditions

https://gerrit.wikimedia.org/r/1032875

gerritbot added a project: Patch-For-Review.May 17 2024, 9:28 PM

Change #1032875 merged by jenkins-bot: