Page MenuHomePhabricator

[COG] Use expression builder instead of raw SQL in Cognate
Closed, ResolvedPublic

Description

Now that T210206: Deprecate raw SQL conditions for IDatabase methods (select, insert, etc.) is done, this extension should migrate away from building and passing around raw SQL to expression builders.

It improves readability and security of the code and is more aligned with industry practices easing onboarding.

For more information check T210206 and T350075.

Calls to Database::addQuotes(), ::buildLike(), ::makeList() indicate that raw SQL is being built and passed around.

Event Timeline

ItamarWMDE renamed this task from Use expression builder instead of raw SQL in Cognate to [COG] Use expression builder instead of raw SQL in Cognate.Nov 13 2023, 9:55 AM

Change #1015129 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/Cognate@master] Use expression builder to replace use of addQuotes()

https://gerrit.wikimedia.org/r/1015129

Change #1015129 merged by jenkins-bot:

[mediawiki/extensions/Cognate@master] Use expression builder to replace use of addQuotes()

https://gerrit.wikimedia.org/r/1015129