Page MenuHomePhabricator
Create Task
Maniphest T351003

oo-ui-windowManager-floating broken on Timeless
Closed, ResolvedPublicBUG REPORT
Actions

Description

Reported by JoeNMLC at https://en.wikipedia.org/wiki/User_talk:Evad37/rater.js#Rater_broken_-_November_9%2C_2023

Steps to replicate the issue (include links if applicable):

What happens?:

  • Modal is mostly off the page and scrunched together. Barely overflows onto the page in the bottom left.

image.png (341×384 px, 10 KB)

What should have happened instead?:

  • Modal appears front and center, and elements are spaced out.

image.png (775×1 px, 77 KB)

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

  • Worked until recently so this is a Regression
  • Turning off body > .oo-ui-windowManager {position: absolute;} in browser fixes it
  • Here's the HTML code for the modal: <div class="oo-ui-windowManager oo-ui-windowManager-modal oo-ui-windowManager-floating oo-ui-windowManager-size-large">

Details

SubjectRepoBranchLines +/-
Tweak OOUI dialog compatibility styles for better compatibilitymediawiki/skins/Timelessmaster+4 -2
Tweak OOUI dialog compatibility styles for better compatibilitymediawiki/skins/CologneBluemaster+4 -2
Tweak OOUI dialog compatibility styles for better compatibilitymediawiki/skins/Vectormaster+4 -1
Customize query in gerrit

Related Objects

Event Timeline

Novem_Linguae created this task.Nov 10 2023, 7:40 PM
matmarex added subscribers: Evad37, matmarex.Nov 11 2023, 12:58 AM

Probably somehow caused by my changes in T348287 and T350544.

The CologneBlue skin is also affected (I checked them all out of curiosity).

As far as I know, no other gadget is affected, so I wanted to see what in rater.js causes this. The broken styling seems to be a result of this line: https://github.com/evad37/rater/blob/2bb3b81d097f38c0e198928d08e6b1e1ffd32ac5/rater-src/css.js#L39

I don't understand what this position: static; is supposed to do. On the skins where it isn't broken, as far as I can tell, all it does is hide the background in a very roundabout way. Can it be replaced with background: none;?

Novem_Linguae updated the task description. (Show Details)Nov 11 2023, 1:04 AM

@Evad37, thoughts on the above suggested change to Rater?

Vermont subscribed.Nov 14 2023, 10:03 PM
MaterialWorks subscribed.EditedNov 14 2023, 10:33 PM
In T351003#9324348, @matmarex wrote:

Probably somehow caused by my changes in T348287 and T350544.

The CologneBlue skin is also affected (I checked them all out of curiosity).

As far as I know, no other gadget is affected, so I wanted to see what in rater.js causes this. The broken styling seems to be a result of this line: https://github.com/evad37/rater/blob/2bb3b81d097f38c0e198928d08e6b1e1ffd32ac5/rater-src/css.js#L39

I don't understand what this position: static; is supposed to do. On the skins where it isn't broken, as far as I can tell, all it does is hide the background in a very roundabout way. Can it be replaced with background: none;?

position: static; is preventing the window from moving when the scrolling the page, at least on Vector 2010.

gerritbot added a comment.Nov 18 2023, 4:52 PM

Change 975405 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/skins/Timeless@master] Tweak OOUI dialog compatibility styles for better compatibility

https://gerrit.wikimedia.org/r/975405

gerritbot added a project: Patch-For-Review.Nov 18 2023, 4:52 PM

Change 975406 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/skins/CologneBlue@master] Tweak OOUI dialog compatibility styles for better compatibility

https://gerrit.wikimedia.org/r/975406

matmarex added a comment.Nov 18 2023, 4:58 PM

I still think that this is really a problem with the gadget, caused by doing something very weird, but it turns out to be easy enough to work around.

Note that after these changes, it becomes possible to drag the gadget's window behind Timeless's top bar. This is a pre-existing bug in the gadget, also caused by doing the same weird thing.

image.png (2×3 px, 590 KB)

matmarex added a project: CologneBlue.Nov 18 2023, 5:01 PM
gerritbot added a comment.Nov 18 2023, 5:10 PM

Change 975407 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/skins/Vector@master] Tweak OOUI dialog compatibility styles for better compatibility

https://gerrit.wikimedia.org/r/975407

gerritbot added a comment.Nov 21 2023, 5:10 PM

Change 975407 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Tweak OOUI dialog compatibility styles for better compatibility

https://gerrit.wikimedia.org/r/975407

gerritbot added a comment.Nov 21 2023, 5:10 PM

Change 975405 merged by jenkins-bot:

[mediawiki/skins/Timeless@master] Tweak OOUI dialog compatibility styles for better compatibility

https://gerrit.wikimedia.org/r/975405

gerritbot added a comment.Nov 21 2023, 5:10 PM

Change 975406 merged by jenkins-bot:

[mediawiki/skins/CologneBlue@master] Tweak OOUI dialog compatibility styles for better compatibility

https://gerrit.wikimedia.org/r/975406

matmarex closed this task as Resolved.Nov 21 2023, 5:26 PM
matmarex claimed this task.

The changes will be deployed to Wikimedia wikis next week, per the usual schedule.

Maintenance_bot removed a project: Patch-For-Review.Nov 21 2023, 5:30 PM
ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.7; 2023-11-28).Nov 21 2023, 6:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL