Page MenuHomePhabricator
Create Task
Maniphest T351195

WikimediaEvents: Remove partial migration of *UIActions instrument
Closed, ResolvedPublic3 Estimated Story PointsBUG REPORT
Actions

Description

Description

There is a partial migration of the *UIActions instrument to the MP client library. It uses dispatch(), which is now deprecated in favour of submitInteraction(). We (Data Products) are currently discussing collaborating with the owners of the instrument, Web, who have signalled that they want it to be stable while they establish new baseline metrics for an upcoming project.

We should remove the partial migration of the instrument to minimise our own maintenance burden but, right now, not attempt to update the instrument to use submitInteractionEvent().

Acceptance criteria

Details

SubjectRepoBranchLines +/-
Remove mediawiki.web_ui.interactions event streamoperations/mediawiki-configmaster+0 -51
Revert "*WebUIActionsTracking: Also log events via Metrics Platform"mediawiki/extensions/WikimediaEventsmaster+0 -40
Revert "*WebUIActionsTracking: Also log events via Metrics Platform"mediawiki/extensions/WikimediaEventsmaster+2 -43
Customize query in gerrit

Event Timeline

phuedx created this task.Nov 14 2023, 11:48 AM
phuedx created this object with edit policy "All Users".
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 14 2023, 11:48 AM
Aklapper added a project: MediaWiki-extensions-WikimediaEvents.Nov 14 2023, 11:54 AM

(Assuming this task is about the #WikimediaEvents code base, thus adding that project tag so other people who don't know or don't care about team tags can also find this task when searching via projects. Please set appropriate codebase project tags when possible. Thanks!)

VirginiaPoundstone triaged this task as High priority.Nov 14 2023, 2:09 PM
VirginiaPoundstone edited projects, added Data Products (Data Products Sprint 04); removed Data Products.
phuedx updated the task description. (Show Details)Nov 15 2023, 1:29 PM
phuedx added a project: Technical-Debt.Nov 15 2023, 5:53 PM
phuedx updated the task description. (Show Details)Nov 16 2023, 9:44 PM
Sfaci claimed this task.Nov 20 2023, 4:38 PM
Sfaci moved this task from Sprint Backlog to In Process on the Data Products (Data Products Sprint 04) board.
Milimetric set the point value for this task to 3.Nov 20 2023, 5:09 PM
gerritbot added a comment.Nov 21 2023, 12:31 PM

Change 976181 had a related patch set uploaded (by Santiago Faci; author: Santiago Faci):

[mediawiki/extensions/WikimediaEvents@master] Revert "*WebUIActionsTracking: Also log events via Metrics Platform"

https://gerrit.wikimedia.org/r/976181

gerritbot added a project: Patch-For-Review.Nov 21 2023, 12:31 PM
gerritbot added a comment.Nov 21 2023, 12:54 PM

Change 976181 abandoned by Santiago Faci:

[mediawiki/extensions/WikimediaEvents@master] Revert "*WebUIActionsTracking: Also log events via Metrics Platform"

Reason:

https://gerrit.wikimedia.org/r/976181

Maintenance_bot removed a project: Patch-For-Review.Nov 21 2023, 1:10 PM
gerritbot added a comment.Nov 21 2023, 1:14 PM

Change 976209 had a related patch set uploaded (by Santiago Faci; author: Santiago Faci):

[mediawiki/extensions/WikimediaEvents@master] Revert "*WebUIActionsTracking: Also log events via Metrics Platform"

https://gerrit.wikimedia.org/r/976209

gerritbot added a project: Patch-For-Review.Nov 21 2023, 1:14 PM
Sfaci added a comment.EditedNov 21 2023, 1:24 PM

The last change above removes all the code about the partial migration of the instrument. It reverts all the changes made previously in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikimediaEvents/+/799353/

phuedx updated the task description. (Show Details)Nov 21 2023, 3:32 PM
phuedx moved this task from In Process to To Deploy on the Data Products (Data Products Sprint 04) board.
gerritbot added a comment.Nov 21 2023, 3:34 PM

Change 976209 merged by jenkins-bot:

[mediawiki/extensions/WikimediaEvents@master] Revert "*WebUIActionsTracking: Also log events via Metrics Platform"

https://gerrit.wikimedia.org/r/976209

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.7; 2023-11-28).Nov 21 2023, 4:00 PM
Maintenance_bot removed a project: Patch-For-Review.Nov 21 2023, 4:10 PM
gerritbot added a comment.Nov 23 2023, 8:46 AM

Change 976930 had a related patch set uploaded (by Phuedx; author: Phuedx):

[operations/mediawiki-config@master] Remove mediawiki.web_ui.interactions event stream

https://gerrit.wikimedia.org/r/976930

gerritbot added a project: Patch-For-Review.Nov 23 2023, 8:46 AM
gerritbot added a comment.Nov 28 2023, 2:21 PM

Change 976930 merged by jenkins-bot:

[operations/mediawiki-config@master] Remove mediawiki.web_ui.interactions event stream

https://gerrit.wikimedia.org/r/976930

Stashbot added a comment.Nov 28 2023, 2:21 PM

Mentioned in SAL (#wikimedia-operations) [2023-11-28T14:21:58Z] <lucaswerkmeister-wmde@deploy2002> Started scap: Backport for [[gerrit:976930|Remove mediawiki.web_ui.interactions event stream (T351195)]]

Stashbot added a comment.Nov 28 2023, 2:23 PM

Mentioned in SAL (#wikimedia-operations) [2023-11-28T14:23:21Z] <lucaswerkmeister-wmde@deploy2002> lucaswerkmeister-wmde and phuedx: Backport for [[gerrit:976930|Remove mediawiki.web_ui.interactions event stream (T351195)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Maintenance_bot removed a project: Patch-For-Review.Nov 28 2023, 2:30 PM
Stashbot added a comment.Nov 28 2023, 2:39 PM

Mentioned in SAL (#wikimedia-operations) [2023-11-28T14:39:35Z] <lucaswerkmeister-wmde@deploy2002> Finished scap: Backport for [[gerrit:976930|Remove mediawiki.web_ui.interactions event stream (T351195)]] (duration: 17m 36s)

phuedx moved this task from To Deploy to Done on the Data Products (Data Products Sprint 04) board.Nov 29 2023, 9:54 AM
phuedx updated the task description. (Show Details)Dec 7 2023, 11:02 AM
WDoranWMF closed this task as Resolved.Jan 24 2024, 4:45 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL